Hi Gerd, I have uploaded example at http://files.mkgmap.org.uk/download/392/test-crash.7z. java.lang.IndexOutOfBoundsException at java.nio.Buffer.checkIndex(Unknown Source) at java.nio.DirectByteBuffer.getShort(Unknown Source) at uk.me.parabola.mkgmap.reader.hgt.HGTReader.ele(HGTReader.java:203) at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getElevation(HGTConverter.java:108) at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getHeights(HGTConverter.java:302) at uk.me.parabola.imgfmt.app.dem.DEMSection.calcTiles(DEMSection.java:127) at uk.me.parabola.imgfmt.app.dem.DEMSection.<init>(DEMSection.java:74) at uk.me.parabola.imgfmt.app.dem.DEMFile.calc(DEMFile.java:96) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:322) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:263) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:259) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Exiting - if you want to carry on regardless, use the --keep-going option -- Best regards, Andrzej
Hi, addition: mkgmap compiles this example, if I remove --dem-dists. -- Best regards, Andrzej
Hi Andrzej, thanks, fixed with r4061: http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4061 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Montag, 15. Januar 2018 00:28:45 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] v4058 dem-tdb crashes Hi, addition: mkgmap compiles this example, if I remove --dem-dists. -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I have tried to compile South America and tripped on another crash. This is version 4065, it crashes regardless if HGT is present or not. http://files.mkgmap.org.uk/detail/395 java.lang.ArrayIndexOutOfBoundsException: 5 at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getElevation(HGTConverter.java:91) at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getHeights(HGTConverter.java:308) at uk.me.parabola.imgfmt.app.dem.DEMSection.calcTiles(DEMSection.java:128) at uk.me.parabola.imgfmt.app.dem.DEMSection.<init>(DEMSection.java:74) at uk.me.parabola.imgfmt.app.dem.DEMFile.calc(DEMFile.java:61) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:322) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:263) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:259) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Exiting - if you want to carry on regardless, use the --keep-going option -- Best regards, Andrzej
Hi Andrzej, seems to be a rounding problem at lat=0. I'll look at it tomorrow. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Montag, 15. Januar 2018 22:26:03 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] v4058 dem-tdb crashes Hi Gerd, I have tried to compile South America and tripped on another crash. This is version 4065, it crashes regardless if HGT is present or not. http://files.mkgmap.org.uk/detail/395 java.lang.ArrayIndexOutOfBoundsException: 5 at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getElevation(HGTConverter.java:91) at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getHeights(HGTConverter.java:308) at uk.me.parabola.imgfmt.app.dem.DEMSection.calcTiles(DEMSection.java:128) at uk.me.parabola.imgfmt.app.dem.DEMSection.<init>(DEMSection.java:74) at uk.me.parabola.imgfmt.app.dem.DEMFile.calc(DEMFile.java:61) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:322) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:263) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:259) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Exiting - if you want to carry on regardless, use the --keep-going option -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Andrzej, I think I found a fix for this, see http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4066 Quite funny: I expected this kind of error with your 1st patch (dem-align.patch), now it happened without ;-) Working on unit tests for this code now, not yet sure if I should create temp hgt files or if should add some existing hgt files to the test resources. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Montag, 15. Januar 2018 22:39:33 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] v4058 dem-tdb crashes Hi Andrzej, seems to be a rounding problem at lat=0. I'll look at it tomorrow. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Montag, 15. Januar 2018 22:26:03 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] v4058 dem-tdb crashes Hi Gerd, I have tried to compile South America and tripped on another crash. This is version 4065, it crashes regardless if HGT is present or not. http://files.mkgmap.org.uk/detail/395 java.lang.ArrayIndexOutOfBoundsException: 5 at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getElevation(HGTConverter.java:91) at uk.me.parabola.mkgmap.reader.hgt.HGTConverter.getHeights(HGTConverter.java:308) at uk.me.parabola.imgfmt.app.dem.DEMSection.calcTiles(DEMSection.java:128) at uk.me.parabola.imgfmt.app.dem.DEMSection.<init>(DEMSection.java:74) at uk.me.parabola.imgfmt.app.dem.DEMFile.calc(DEMFile.java:61) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:322) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:263) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:259) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Exiting - if you want to carry on regardless, use the --keep-going option -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, thanks again, America South compiled OK. A tile with lower edge at 0 compiles properly, but don't you expect the same problem with lower or right border? -- Best regards, Andrzej
Hi Andrzej, the same problem occured with maxlon=0 in r4065. The new code works fine as long as you don't try to retrieve data outside the initial area. I've added some unit tests to prove that now, see http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4068 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Dienstag, 16. Januar 2018 14:59:40 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] v4058 dem-tdb crashes Hi Gerd, thanks again, America South compiled OK. A tile with lower edge at 0 compiles properly, but don't you expect the same problem with lower or right border? -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (2)
-
Andrzej Popowski -
Gerd Petermann