Problem writing line ...

Hi Ticker, please see https://files.mkgmap.org.uk/detail/513 This is what I get: D:\mkgmap>java -ea -jar dist\mkgmap.jar e:\osm_out_work\norway\20210511_095323\63240001.o5m Mkgmap version 4763 Time started: Thu Jun 10 10:50:35 CEST 2021 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x16 containing 30 points and starting at http://www.openstreetmap.org/?mlat=62.987366&mlon=-1.137106&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Subdivision shift is 0 and its centre is at http://www.openstreetmap.org/?mlat=62.263577&mlon=-1.478584&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: deltaLat = 33731 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Thu Jun 10 10:50:48 CEST 2021 Total time taken: 13 seconds I've not looked at all the details, but the polygon overlaps the inital area extremely. The attached patch fixes the problem but I have not tested any side effects. Gerd

Hi Gerd Just tried this on my low-res build without your patch and don't get a problem, but might be because of different options or pending ShapeSplitter changes. What options are you using? I'll disable my other changes and try again Ticker On Thu, 2021-06-10 at 09:00 +0000, Gerd Petermann wrote:
Hi Ticker,
please see https://files.mkgmap.org.uk/detail/513 This is what I get: D:\mkgmap>java -ea -jar dist\mkgmap.jar e:\osm_out_work\norway\20210511_095323\63240001.o5m Mkgmap version 4763 Time started: Thu Jun 10 10:50:35 CEST 2021 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x16 containing 30 points and starting at http://www.openstreetmap.org/?mlat=62.987366&mlon=-1.137106&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Subdivision shift is 0 and its centre is at http://www.openstreetmap.org/?mlat=62.263577&mlon=-1.478584&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: deltaLat = 33731 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Thu Jun 10 10:50:48 CEST 2021 Total time taken: 13 seconds
I've not looked at all the details, but the polygon overlaps the inital area extremely. The attached patch fixes the problem but I have not tested any side effects.
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Ticker, I got this with trunk and no options, just -ea is important. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 10. Juni 2021 12:07 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Problem writing line ... Hi Gerd Just tried this on my low-res build without your patch and don't get a problem, but might be because of different options or pending ShapeSplitter changes. What options are you using? I'll disable my other changes and try again Ticker On Thu, 2021-06-10 at 09:00 +0000, Gerd Petermann wrote:
Hi Ticker,
please see https://files.mkgmap.org.uk/detail/513 This is what I get: D:\mkgmap>java -ea -jar dist\mkgmap.jar e:\osm_out_work\norway\20210511_095323\63240001.o5m Mkgmap version 4763 Time started: Thu Jun 10 10:50:35 CEST 2021 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x16 containing 30 points and starting at http://www.openstreetmap.org/?mlat=62.987366&mlon=-1.137106&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Subdivision shift is 0 and its centre is at http://www.openstreetmap.org/?mlat=62.263577&mlon=-1.478584&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: deltaLat = 33731 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Thu Jun 10 10:50:48 CEST 2021 Total time taken: 13 seconds
I've not looked at all the details, but the polygon overlaps the inital area extremely. The attached patch fixes the problem but I have not tested any side effects.
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Gerd OK - I get the problem now, it was --order-by that stopped it happening. I think this oversize polygon should have been handled by MapArea and the maxSize/maxWidth/maxHeight limits and I'm now trying to work out why it isn't. Ticker On Thu, 2021-06-10 at 10:19 +0000, Gerd Petermann wrote:
Hi Ticker,
I got this with trunk and no options, just -ea is important.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 10. Juni 2021 12:07 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Problem writing line ...
Hi Gerd
Just tried this on my low-res build without your patch and don't get a problem, but might be because of different options or pending ShapeSplitter changes.
What options are you using? I'll disable my other changes and try again
Ticker
On Thu, 2021-06-10 at 09:00 +0000, Gerd Petermann wrote:
Hi Ticker,
please see https://files.mkgmap.org.uk/detail/513 This is what I get: D:\mkgmap>java -ea -jar dist\mkgmap.jar e:\osm_out_work\norway\20210511_095323\63240001.o5m Mkgmap version 4763 Time started: Thu Jun 10 10:50:35 CEST 2021 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x16 containing 30 points and starting at http://www.openstreetmap.org/?mlat=62.987366&mlon=-1.137106&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Subdivision shift is 0 and its centre is at http://www.openstreetmap.org/?mlat=62.263577&mlon=-1.478584&zoom=17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: deltaLat = 33731 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Thu Jun 10 10:50:48 CEST 2021 Total time taken: 13 seconds
I've not looked at all the details, but the polygon overlaps the inital area extremely. The attached patch fixes the problem but I have not tested any side effects.
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Gerd I think you patch is the best solution. I was worried that it would interfere with the subdiv/area sizing rules when --order-by, which does allow very slightly oversized polgons, but these are never big enough to cause the next level down to exceed MAX_DIVISION_SIZE. Ticker On Thu, 2021-06-10 at 11:56 +0100, Ticker Berkin wrote:
Hi Gerd
OK - I get the problem now, it was --order-by that stopped it happening. I think this oversize polygon should have been handled by MapArea and the maxSize/maxWidth/maxHeight limits and I'm now trying to work out why it isn't.
Ticker
On Thu, 2021-06-10 at 10:19 +0000, Gerd Petermann wrote:
Hi Ticker,
I got this with trunk and no options, just -ea is important.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 10. Juni 2021 12:07 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Problem writing line ...
Hi Gerd
Just tried this on my low-res build without your patch and don't get a problem, but might be because of different options or pending ShapeSplitter changes.
What options are you using? I'll disable my other changes and try again
Ticker
On Thu, 2021-06-10 at 09:00 +0000, Gerd Petermann wrote:
Hi Ticker,
please see https://files.mkgmap.org.uk/detail/513 This is what I get: D:\mkgmap>java -ea -jar dist\mkgmap.jar e:\osm_out_work\norway\20210511_095323\63240001.o5m Mkgmap version 4763 Time started: Thu Jun 10 10:50:35 CEST 2021 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x16 containing 30 points and starting at http://www.openstreetmap.org/?mlat=62.987366&mlon=-1.137106&zoom= 17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: Subdivision shift is 0 and its centre is at http://www.openstreetmap.org/?mlat=62.263577&mlon=-1.478584&zoom= 17 SCHWERWIEGEND (Polyline): e:\osm_out_work\norway\20210511_095323\63240001.o5m: deltaLat = 33731 Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Thu Jun 10 10:50:48 CEST 2021 Total time taken: 13 seconds
I've not looked at all the details, but the polygon overlaps the inital area extremely. The attached patch fixes the problem but I have not tested any side effects.
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
Gerd Petermann
-
Gerd Petermann
-
Ticker Berkin