Commit: r1625: Translate amenity=zoo at resolution 20 like tourism=zoo,

Version 1625 was commited by marko on 2010-03-29 09:16:46 +0100 (Mon, 29 Mar 2010) Translate amenity=zoo at resolution 20 like tourism=zoo, and note that amenity=supermarket and amenity=zoo are deprecated.

Hi!
Version 1625 was commited by marko on 2010-03-29 09:16:46 +0100 (Mon, 29 Mar 2010)
Translate amenity=zoo at resolution 20 like tourism=zoo, and note that amenity=supermarket and amenity=zoo are deprecated.
I am very new to Java. Could you for example tell me in which module you changed something? I tried to find out where for example the options are processed, but no chance ... TIA, Dani

Daniela Duerbeck wrote:
Hi!
Version 1625 was commited by marko on 2010-03-29 09:16:46 +0100 (Mon, 29 Mar 2010)
Translate amenity=zoo at resolution 20 like tourism=zoo, and note that amenity=supermarket and amenity=zoo are deprecated.
I am very new to Java. Could you for example tell me in which module you changed something? I tried to find out where for example the options are processed, but no chance ...
TIA, Dani
Look in the folder mkgmap-svn/mkgmap/resources/styles/default/ and you will find the default style files. The point file (/mkgmap/resources/styles/default/point) is the one which was changed. These style rules are not java source code, they are rules read in by the source code. See # amenity=supermarket is superceded by shop=supermarket amenity=supermarket [0x2e02 resolution 20] And # amenity=zoo is superceded by tourism=zoo amenity=zoo [0x2c07 resolution 20] I think the modules that do the work are here mkgmap/src/uk/me/parabola/mkgmap/osmstyle But I am also a beginner with Java and have not tried making sense of them. Garvan

Garvan & maew wrote:
Look in the folder
mkgmap-svn/mkgmap/resources/styles/default/
and you will find the default style files. The point file (/mkgmap/resources/styles/default/point) is the one which was changed. These style rules are not java source code, they are rules read in by
ok, that was a bad point to start with. but another question: where is the entry point where the options are processed? TIA, Dani

ok, that was a bad point to start with. but another question: where is the entry point where the options are processed?
TIA, Dani
There is no central entry point for option processing. It is scattered over the whole application. There is a central class CommandArgs.class, but there are only a few options explicit defined. Most of the options are stored in the EnhancedProperties.class. This class serves the option values by string keys. Its called from the place, where the option is needed. Its IMHO not a good solution, but very flexible to introduce new options. Regards, Johann

Johann Gail wrote:
Its IMHO not a good solution, but very flexible to introduce new options.
I asked since it seems a bit magic to me where the options are processed. If I for example search over the src directory with Windows search for all files that contain "areas" in, I find just two html-files. When I am back from holidays I will search with Linux. Sometimes Windows cannot find correctly ... Dani

Johann Gail wrote:
Its IMHO not a good solution, but very flexible to introduce new options.
I asked since it seems a bit magic to me where the options are processed. If I for example search over the src directory with Windows search for all files that contain "areas" in, I find just two html-files. When I am back from holidays I will search with Linux. Sometimes Windows cannot find correctly ...
There is something really wrong with your search function. If I search all *.java files of the project (with the gnome commander at linux, btw. :-)), it finds 55 files including this string. But it should not be a matter of the used OS, if it finds text inside files. Are you sure, you haven't set a wrong file filter? An example for the option parsing is contained in MapBuilder.java. There are several flags and values set. See below. countryName = props.getProperty("country-name", countryName); countryAbbr = props.getProperty("country-abbr", countryAbbr); regionName = props.getProperty("region-name", null); regionAbbr = props.getProperty("region-abbr", null); reducePointError = props.getProperty("reduce-point-density", 2.6); mergeLines = props.containsKey("merge-lines"); makePOIIndex = props.getProperty("make-poi-index", false); if(props.getProperty("no-poi-address", null) != null) poiAddresses = false; String autoFillPar = props.getProperty("location-autofill", null); Have a nice holiday, Johann Gail

Hi Johann!
There is something really wrong with your search function. If I search all *.java files of the project (with the gnome commander at linux, btw. :-)), it finds 55 files including this string. But it should not be a matter of the used OS, if it finds text inside files. Are you sure, you haven't set a wrong file filter?
Pretty sure, I tried it on two different computers, with everything on: Search hidden files, search system directories, do not consider upper/lower case, and so on. After now knowing that "area" is in StyledConverter.java I renamed it to StyledConverter.txt and now it is found. But I find no rule in the windows search that excludes java-files from being searched, I chose "all files and folders". When I cut off the extension, it is not found. When I search for files with name *.java that contain area also nothing is found. When I rename the file to .doc it is not found, called .rtf it is found. .c: yes, the same with .h. Now I am pretty sure that Windows XP has a list of text file types that a "worth" being searched. Others are excluded. So the Windows search "inside files" is pretty useless. But I am not astonished about that. Dani

Daniela Duerbeck wrote:
Now I am pretty sure that Windows XP has a list of text file types that a "worth" being searched. Others are excluded. So the Windows search "inside files" is pretty useless. But I am not astonished about that.
Somewhat off topic for mkgmap, but you might find this useful: http://unxutils.sourceforge.net/ There's a "grep" in there that will actually find stuff that you actually search for! If you're not familiar with Unix/Linux its syntax may take some getting used to, but it, and some of the other utilities in there can be extremely useful.

Hi! On Wed, Mar 31, 2010 at 12:12:53AM +0100, Daniela Duerbeck wrote:
Hi!
Version 1625 was commited by marko on 2010-03-29 09:16:46 +0100 (Mon, 29 Mar 2010)
Translate amenity=zoo at resolution 20 like tourism=zoo, and note that amenity=supermarket and amenity=zoo are deprecated.
I am very new to Java. Could you for example tell me in which module you changed something?
Like Garvan said, I did not change anything in Java code, but in the default style: http://svn.parabola.me.uk/svn/mkgmap/trunk/resources/styles/default If you are new to Subversion, go to http://svnbook.red-bean.com/ to read the documentation. If you have checked out the repository with svn co http://svn.parabola.me.uk/svn/mkgmap/trunk mkgmap you can use "svn log" in your working copy to find out the history up to the locally checked version or use "svn diff" with a -r or -c argument to find out about changes from a given revision or between given revisions.
I tried to find out where for example the options are processed, but no chance ...
As far as I understand, the processing of command line options is scattered all over the place. The style definitions are parsed in the osmstyle module: http://svn.parabola.me.uk/svn/mkgmap/trunk/src/uk/me/parabola/mkgmap/osmstyl... Marko
participants (6)
-
Daniela Duerbeck
-
Garvan & maew
-
Johann Gail
-
Marko Mäkelä
-
SomeoneElse
-
svn commit