splitter r386 - version number
Hi, I maintain the Arch Linux splitter package. [1] The most recent release of splitter, r386, fails to output a version number. To wit: [ichimonji10@hardhack:splitter]$ splitter --version splitter unknown compiled unknown Executing `splitter --help` indicates that the "version" number no longer exists. Is this intentional? The previous release, r381, does not exhibit this behaviour. If it helps, the executable has shrunk down from 2.1 MB to 1.6 MB. Please CC me when replying, as I am not subscribed to the mailing list. (I believe this is necessary?) — Jeremy "Ichimonji10" Audet [1] https://aur.archlinux.org/packages/splitter/
Hi Thanks for noticing this and letting us know.
Executing `splitter --help` indicates that the "version" number no longer exists. Is this intentional? The previous release, r381, does not exhibit this behaviour. If it helps, the executable has shrunk down from 2.1 MB to 1.6 MB.
I don't think there is any intention to remove the version option, but I will leave to Gerd to confirm that. The build process does not create the version information if there is not a 'resources' directory. This was removed from the release since it is otherwise empty after moving the build to an ivy based one. I didn't realise that side affect at the time. The distribution is smaller because it does not include the testng jar file, which is a test only dependency and not a runtime one. @Gerd You can just add an empty resources directory to fix the version number in the distribution, or I could fix it in the distribution build script if you would prefer. Also could you decide if you don't want testng to be included in the distribution. I don't think it is necessary, since it will be automatically downloaded should anyone build from the included sources, but it is up to you. ..Steve
Hi, thanks for the hint reg. --version. Should be fixed with r387. @Steve : I think there is no need for the testng.jar in the dist package. In fact I think about using junit for splitter as well, I just did not find a good way to implement more tests. Gerd
Date: Tue, 20 May 2014 17:11:17 +0100 From: steve@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk CC: ichimonji10@gmail.com Subject: Re: [mkgmap-dev] splitter r386 - version number
Hi
Thanks for noticing this and letting us know.
Executing `splitter --help` indicates that the "version" number no longer exists. Is this intentional? The previous release, r381, does not exhibit this behaviour. If it helps, the executable has shrunk down from 2.1 MB to 1.6 MB.
I don't think there is any intention to remove the version option, but I will leave to Gerd to confirm that.
The build process does not create the version information if there is not a 'resources' directory. This was removed from the release since it is otherwise empty after moving the build to an ivy based one. I didn't realise that side affect at the time.
The distribution is smaller because it does not include the testng jar file, which is a test only dependency and not a runtime one.
@Gerd You can just add an empty resources directory to fix the version number in the distribution, or I could fix it in the distribution build script if you would prefer. Also could you decide if you don't want testng to be included in the distribution. I don't think it is necessary, since it will be automatically downloaded should anyone build from the included sources, but it is up to you.
..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
r387 exhibits the exact same behaviour. Executing `splitter --help` does not show a "version" option, and executing `splitter --version` fails. — Jeremy "Ichimonji10" Audet
Hi Jeremy,
r387 exhibits the exact same behaviour. Executing `splitter --help` does not show a "version" option, and executing `splitter --version` fails.
Yes, the help doesn't show the version option. This was also the case with older releases. Also --help itself doesn't appear. I've changed that with r388. I have no idea why --version doesn't work with the official version. It works when I build from a fresh svn checkout. @Steve: The official splitter.jar still doesn't contain splitter-version.properties . Gerd
On 21/05/14 05:07, Gerd Petermann wrote:
@Steve: The official splitter.jar still doesn't contain splitter-version.properties .
The build target in build.xml use to copy stuff from the resources directory to the build/classes directory: <copy todir="${build.classes}"> <fileset dir="${resources}"> <include name="*.csv"/> <include name="*.properties"/> <include name="**/*.trans"/> </fileset> </copy> This got removed along with the directory. Only the *.properties part is needed. ..Steve
Hi Steve, I am not sure what you mean. If I execute ant -d > build.log on a clean copy I find this: ... check-version: [property] Loading D:\splitter-r387\build\classes\splitter-version.properties [property] Unable to find property file: D:\splitter-r387\build\classes\splitter-version.properties Property "svn.version" has not been set Condition false; not setting have.version ... version-file: Override ignored for property "project.version" Override ignored for property "svn.version.build" [propertyfile] Creating new property file: D:\splitter-r387\build\classes\splitter-version.properties ... [jar] adding entry splitter-version.properties ... So, with the build.xml in svn everything works fine. I assume that you have a different build.xml ? Gerd
Date: Wed, 21 May 2014 05:48:01 +0100 From: steve@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] splitter r386 - version number
On 21/05/14 05:07, Gerd Petermann wrote:
@Steve: The official splitter.jar still doesn't contain splitter-version.properties .
The build target in build.xml use to copy stuff from the resources directory to the build/classes directory:
<copy todir="${build.classes}"> <fileset dir="${resources}"> <include name="*.csv"/> <include name="*.properties"/> <include name="**/*.trans"/> </fileset> </copy>
This got removed along with the directory. Only the *.properties part is needed.
..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd [Sorry was not well yesterday]
So, with the build.xml in svn everything works fine. I assume that you have a different build.xml ?
Same build.xml, but it is not built in svn. The build script is in scripts/download/mksnap. The distribution is created with 'svn export' and the version file is created in resources. Then the source archives are made from this directory which is then built. It is done this way so that --version also works when you build from the source archive as well as directly from svn. Well that the idea, I just tried building from the source download and --version doesn't completely work either, will look into that. It is OK for mkgmap. ..Steve
Hi Steve, I think it works with r389, but I did not try to compile the sources in that package. Gerd Steve Ratcliffe wrote
Hi Gerd
[Sorry was not well yesterday]
So, with the build.xml in svn everything works fine. I assume that you have a different build.xml ?
Same build.xml, but it is not built in svn.
The build script is in scripts/download/mksnap.
The distribution is created with 'svn export' and the version file is created in resources. Then the source archives are made from this directory which is then built. It is done this way so that --version also works when you build from the source archive as well as directly from svn.
Well that the idea, I just tried building from the source download and --version doesn't completely work either, will look into that. It is OK for mkgmap.
..Steve
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/splitter-r386-version-number-tp5806858p580704... Sent from the Mkgmap Development mailing list archive at Nabble.com.
participants (4)
-
Gerd Petermann -
GerdP
-
Jeremy Audet -
Steve Ratcliffe