[PATCH v1] Prefer multiples of 2048 as cut coordinates in multipolygons
Based on the proposal of Ralf Kleineisel the patch tries to cut multipolygons at multiples of 2048 in Garmin coordinates. This reduces artefacts at the cut lines of the multipolygons. The patch contains also a fix for the bug found by Nakor (Some inner areas are ignored in mulitpolygon processing). Please test it soon. I plan to commit that within the next 2 days if noone complains about it. WanMil
On Sun, Apr 03, 2011 at 09:20:55PM +0200, WanMil wrote:
Based on the proposal of Ralf Kleineisel the patch tries to cut multipolygons at multiples of 2048 in Garmin coordinates. This reduces artefacts at the cut lines of the multipolygons.
The patch contains also a fix for the bug found by Nakor (Some inner areas are ignored in mulitpolygon processing).
Please test it soon. I plan to commit that within the next 2 days if noone complains about it.
I tested this patch, and it does not seem to break anything for me. I have not paid attention to the number of multipolygon cut lines in the past, so I cannot say if this patch reduces them considerably. Marko
On Mon, 4 Apr 2011 10:11:18 +0300, mkgmap-dev-bounces@lists.mkgmap.org.uk wrote:
On Sun, Apr 03, 2011 at 09:20:55PM +0200, WanMil wrote:
Based on the proposal of Ralf Kleineisel the patch tries to cut multipolygons at multiples of 2048 in Garmin coordinates. This reduces artefacts at the cut lines of the multipolygons.
The patch contains also a fix for the bug found by Nakor (Some inner areas are ignored in mulitpolygon processing).
Please test it soon. I plan to commit that within the next 2 days if noone complains about it.
I tested this patch, and it does not seem to break anything for me. I have not paid attention to the number of multipolygon cut lines in the past, so I cannot say if this patch reduces them considerably.
Marko
If someone can compile a jar file for me I'd like to test this. I recently built a map of Thailand and Malaysia and with all the islands the multipolygon artefacts in Mapsource are quite extreme.
On Mon, Apr 04, 2011 at 10:21:22AM +0300, Charlie Ferrero wrote:
If someone can compile a jar file for me I'd like to test this. I recently built a map of Thailand and Malaysia and with all the islands the multipolygon artefacts in Mapsource are quite extreme.
There are quite a few tiny islands on the Baltic sea and in the thousands of lakes of Finland. If they are closer than 2048 Garmin units apart and smaller than 2048 Garmin units, what can the patch do? I suppose that the patch could be good for large islands. Marko
Am 04.04.2011 09:34, schrieb Marko Mäkelä:
On Mon, Apr 04, 2011 at 10:21:22AM +0300, Charlie Ferrero wrote:
If someone can compile a jar file for me I'd like to test this. I recently built a map of Thailand and Malaysia and with all the islands the multipolygon artefacts in Mapsource are quite extreme.
There are quite a few tiny islands on the Baltic sea and in the thousands of lakes of Finland. If they are closer than 2048 Garmin units apart and smaller than 2048 Garmin units, what can the patch do?
I suppose that the patch could be good for large islands.
Marko
I've tested the patch with finland only (that's my primary multipolygon test area ;-) and except for some cases the white artefacts disappeared. But of course, if an island does not cross the 2048 grid the patch cannot place a cutting line on a 2048 garmin unit. WanMil
I just made a jar file with that patch and uploaded it at [1]. This build additionally includes the patch posted by Steve a couple of days ago that should fix address search. - Bartosz [1] http://www.fabianowski.eu/osm/mkgmap/mkgmap.jar
On Apr 3, 2011, at 21:20, WanMil wrote:
Please test it soon. I plan to commit that within the next 2 days if noone complains about it.
I've also done some initial testing and have not found any issues so far. Cheers.
participants (5)
-
Bartosz Fabianowski -
Charlie Ferrero -
Clinton Gladstone -
Marko Mäkelä -
WanMil