Commit r3743: Reduce rounding error when saving initial heading in compacted format
Version mkgmap-r3743 was committed by gerd on Sun, 08 Jan 2017 Reduce rounding error when saving initial heading in compacted format http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3743
Hi all, r3743 should fix some of the routing errors reported by Carlos and Andrzej. The old code always rounded down when saving the heading in the compacted format, so that e.g. 0x2f was rounded to 0x20 instead of 0x30. The compacted format saves only the topmost 4 bits. @Carlos, Andrzej: Please can you verify that this also solves the problem. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von svn commit <svn@mkgmap.org.uk> Gesendet: Sonntag, 8. Januar 2017 15:08:40 An: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Commit r3743: Reduce rounding error when saving initial heading in compacted format Version mkgmap-r3743 was committed by gerd on Sun, 08 Jan 2017 Reduce rounding error when saving initial heading in compacted format http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3743 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, all these problematic routes are correct in BaseCamp with r3743. -- Best regards, Andrzej
Hi Andrzej, thanks for the feedback and thanks to you and Carlos for reporting this problem. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Sonntag, 8. Januar 2017 19:35:44 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Commit r3743: Reduce rounding error when saving initial heading in compacted format Hi Gerd, all these problematic routes are correct in BaseCamp with r3743. -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
I'm sorry for the late replay. As for Andrzej, it fixed routing problems. Another issue arose though: I get some weird "turn left" instructions in places where you just have to go straight ahead, such as the followings (traveling from West to East along AV-102). r3742 doesn't give turn instructions on that places. http://www.openstreetmap.org/#map=19/40.48509/-5.44977&layers=H http://www.openstreetmap.org/#map=18/40.47347/-5.37196&layers=H http://www.openstreetmap.org/#map=18/40.47393/-5.36321&layers=H El 08/01/17 a las 15:17, Gerd Petermann escribió:
Hi all,
r3743 should fix some of the routing errors reported by Carlos and Andrzej. The old code always rounded down when saving the heading in the compacted format, so that e.g. 0x2f was rounded to 0x20 instead of 0x30. The compacted format saves only the topmost 4 bits.
@Carlos, Andrzej: Please can you verify that this also solves the problem.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von svn commit <svn@mkgmap.org.uk> Gesendet: Sonntag, 8. Januar 2017 15:08:40 An: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Commit r3743: Reduce rounding error when saving initial heading in compacted format
Version mkgmap-r3743 was committed by gerd on Sun, 08 Jan 2017
Reduce rounding error when saving initial heading in compacted format
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3743 _______________________________________________
Hi Carlos, okay, I'll try to reproduce and find a reason for that tomorrow. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <cdavilam@orangecorreo.es> Gesendet: Mittwoch, 11. Januar 2017 18:20:49 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r3743: Reduce rounding error when saving initial heading in compacted format I'm sorry for the late replay. As for Andrzej, it fixed routing problems. Another issue arose though: I get some weird "turn left" instructions in places where you just have to go straight ahead, such as the followings (traveling from West to East along AV-102). r3742 doesn't give turn instructions on that places. http://www.openstreetmap.org/#map=19/40.48509/-5.44977&layers=H http://www.openstreetmap.org/#map=18/40.47347/-5.37196&layers=H http://www.openstreetmap.org/#map=18/40.47393/-5.36321&layers=H El 08/01/17 a las 15:17, Gerd Petermann escribió:
Hi all,
r3743 should fix some of the routing errors reported by Carlos and Andrzej. The old code always rounded down when saving the heading in the compacted format, so that e.g. 0x2f was rounded to 0x20 instead of 0x30. The compacted format saves only the topmost 4 bits.
@Carlos, Andrzej: Please can you verify that this also solves the problem.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von svn commit <svn@mkgmap.org.uk> Gesendet: Sonntag, 8. Januar 2017 15:08:40 An: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Commit r3743: Reduce rounding error when saving initial heading in compacted format
Version mkgmap-r3743 was committed by gerd on Sun, 08 Jan 2017
Reduce rounding error when saving initial heading in compacted format
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3743 _______________________________________________
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi, I have tested last problem with mkgmap r3742M, which should disable compacted format of angles. It works better but not ideally. r3743 gives 3 times "turn left", when actually route leads straight ahead. Patched r3742M gives one "bear left" and one "turn left". I have an older map, which works perfectly for this route. I have checked, that release r3742 is good too. It looks like precise angles aren't calculated or used correctly. -- Best regards, Andrzej
Hi Gerd, please check this patch, I think problem appears because of similar rounding error in AngleChecker. -- Best Regards, Andrzej
Hi Andrzej, thanks, looks good, I've changed it a bit for r3748. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Donnerstag, 12. Januar 2017 02:21:45 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Commit r3743: Reduce rounding error when saving initial heading in compacted format Hi Gerd, please check this patch, I think problem appears because of similar rounding error in AngleChecker. -- Best Regards, Andrzej
participants (4)
-
Andrzej Popowski -
Carlos Dávila -
Gerd Petermann -
svn commit