Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI
Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015 admin_centre-v1.patch: avoid to create duplicate POI It implements the following: When POIGeneratorHook creates a POI for a type=boundary relation with boundary=administrative it searches for a role=admin_centre member in that relation. If one is found, the generated POI will use the coordinates of this member. I see no easy way to compare the tags of the existing node with those of the generated POI, so as a second step, StyledConverter detects when a POI with the same type and name (or empty name) is created at the same Garmin coordinates (after style processing) If that is true, the latter one is ignored and an info message is logged. Maybe for certain types this should be changed to check for a radius rather than equality, but that would require complex configuration.
Hi Gerd, There is something weird happening with this version r3573, maybe a bug or maybe a fault in my styles? The name of London disappears and becomes England, http://www.openstreetmap.org/relation/58447 I see the same for Edinburgh which becomes Scotland. Any idea what went wrong here? How can I get the name of England not at the node of London (=admin_centre) but in the middle of the country / relation? With mkgmap-r3487 it was still ok. See http://mijndev.openstreetmap.nl/~ligfietser/test/ for my styles and the tiles around London.
Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015
admin_centre-v1.patch: avoid to create duplicate POI
It implements the following: When POIGeneratorHook creates a POI for a type=boundary relation with boundary=administrative it searches for a role=admin_centre member in that relation. If one is found, the generated POI will use the coordinates of this member.
I see no easy way to compare the tags of the existing node with those of the generated POI, so as a second step, StyledConverter detects when a POI with the same type and name (or empty name) is created at the same Garmin coordinates (after style processing) If that is true, the latter one is ignored and an info message is logged.
Maybe for certain types this should be changed to check for a radius rather than equality, but that would require complex configuration.
Hi Minko, ahh, yes, I assume that you still get two different POI, one for London, one for England, but they are at the same place. This is probably not what we want? I'll have a look at your data later if that explanation doesn't work out. Gerd
Date: Wed, 13 May 2015 11:35:36 +0200 From: ligfietser@online.nl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI
Hi Gerd,
There is something weird happening with this version r3573, maybe a bug or maybe a fault in my styles? The name of London disappears and becomes England, http://www.openstreetmap.org/relation/58447 I see the same for Edinburgh which becomes Scotland. Any idea what went wrong here? How can I get the name of England not at the node of London (=admin_centre) but in the middle of the country / relation? With mkgmap-r3487 it was still ok.
See http://mijndev.openstreetmap.nl/~ligfietser/test/ for my styles and the tiles around London.
Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015
admin_centre-v1.patch: avoid to create duplicate POI
It implements the following: When POIGeneratorHook creates a POI for a type=boundary relation with boundary=administrative it searches for a role=admin_centre member in that relation. If one is found, the generated POI will use the coordinates of this member.
I see no easy way to compare the tags of the existing node with those of the generated POI, so as a second step, StyledConverter detects when a POI with the same type and name (or empty name) is created at the same Garmin coordinates (after style processing) If that is true, the latter one is ignored and an info message is logged.
Maybe for certain types this should be changed to check for a radius rather than equality, but that would require complex configuration.
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Yep, I see with GPSMapedit those two points at the same place. In Mapsource it seems random at which zoomlevel which placename is shown, either London (which I prefer) or England. I notice the same for Scotland but I guess in many other countries or regions this will be an issue too. Thanks for looking at it. ----- Oorspronkelijk bericht -----
ahh, yes, I assume that you still get two different POI, one for London, one for England, but they are at the same place. This is probably not what we want?
I'll have a look at your data later if that explanation doesn't work out.
Gerd
Hi Minko, I think this is an error caused by the patch. I thought that it is a good idea to place the generated POI at the same place as the admin_centre node, but now I think this is only usefull when the names are equal. If not, we should probable use the center of the polygon again. I have to check if the admin_level is also important. Gerd ligfietser wrote
Yep, I see with GPSMapedit those two points at the same place. In Mapsource it seems random at which zoomlevel which placename is shown, either London (which I prefer) or England. I notice the same for Scotland but I guess in many other countries or regions this will be an issue too. Thanks for looking at it.
----- Oorspronkelijk bericht -----
ahh, yes, I assume that you still get two different POI, one for London, one for England, but they are at the same place. This is probably not what we want?
I'll have a look at your data later if that explanation doesn't work out.
Gerd
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Commit-r3573-admin-centre-v1-patch-avoid-to-c... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd I see you have more case doubling the POI in admin_level 10 when have included place in the relationship. This makes 2 POI _______________________________________________________________________________________________________ Anor C. A. de Souza Concórdia SC
From: svn@mkgmap.org.uk To: mkgmap-svn@lists.mkgmap.org.uk Date: Sun, 10 May 2015 06:30:59 +0100 Subject: [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI
Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015
admin_centre-v1.patch: avoid to create duplicate POI
It implements the following: When POIGeneratorHook creates a POI for a type=boundary relation with boundary=administrative it searches for a role=admin_centre member in that relation. If one is found, the generated POI will use the coordinates of this member.
I see no easy way to compare the tags of the existing node with those of the generated POI, so as a second step, StyledConverter detects when a POI with the same type and name (or empty name) is created at the same Garmin coordinates (after style processing) If that is true, the latter one is ignored and an info message is logged.
Maybe for certain types this should be changed to check for a radius rather than equality, but that would require complex configuration. _______________________________________________ mkgmap-svn mailing list To unsubscribe send an mail to mkgmap-svn-leave@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-svn
Hi Anor, interesting, I've just posted a possible explanation for this. Please check if the boundary below is divided as described here: http://gis.19327.n5.nabble.com/Duplicate-cities-tp5845284.html Gerd From: anorcarlos@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Wed, 20 May 2015 10:38:06 -0300 Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Gerd I see you have more case doubling the POI in admin_level 10 when have included place in the relationship. This makes 2 POI _______________________________________________________________________________________________________ Anor C. A. de Souza Concórdia SC
From: svn@mkgmap.org.uk To: mkgmap-svn@lists.mkgmap.org.uk Date: Sun, 10 May 2015 06:30:59 +0100 Subject: [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI
Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015
admin_centre-v1.patch: avoid to create duplicate POI
It implements the following: When POIGeneratorHook creates a POI for a type=boundary relation with boundary=administrative it searches for a role=admin_centre member in that relation. If one is found, the generated POI will use the coordinates of this member.
I see no easy way to compare the tags of the existing node with those of the generated POI, so as a second step, StyledConverter detects when a POI with the same type and name (or empty name) is created at the same Garmin coordinates (after style processing) If that is true, the latter one is ignored and an info message is logged.
Maybe for certain types this should be changed to check for a radius rather than equality, but that would require complex configuration. _______________________________________________ mkgmap-svn mailing list To unsubscribe send an mail to mkgmap-svn-leave@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-svn
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Anor, no, sorry, you probably wanted to point out that mkgmap should treat this case like a node with admin_centre=*. I see that this is only a proposal: http://wiki.openstreetmap.org/wiki/Relations/Proposed/Label and it seems not widely used. Any comments from others? Gerd From: gpetermann_muenchen@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Wed, 20 May 2015 15:44:29 +0200 Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Anor, interesting, I've just posted a possible explanation for this. Please check if the boundary below is divided as described here: http://gis.19327.n5.nabble.com/Duplicate-cities-tp5845284.html Gerd From: anorcarlos@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Wed, 20 May 2015 10:38:06 -0300 Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Gerd I see you have more case doubling the POI in admin_level 10 when have included place in the relationship. This makes 2 POI _______________________________________________________________________________________________________ Anor C. A. de Souza Concórdia SC
From: svn@mkgmap.org.uk To: mkgmap-svn@lists.mkgmap.org.uk Date: Sun, 10 May 2015 06:30:59 +0100 Subject: [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI
Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015
admin_centre-v1.patch: avoid to create duplicate POI
It implements the following: When POIGeneratorHook creates a POI for a type=boundary relation with boundary=administrative it searches for a role=admin_centre member in that relation. If one is found, the generated POI will use the coordinates of this member.
I see no easy way to compare the tags of the existing node with those of the generated POI, so as a second step, StyledConverter detects when a POI with the same type and name (or empty name) is created at the same Garmin coordinates (after style processing) If that is true, the latter one is ignored and an info message is logged.
Maybe for certain types this should be changed to check for a radius rather than equality, but that would require complex configuration. _______________________________________________ mkgmap-svn mailing list To unsubscribe send an mail to mkgmap-svn-leave@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-svn
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi gerd In this case there is no admin because it is inside the admin 8. Ali this case not to duplicate the POI only excluded the key place _______________________________________________________________________________________________________ Anor C. A. de Souza Concórdia SC From: gpetermann_muenchen@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Wed, 20 May 2015 15:53:50 +0200 Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Anor, no, sorry, you probably wanted to point out that mkgmap should treat this case like a node with admin_centre=*. I see that this is only a proposal: http://wiki.openstreetmap.org/wiki/Relations/Proposed/Label and it seems not widely used. Any comments from others? Gerd From: gpetermann_muenchen@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Wed, 20 May 2015 15:44:29 +0200 Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Anor, interesting, I've just posted a possible explanation for this. Please check if the boundary below is divided as described here: http://gis.19327.n5.nabble.com/Duplicate-cities-tp5845284.html Gerd From: anorcarlos@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Wed, 20 May 2015 10:38:06 -0300 Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Gerd I see you have more case doubling the POI in admin_level 10 when have included place in the relationship. This makes 2 POI _______________________________________________________________________________________________________ Anor C. A. de Souza Concórdia SC
From: svn@mkgmap.org.uk To: mkgmap-svn@lists.mkgmap.org.uk Date: Sun, 10 May 2015 06:30:59 +0100 Subject: [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI
Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015
admin_centre-v1.patch: avoid to create duplicate POI
It implements the following: When POIGeneratorHook creates a POI for a type=boundary relation with boundary=administrative it searches for a role=admin_centre member in that relation. If one is found, the generated POI will use the coordinates of this member.
I see no easy way to compare the tags of the existing node with those of the generated POI, so as a second step, StyledConverter detects when a POI with the same type and name (or empty name) is created at the same Garmin coordinates (after style processing) If that is true, the latter one is ignored and an info message is logged.
Maybe for certain types this should be changed to check for a radius rather than equality, but that would require complex configuration. _______________________________________________ mkgmap-svn mailing list To unsubscribe send an mail to mkgmap-svn-leave@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-svn
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, the problem occurs when there is the administrative boundary relation admin_level = 10. At least in Brazil there is no admin_centre to admin_level 10. When included in relation to tag place the add-poi-to-area create a POI at the center, which I believe would be desired, however, in many relations of this type, this addition doubles the POI when this already exists in the area. I'm not a programmer, but I imagine a rule that when in a boundary relation admin_level = 10, do not create a POI in the center where there is a POI with the same name in the area. Marcio From: Gerd Petermann Sent: Wednesday, May 20, 2015 10:53 AM To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Anor, no, sorry, you probably wanted to point out that mkgmap should treat this case like a node with admin_centre=*. I see that this is only a proposal: http://wiki.openstreetmap.org/wiki/Relations/Proposed/Label and it seems not widely used. Any comments from others? Gerd -------------------------------------------------------------------------------- From: gpetermann_muenchen@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Wed, 20 May 2015 15:44:29 +0200 Subject: Re: [mkgmap-dev] [mkgmap-svn] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI Hi Anor, interesting, I've just posted a possible explanation for this. Please check if the boundary below is divided as described here: http://gis.19327.n5.nabble.com/Duplicate-cities-tp5845284.html Gerd
participants (6)
-
A. Carlos -
Gerd Petermann -
GerdP
-
Minko -
svn commit -
thundercel＠gpsinfo.com.br