POI indexing, problem with label 0x2800
Hi, POI types 0x28xx are usually treated as labels, there is no icon for these POIs, only label text. CGPSMapper doc describe these POI as "Region name". I'd like to use these POI for house numbers. Problem is, that mkgmap indexes labels! It results in big increment of img files and index file. I doubt these objects are searchable, probably all this indexing is only a waste of space. I have found code in MdrUtils.java, which adds labels to index. I think this can be removed. And maybe you can add POIs in range 0x64xx - 0x66xx, they probably are searchable. There is an increase in LBL subfile, I haven't found code responsible for this. There seems to be a section LBL5 called "POI index", maybe labels goes there too? -- Best regards, Andrzej
I dont like the idea to remove pois 0x28xx from the index, I use them for many items which are searchable! Better make an custom option where you can switch indexing on/off. ________________________________ From: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> on behalf of Andrzej Popowski <popej@poczta.onet.pl> Sent: Thursday, January 19, 2017 6:05:47 PM To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi, POI types 0x28xx are usually treated as labels, there is no icon for these POIs, only label text. CGPSMapper doc describe these POI as "Region name". I'd like to use these POI for house numbers. Problem is, that mkgmap indexes labels! It results in big increment of img files and index file. I doubt these objects are searchable, probably all this indexing is only a waste of space. I have found code in MdrUtils.java, which adds labels to index. I think this can be removed. And maybe you can add POIs in range 0x64xx - 0x66xx, they probably are searchable. There is an increase in LBL subfile, I haven't found code responsible for this. There seems to be a section LBL5 called "POI index", maybe labels goes there too? -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi, on which GPS can you search for labels? My nuvis and Dakota don't find labels. Mapsource and BaseCamp seems to support lables, when you look for "all POIs", but that's rather limited use for this feature. I'm designing map for cars. My goal is to create small map without TYP file. Lables 0x28xx seems to be the only object, which uses small text, which seems perfect for house numbers. I'd like to use it but I can't accept 15-20% increase of map size because of search, which doesn't work on target device. Option for label search would be OK, but somehow I think, that default value should be "no search". Side note: I think devices support wider range of types for search. Not only types 0x64xx-0x66xx are searchable but also many types over 0x100xx. With more types to choose, you can drop labels and use something else instead. -- Best regards, Andrzej
Hi Andrzej, Sorry, maybe you were right. I see now that I also use the continue statement to make those pois searchable. I forgot why I have made two rules for some pois, maybe it is because of this issue that garmin couldnt find those 0x28xx that I have added another line in the past? I dont like to change my typ files because some users have their own customized typ file for my maps. Andrzej wrote Hi, on which GPS can you search for labels?
Hi, I'm attaching a patch to remove indexes for labels 0x28xx from MDR file. I don't think any GPS supports these indexes. -- Best regards, Andrzej
Hi Andrzej, thanks for the patch. I asked Steve to have a look at this but he seems to have no time. My knowledge about index structures is nearly zero, so I have no idea how to verify the effect of the patch. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Mittwoch, 1. Februar 2017 22:51:29 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi, I'm attaching a patch to remove indexes for labels 0x28xx from MDR file. I don't think any GPS supports these indexes. -- Best regards, Andrzej
how did you wish me to run a test on poi , as i have a 3rd party program that uses splitter and mkgmap stephen On Thu, Feb 2, 2017 at 6:09 PM, Gerd Petermann < GPetermann_muenchen@hotmail.com> wrote:
Hi Andrzej,
thanks for the patch. I asked Steve to have a look at this but he seems to have no time. My knowledge about index structures is nearly zero, so I have no idea how to verify the effect of the patch.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Mittwoch, 1. Februar 2017 22:51:29 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800
Hi,
I'm attaching a patch to remove indexes for labels 0x28xx from MDR file. I don't think any GPS supports these indexes.
-- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Sorry, I meant Steve Ratcliffe, not you. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Sgalowski <steve.sgalowski@gmail.com> Gesendet: Donnerstag, 2. Februar 2017 09:20:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 how did you wish me to run a test on poi , as i have a 3rd party program that uses splitter and mkgmap stephen On Thu, Feb 2, 2017 at 6:09 PM, Gerd Petermann <GPetermann_muenchen@hotmail.com<mailto:GPetermann_muenchen@hotmail.com>> wrote: Hi Andrzej, thanks for the patch. I asked Steve to have a look at this but he seems to have no time. My knowledge about index structures is nearly zero, so I have no idea how to verify the effect of the patch. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl<mailto:popej@poczta.onet.pl>> Gesendet: Mittwoch, 1. Februar 2017 22:51:29 An: mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi, I'm attaching a patch to remove indexes for labels 0x28xx from MDR file. I don't think any GPS supports these indexes. -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, the expected outcome of this patch is no change in img but some data omitted in MDR index. This should be: - for Mdr4 POI type 0x28 is omitted - for Mdr10 and Mdr11 indexes for POI type 0x28xx are omitted, - for Mdr15 labels for POI type 0x28xx are omitted. Patch looks like a simple change, hope it works as expected. I have more questions or suggestions, which are more difficult for me to implement in code. There is mkgmap option --make-poi-index with comment in help: "Generate the POI index (not yet useful)". Actually it is used in file MapBuilder.jave. It enables some kind of POI index in LBL subfile. My question is, if index in LBL should correspond to index in MDR. Currently MDR contains a selection of POI types, while LBL gets all. I'm interested in removing indexing of POIs 0x28xx from LBL too. Next question is about this selection of POI types in MDR. My patch removes type 0x28xx from selection but I think there are other types that can be added. For example POIs 0x64xx-0x66xx. Last question is about NT POI types, with code greater than 0x10000. I can't find any indexing for them. I think functions (default meaning of POI object) of these POIs are similar to standard POIs, probably there should be some indexing but maybe in different structures of MDR and img? -- Best regards, Andrzej
Hi
I'm attaching a patch to remove indexes for labels 0x28xx from MDR file. I don't think any GPS supports these indexes.
Well I don't mind applying the patch as no one seems to have objections. However there must be maps that have that group in, as I've explicitly added it separate from the others. ..Steve
Hi Steve, I have tested cgpsmapper, it writes into Mdr4 following POIs: 0x0100 - 0x0F00, subtype always 0 0x2Axx - 0x30xx, where subtype xx is 0 - 0x1F 0x64xx - 0x67xx, where subtype xx is 0 - 0x3F Range of subtypes is what I actually have put into test map, I don't know if greater values would be supported. POIs 0x67xx are a surprise, I don't know if they have any real use. City Navigator Europe has only one POI type at Mdr4, and it is 0x2800, so maybe this is the reason for mkgmap code. CN EU supports search for POI, so I guess real index should be somewhere else in MDR. I don't have many non-NT original Garmin maps to look at. For example Adria Topo Light include POI types like 2A, 2C, 2F, 64, 65, 66. -- Best regards, Andrzej
Hi Andrzej, I think I now understand the code in MdrUtils and in Mdr4 and Mdr10 much better. My understanding is that Mdr4 contains the POI which are indexed, it probably also tells the Garmin software what categories and sub categories to show in the search menu, at least MapSource seems to use it like that. I also saw maps with an empty MDR4, so maybe newer maps don't use that. I think the content of MDR9 and MDR10 are more important reg. search. I've added option poi-excl-index in r3922 in the branch. I've also tried to add type 0x64xx-0x67xx but that doesn't seem to work yet, so I've disabled that code for now. I've also changed the code so that the new mdr7 options are used for gmapsupp, too. It was not intended that they were only used for the PC index. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Freitag, 3. Februar 2017 20:11:44 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi Steve, I have tested cgpsmapper, it writes into Mdr4 following POIs: 0x0100 - 0x0F00, subtype always 0 0x2Axx - 0x30xx, where subtype xx is 0 - 0x1F 0x64xx - 0x67xx, where subtype xx is 0 - 0x3F Range of subtypes is what I actually have put into test map, I don't know if greater values would be supported. POIs 0x67xx are a surprise, I don't know if they have any real use. City Navigator Europe has only one POI type at Mdr4, and it is 0x2800, so maybe this is the reason for mkgmap code. CN EU supports search for POI, so I guess real index should be somewhere else in MDR. I don't have many non-NT original Garmin maps to look at. For example Adria Topo Light include POI types like 2A, 2C, 2F, 64, 65, 66. -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Andrzej, not yet, but will do so. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Samstag, 29. April 2017 19:27:18 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi Gerd,
I've added option poi-excl-index in r3922 in the branch.
Thanks Gerd, this is useful for me. Have you looked at code for creating LBL? I think there is a structure there for POI index, maybe it should cooperate with data in mdr? -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Andrzej, you wrote that you noticed an increase in the LBL file. I think you use option --make-poi-index, but the help says --make-poi-index Generate the POI index (not yet useful). I've never used this option because of this description, so maybe I should add this to my test cases.... The svn log for this option (r1170) says : "Add --make-poi-index option to enable POI index generation. The POI index, which used to be generated by default, doesn't actually appear to be useful at this time. So now it's only generated if you give this option." Unfortunately it doesn't say what the expected effect of the index is. The code for this was added with r984 : "Add support for exits (motorway junctions & services). One major annoyance is that when finding exits, the GPS prefers to find the exits on the basemap rather than the OSM map. Don't know at this time how to fix that. Also included in this commit is support for building the POI Index. I originally thought this was needed for the exits but I don't think it is now but it may still be useful so I am leaving it in." I'll try to find out more. Maybe you can try without the option --make-poi-index and see if that changes anything besides img file size? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Samstag, 29. April 2017 19:38:50 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi Andrzej, not yet, but will do so. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Samstag, 29. April 2017 19:27:18 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi Gerd,
I've added option poi-excl-index in r3922 in the branch.
Thanks Gerd, this is useful for me. Have you looked at code for creating LBL? I think there is a structure there for POI index, maybe it should cooperate with data in mdr? -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi all, I've changed mkgmap to put only POI types 0x29xx .. 0x30.. into the index in LBL. I've also changed the code so that the POI types 0x64xx..0x66xx are written to the global index as group 11 .. 13. Besides that I've learned that the mdr in Garmin maps also indexes some polygons, e.g. type 0x17 (parks) appears in group 64 and some water polygons in 65 and so called man_made things in 66. My understanding so far is that groups 11..13 and 64..66 appear in search dialog "Geographic Places". Maybe this means that we don't have to add some POI for those polygons. I have to experiment with this. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Sonntag, 30. April 2017 11:13:28 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi Andrzej, you wrote that you noticed an increase in the LBL file. I think you use option --make-poi-index, but the help says --make-poi-index Generate the POI index (not yet useful). I've never used this option because of this description, so maybe I should add this to my test cases.... The svn log for this option (r1170) says : "Add --make-poi-index option to enable POI index generation. The POI index, which used to be generated by default, doesn't actually appear to be useful at this time. So now it's only generated if you give this option." Unfortunately it doesn't say what the expected effect of the index is. The code for this was added with r984 : "Add support for exits (motorway junctions & services). One major annoyance is that when finding exits, the GPS prefers to find the exits on the basemap rather than the OSM map. Don't know at this time how to fix that. Also included in this commit is support for building the POI Index. I originally thought this was needed for the exits but I don't think it is now but it may still be useful so I am leaving it in." I'll try to find out more. Maybe you can try without the option --make-poi-index and see if that changes anything besides img file size? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Samstag, 29. April 2017 19:38:50 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi Andrzej, not yet, but will do so. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej@poczta.onet.pl> Gesendet: Samstag, 29. April 2017 19:27:18 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] POI indexing, problem with label 0x2800 Hi Gerd,
I've added option poi-excl-index in r3922 in the branch.
Thanks Gerd, this is useful for me. Have you looked at code for creating LBL? I think there is a structure there for POI index, maybe it should cooperate with data in mdr? -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (5)
-
Andrzej Popowski -
Gerd Petermann -
lig fietser -
Steve Ratcliffe -
Steve Sgalowski