Commit: r2567: roads_first_v1.patch: Make sure that roads are placed before other lines

Version 2567 was committed by gerd on Thu, 11 Apr 2013 roads_first_v1.patch: Make sure that roads are placed before other lines in each sub division.

Hi Gerd, I have noticed that this roads_ first_patch has a negative impact on my maps, bridges are now rendered above the road lines. See https://dl.dropboxusercontent.com/u/64716698/OSM/mkgmap/bridge.jpg Left the mkgmap version before 2567, right pic after the commit. I use a non transparent image for the bridge because I dont want to see water between the bridge outlines and the road surface that lies on top of the bridge. My bridge is defined in the style file before all highways: (bridge=yes | bridge=true | bridge=viaduct) [0x2b resolution 23 continue with_actions] Whats the benefit of this patch?
Commit: r2567: roads_first_v1.patch: Make sure that roads are placed before other lines Version 2567 was committed by gerd on Thu, 11 Apr 2013

Hi Minko, it was meant to fix routing problems, but I think it is no longer needed as we found out that the problems are not solved with the change of the order as long as non-routable ways have routable types. I can revert that change, but I am not sure if this will solve the problem. If I got you right mkgmap should write the ways in the order that the style implies, but the latest changes treat roads different so that they are either added after all other lines or before. I'll try to change that back. Gerd
Date: Mon, 6 May 2013 10:12:43 +0200 From: ligfietser@online.nl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Commit: r2567: roads_first_v1.patch: Make sure that roads are placed before other lines
Hi Gerd,
I have noticed that this roads_ first_patch has a negative impact on my maps, bridges are now rendered above the road lines. See https://dl.dropboxusercontent.com/u/64716698/OSM/mkgmap/bridge.jpg Left the mkgmap version before 2567, right pic after the commit.
I use a non transparent image for the bridge because I dont want to see water between the bridge outlines and the road surface that lies on top of the bridge.
My bridge is defined in the style file before all highways: (bridge=yes | bridge=true | bridge=viaduct) [0x2b resolution 23 continue with_actions]
Whats the benefit of this patch?
Commit: r2567: roads_first_v1.patch: Make sure that roads are placed before other lines Version 2567 was committed by gerd on Thu, 11 Apr 2013
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Thanks Gerd, I'll see what happens after you've reverted that patch.

Hi Gerd, Are the changes in the latest mkgmap versions also implemented in the mkgmap-overview2 branch? If I look at the latest mkgmap-overview2-r2587.jar there is still the old cc-by-sa license used (fixed in mkgmap-r2570) It is also not clear to me what is already in the trunk version, can I use --x-overview-cfg with the latest mkgmap?

Hi Minko, I've just committed r2590 which is the first version that implements the multi-level overview map as discussed with Felix. The support for overview-cfg was removed, you have to add levels to the option file of the style (I did not yet test if that can be overwritten on the command line) Sample: levels = 0:24, 1:22, 2:20, 3:18 overview-levels = 4:16, 5:14 This version creates one additional file *_ovm.img for each *.img, these may be removed later. I think the license stuff should be equal to trunk, if not, please let me know. Gerd
Date: Mon, 6 May 2013 12:21:58 +0200 From: ligfietser@online.nl To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] mkgmap-overview branch
Hi Gerd,
Are the changes in the latest mkgmap versions also implemented in the mkgmap-overview2 branch? If I look at the latest mkgmap-overview2-r2587.jar there is still the old cc-by-sa license used (fixed in mkgmap-r2570) It is also not clear to me what is already in the trunk version, can I use --x-overview-cfg with the latest mkgmap? _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Thanks Gerd, Just did a small test, license is ok and the bridges are rendered fine now too :-) I think it is better that the *_ovm.img are removed after the complilation is done, if they are not used by Mapsource/Basecamp. Havent played with the overview levels yet, looks ok as far as I can see now.

Am 06.05.2013 10:12, schrieb Minko:
My bridge is defined in the style file before all highways: (bridge=yes | bridge=true | bridge=viaduct) [0x2b resolution 23 continue with_actions]
Better use ( bridge=* & bridge!=no ) Henning

Thanks Henning, I see the number of values for bridge=* have increased: http://taginfo.openstreetmap.org/keys/?key=bridge#values
My bridge is defined in the style file before all highways: (bridge=yes | bridge=true | bridge=viaduct) [0x2b resolution 23 continue with_actions]
Better use ( bridge=* & bridge!=no )
Henning

Maybe bridge!=abandoned would also be useful. Am 06.05.2013 11:40, schrieb Minko:
PS I also added bridge!=proposed because I dont want to render bridges that exists only on paper on the map ;-)
Better use ( bridge=* & bridge!=no )
Henning
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (4)
-
Gerd Petermann
-
Henning Scholland
-
Minko
-
svn commit