Re: [mkgmap-dev] [PATCH v1] - extend --replace-short-arcs option to take min arc length
Hi Mark, I've experienced the same problem: a short arc disappered in Rome (I'm still looking for it...). And the routing gets broken. Did you understand why those short arcs (with no collapsing end nodes) get deleted? Ciao, Marco. --- Gio 4/6/09, Mark Burton <markb@ordern.com> ha scritto:
Da: Mark Burton <markb@ordern.com> Oggetto: Re: [mkgmap-dev] [PATCH v1] - extend --replace-short-arcs option to take min arc length A: mkgmap-dev@lists.mkgmap.org.uk Data: Giovedì 4 giugno 2009, 19:57
Hi Felix,
Shame on me, I had in my batch the call for the unpatched mkgmap version, which of course did not.
OK.
What can I say about the patch? Get it into TRUNK!!!!
I will commit it soon as it won't affect the default operation.
Finally Routing over longer distances IS possible. Route calculation time decreased in mapsource by up to 50%, and possible route length increased about 20-25%. Also no single Mapsource Crash since!!!!!!!!!!!!!
Good.
At least in Austria where because of the import, many roads are not connected, this patch is absolutely essential!
The patch only merges nodes that are close and already connected. It doesn't merge nodes that are close and not connected.
On my Vista HCx also many destinations that previously took 2-3 minutes to calculate just calculated only 20-30 seconds!
Great.
Maybe don't enable it by default, I have not really tested whether now there are any problems with roads connected that should not be connected, but so far it has been working great!
I will commit something that has the same effect as the patch you have tried.
Cheers,
Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Marco,
I've experienced the same problem: a short arc disappered in Rome (I'm still looking for it...). And the routing gets broken. Did you understand why those short arcs (with no collapsing end nodes) get deleted?
Sorry, no I don't. When you discover where it is, please let me know so I can take a look at it. Cheers, Mark
Hi Marco,
I've experienced the same problem: a short arc disappered in Rome (I'm still looking for it...). And the routing gets broken. Did you understand why those short arcs (with no collapsing end nodes) get deleted?
Bug found, fix committed. The min arc length can still be specified with --remove-short-arcs (note correct name!) but it shouldn't be needed any more. Zero length arcs must still be removed so you do need to specify --remove-short-arcs (but without the min length). Once this has proven to be trustworthy, we could think about making the zero length arc removal the default behaviour when routing is enabled. Cheers, Mark
What about deleting the following lines, what is the reason? "ferry".equals(currentWay.getTag("route")))) { AND long cyclwayId = currentWay.getId() + CYCLWAY_ID_OFFSET; Will enabling the --make-opposite-cycleways now overwrite the underlying road? Mark Burton wrote:
Hi Marco,
I've experienced the same problem: a short arc disappered in Rome (I'm still looking for it...). And the routing gets broken. Did you understand why those short arcs (with no collapsing end nodes) get deleted?
Bug found, fix committed.
The min arc length can still be specified with --remove-short-arcs (note correct name!) but it shouldn't be needed any more.
Zero length arcs must still be removed so you do need to specify --remove-short-arcs (but without the min length). Once this has proven to be trustworthy, we could think about making the zero length arc removal the default behaviour when routing is enabled.
Cheers,
Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Felix,
What about deleting the following lines, what is the reason?
"ferry".equals(currentWay.getTag("route")))) {
That's there to allow routing by ferry.
long cyclwayId = currentWay.getId() + CYCLWAY_ID_OFFSET;
That's there to give the synthesised cycleway a unique id.
Will enabling the --make-opposite-cycleways now overwrite the underlying road?
If you want to have a routable map for bicycles why not just remove all the oneway tags? Cheers, Mark
2009/6/6 Mark Burton <markb@ordern.com>:
If you want to have a routable map for bicycles why not just remove all the oneway tags?
Because cyclists are required to obey oneway restrictions. Dermot -- -------------------------------------- Iren sind menschlich
Hi Dermot,
If you want to have a routable map for bicycles why not just remove all the oneway tags?
Because cyclists are required to obey oneway restrictions.
Silly me, I was forgetting that. So how about zap the oneway tags for roads that have the opposite cycleway tags? Cheers, Mark
Sorry, just wanted to say that I had misinterpreted tortoiseSVN diff files. I though those lines were deleted, but it only showed differences to my version. I just wondered why (which was falsely assumed by me) the lines were deleted. I do change the maps by using the following command in my style-file: ( oneway=yes | oneway=1 | oneway=-1 | oneway=true | oneway=reverse | oneway=false ) & ( cycleway=opposite | cycleway=opposite_lane | cyclway=opposite_track) {set oneway=no} Mark Burton wrote:
Hi Dermot,
If you want to have a routable map for bicycles why not just remove all the oneway tags?
Because cyclists are required to obey oneway restrictions.
Silly me, I was forgetting that. So how about zap the oneway tags for roads that have the opposite cycleway tags?
Cheers,
Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Felix,
Sorry, just wanted to say that I had misinterpreted tortoiseSVN diff files. I though those lines were deleted, but it only showed differences to my version. I just wondered why (which was falsely assumed by me) the lines were deleted.
OK, I was thinking that you were asking about why not delete those lines! Sorry, my head is elsewhere this afternoon and I didn't interpret your question right.
I do change the maps by using the following command in my style-file:
( oneway=yes | oneway=1 | oneway=-1 | oneway=true | oneway=reverse | oneway=false ) & ( cycleway=opposite | cycleway=opposite_lane | cyclway=opposite_track) {set oneway=no}
OK. Cheers, Mark
participants (4)
-
Dermot McNally -
Felix Hartmann -
Marco Certelli -
Mark Burton