[Patch v1] simplify address rules
Hi all, attached is a patch that removes all rules which I think are superfluous. I've also attached the modified inc/address file. My understanding is that country specific rules should only be used when the general rules don't work. It makes no sense to have a specific rule mkgmap:country=BEL & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8}' } when the next possible match is the general rule mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8}' } Or is this meant as some kind of documentation (meaning we have verified these rules for Belgium) ? Gerd
Hi Gerd, I think admin_level9 must be placed before admin_level9 for Belgium: mkgmap:country=BEL & mkgmap:city!=* & mkgmap:admin_level9=* { set mkgmap:city='${mkgmap:admin_level9}' }
It makes no sense to have a specific rule mkgmap:country=BEL & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8}' } when the next possible match is the general rule mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8}' }
Or is this meant as some kind of documentation (meaning we have verified these rules for Belgium) ?
Gerd
Hi Minko, okay, I'll check that. Gerd Date: Sat, 6 Jun 2015 15:13:34 +0200 From: ligfietser@online.nl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] simplify address rules Correction: admin_level9 must be placed before admin_level8 Hi Gerd, I think admin_level9 must be placed before admin_level9 for Belgium: mkgmap:country=BEL & mkgmap:city!=* & mkgmap:admin_level9=* { set mkgmap:city='${mkgmap:admin_level9}' } _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Minko, I analysed your proposal with some tiles. It seems that your version is better, but I still see many objects where addr:city is set to a different value than mkgmap:city. Your proposal reduces this number by 25%. Maybe we should prefer to use addr:city in Belgium? In France most of these differences where caused by different spellings, in Belgium it seems that boundaries are missing. Gerd Date: Sat, 6 Jun 2015 15:13:34 +0200 From: ligfietser@online.nl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] simplify address rules Correction: admin_level9 must be placed before admin_level8 Hi Gerd, I think admin_level9 must be placed before admin_level9 for Belgium: mkgmap:country=BEL & mkgmap:city!=* & mkgmap:admin_level9=* { set mkgmap:city='${mkgmap:admin_level9}' } _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
I'm not very familiar with the Belgium situation Gerd. I only added admin_level9 because some users reported their village wasn't searchable and this solved the issue. It could be that boundaries are still incomplete. Please note that the Flandres OSM community is importing address data: http://wiki.openstreetmap.org/wiki/WikiProject_Belgium/Using_AGIV_Crab_data/...
Hi Minko,
I analysed your proposal with some tiles. It seems that your version is better, but I still see many objects where addr:city is set to a different value than mkgmap:city. Your proposal reduces this number by 25%.
Maybe we should prefer to use addr:city in Belgium? In France most of these differences where caused by different spellings, in Belgium it seems that boundaries are missing.
Gerd
participants (2)
-
Gerd Petermann -
Minko