r2829 in the high-prec-coord branch
Hi all, I've coded a replacement for the removeShortArcsByMergingNodes() method, called removeWrongAngles(). It also replaces the code to beautify roundabouts. Function: 1) remove zero length arcs and 2) remove wrong angles caused by rounding to map units (both only in roads and the overlaying lines). Up to now, the method accepts errors in angles of up to 30°, maybe this is going to change. The problem with the wrong angles occurs very often in roundabouts, but also in other places (causing zig-zagging) It still removes extremely short ways (when all points are rounded to the same point in map units) Please let me know what you think about it. Gerd -- View this message in context: http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Just a thought... could this also explain why I sometimes get told to "keep left" at an exit on a straight motorway, which is a redundant way of saying "do not take the exit"? I haven't been able to discover any logic related to the tagging or the geometry in the OSM data. Colin On 2013-11-18 22:43, GerdP wrote:
Hi all,
I've coded a replacement for the removeShortArcsByMergingNodes() method, called removeWrongAngles(). It also replaces the code to beautify roundabouts. Function: 1) remove zero length arcs and 2) remove wrong angles caused by rounding to map units (both only in roads and the overlaying lines). Up to now, the method accepts errors in angles of up to 30°, maybe this is going to change.
The problem with the wrong angles occurs very often in roundabouts, but also in other places (causing zig-zagging) It still removes extremely short ways (when all points are rounded to the same point in map units)
Please let me know what you think about it.
Gerd
-- View this message in context: http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... [1] Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2]
Links: ------ [1] http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... [2] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Colin, yes, possible. Do you see these problems with the trunk version or with the high-prec-coord branch? Do you use adjust-turn-headings? I have to find out if that is still needed in the branch, and if yes, if it still works as expected. Gerd Date: Mon, 18 Nov 2013 23:13:42 +0100 From: colin.smale@xs4all.nl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] r2829 in the high-prec-coord branch Just a thought... could this also explain why I sometimes get told to "keep left" at an exit on a straight motorway, which is a redundant way of saying "do not take the exit"? I haven't been able to discover any logic related to the tagging or the geometry in the OSM data. Colin On 2013-11-18 22:43, GerdP wrote: Hi all, I've coded a replacement for the removeShortArcsByMergingNodes() method, called removeWrongAngles(). It also replaces the code to beautify roundabouts. Function: 1) remove zero length arcs and 2) remove wrong angles caused by rounding to map units (both only in roads and the overlaying lines). Up to now, the method accepts errors in angles of up to 30°, maybe this is going to change. The problem with the wrong angles occurs very often in roundabouts, but also in other places (causing zig-zagging) It still removes extremely short ways (when all points are rounded to the same point in map units) Please let me know what you think about it. Gerd -- View this message in context: http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I have been noticing this for a long time. I am not using adjust-turn-headings. I tried it some time ago and decided at that time that it was not an improvement. I haven't tried high-prec-coord yet although it is sounding like it might be pretty stable now so I might give it a go! Colin On 2013-11-18 23:20, Gerd Petermann wrote:
Hi Colin,
yes, possible. Do you see these problems with the trunk version or with the high-prec-coord branch? Do you use adjust-turn-headings? I have to find out if that is still needed in the branch, and if yes, if it still works as expected.
Gerd
------------------------- Date: Mon, 18 Nov 2013 23:13:42 +0100 From: colin.smale@xs4all.nl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] r2829 in the high-prec-coord branch
Just a thought... could this also explain why I sometimes get told to "keep left" at an exit on a straight motorway, which is a redundant way of saying "do not take the exit"? I haven't been able to discover any logic related to the tagging or the geometry in the OSM data. Colin
On 2013-11-18 22:43, GerdP wrote:
Hi all,
I've coded a replacement for the removeShortArcsByMergingNodes() method, called removeWrongAngles(). It also replaces the code to beautify roundabouts. Function: 1) remove zero length arcs and 2) remove wrong angles caused by rounding to map units (both only in roads and the overlaying lines). Up to now, the method accepts errors in angles of up to 30°, maybe this is going to change.
The problem with the wrong angles occurs very often in roundabouts, but also in other places (causing zig-zagging) It still removes extremely short ways (when all points are rounded to the same point in map units)
Please let me know what you think about it.
Gerd
-- View this message in context: http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... [1] Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2]
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2]
Links: ------ [1] http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... [2] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Colin, well, the branch is not stable as I am trying to find new solutions for old problems using the additional info that the higher precision offers . I am pretty sure that this introduces new - but hopefully smaller - problems. The change in r2829 was a first working version of the new algo, I've just committed r2830... Gerd Colin Smale wrote
Hi Gerd,
I have been noticing this for a long time. I am not using adjust-turn-headings. I tried it some time ago and decided at that time that it was not an improvement. I haven't tried high-prec-coord yet although it is sounding like it might be pretty stable now so I might give it a go!
Colin
On 2013-11-18 23:20, Gerd Petermann wrote:
Hi Colin,
yes, possible. Do you see these problems with the trunk version or with the high-prec-coord branch? Do you use adjust-turn-headings? I have to find out if that is still needed in the branch, and if yes, if it still works as expected.
Gerd
------------------------- Date: Mon, 18 Nov 2013 23:13:42 +0100 From:
colin.smale@
To:
mkgmap-dev@.org
Subject: Re: [mkgmap-dev] r2829 in the high-prec-coord branch
Just a thought... could this also explain why I sometimes get told to "keep left" at an exit on a straight motorway, which is a redundant way of saying "do not take the exit"? I haven't been able to discover any logic related to the tagging or the geometry in the OSM data. Colin
On 2013-11-18 22:43, GerdP wrote:
Hi all,
I've coded a replacement for the removeShortArcsByMergingNodes() method, called removeWrongAngles(). It also replaces the code to beautify roundabouts. Function: 1) remove zero length arcs and 2) remove wrong angles caused by rounding to map units (both only in roads and the overlaying lines). Up to now, the method accepts errors in angles of up to 30°, maybe this is going to change.
The problem with the wrong angles occurs very often in roundabouts, but also in other places (causing zig-zagging) It still removes extremely short ways (when all points are rounded to the same point in map units)
Please let me know what you think about it.
Gerd
-- View this message in context: http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... [1] Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
Links: ------ [1] http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... [2] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Chris, yes, I read your older post regarding this, but I was not able to reproduce the problem. If you can reproduce it with the branch version, please report more details. Gerd Chris66 wrote
Am 18.11.2013 23:58, schrieb Colin Smale:
I am not using adjust-turn-headings. I tried it some time ago and decided at that time that it was not an improvement.
It even can produce routing errors. Don't know if this has been fixed in newer versions of mkgmap.
Chris
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/r2829-in-the-high-prec-coord-branch-tp5786060... Sent from the Mkgmap Development mailing list archive at Nabble.com.
participants (4)
-
chris66 -
Colin Smale -
Gerd Petermann -
GerdP