[PATCH v2] - min arc length fixes
v2 of this patch not only enables remove-short-arcs by default when routing is in use (as previously discussed on ML) but it also fixes some problems in the way splitting code. I would be grateful if people could test this patch because it could possibly cure some routing failures. Cheers, Mark
Hi Mark, Mark Burton schreef:
v2 of this patch not only enables remove-short-arcs by default when routing is in use (as previously discussed on ML) but it also fixes some problems in the way splitting code.
I would be grateful if people could test this patch because it could possibly cure some routing failures.
Fast check with the 29-07-09 14:32 "a routing problem" problem, with r1127 the problem is still there. Updated to revision 1131, used your patch which (unfortunately) doesn't solve the problem *and* now there's loads (well, 28 entries) of SEVERE (RoadNetwork): Road Kasteeltuin (OSM id 7003822) contains a bad arc of length 2,94m SEVERE (RoadNetwork): http://www.openstreetmap.org/?lat=52.02526&lon=5.18550&zoom=17 SEVERE (RoadNetwork): Road E 30 (OSM id 7004900) contains a bad arc of length 2,94m SEVERE (RoadNetwork): http://www.openstreetmap.org/?lat=52.09266&lon=5.18550&zoom=17 A couple of these are on the edge of a map, but this one for example does not: Road Franciscusdreef (OSM id 7066146) contains a bad arc of length 2,39m http://www.openstreetmap.org/?lat=52.11912&lon=5.08551&zoom=17 I did not check other routes. Please remember that the strange a,b,c routing problem showed up in Mapsource but did not in my Garmin. I didn't check my Garmin Nuvi here. Oh, and I don't know (so I can't test) any other routing problems now but I wouldn't call that a problem :-) :-) List follows below. Best regards, Valentijn Here is the list, abbreviated so it fits in a mail: Kasteeltuin (OSM id 7003822) bad arc of length 2,94m http://www.openstreetmap.org/?lat=52.02526&lon=5.18550&zoom=17 E 30 (OSM id 7004900) bad arc of length 2,94m http://www.openstreetmap.org/?lat=52.09266&lon=5.18550&zoom=17 Einsteindreef (OSM id 7059335) bad arc of length 2,80m http://www.openstreetmap.org/?lat=52.11912&lon=5.11283&zoom=17 Franciscusdreef (OSM id 7066146) bad arc of length 2,39m http://www.openstreetmap.org/?lat=52.11914&lon=5.08564&zoom=17 Franciscusdreef (OSM id 7066570) bad arc of length 2,39m http://www.openstreetmap.org/?lat=52.11912&lon=5.08551&zoom=17 Schonauwenseweg (OSM id 7096292) bad arc of length 1,47m http://www.openstreetmap.org/?lat=52.01011&lon=5.18553&zoom=17 Kanaaldijk Zuid (OSM id 7096366) bad arc of length 1,47m http://www.openstreetmap.org/?lat=52.00514&lon=5.18555&zoom=17 Schalkwijkseweg (OSM id 7096378) bad arc of length 2,80m http://www.openstreetmap.org/?lat=52.01011&lon=5.18553&zoom=17 null (OSM id 23086095) bad arc of length 2,80m http://www.openstreetmap.org/?lat=52.11914&lon=5.04436&zoom=17 null (OSM id 23086101) bad arc of length 3,78m http://www.openstreetmap.org/?lat=52.11914&lon=5.04442&zoom=17 N203 Provincialeweg (OSM id 6605992) bad arc of length 4,78m http://www.openstreetmap.org/?lat=52.47066&lon=4.80536&zoom=17 Staalhavenweg (OSM id 6632824) bad arc of length 2,39m http://www.openstreetmap.org/?lat=52.47070&lon=4.62602&zoom=17 Zwarte Pad (OSM id 7495148) bad arc of length 3,78m http://www.openstreetmap.org/?lat=52.11916&lon=4.29286&zoom=17 null (OSM id 30611242) bad arc of length 2,39m http://www.openstreetmap.org/?lat=52.11916&lon=4.30825&zoom=17 Vlotgrasweg (OSM id 6544034) bad arc of length 2,80m http://www.openstreetmap.org/?lat=52.47070&lon=5.54116&zoom=17 Lisdoddeweg (OSM id 6544035) bad arc of length 3,76m http://www.openstreetmap.org/?lat=52.47070&lon=5.54123&zoom=17 null (OSM id 6589537) bad arc of length 1,46m http://www.openstreetmap.org/?lat=52.43262&lon=5.00979&zoom=17 Prinsenweg (OSM id 6958461) bad arc of length 1,46m http://www.openstreetmap.org/?lat=52.20274&lon=5.62500&zoom=17 Hogeweg (OSM id 6965686) bad arc of length 1,46m http://www.openstreetmap.org/?lat=52.34878&lon=5.62498&zoom=17 Drieseweg (OSM id 6967746) bad arc of length 2,92m http://www.openstreetmap.org/?lat=52.25984&lon=5.62500&zoom=17 null (OSM id 7059063) bad arc of length 2,80m http://www.openstreetmap.org/?lat=52.11916&lon=5.11821&zoom=17 Neckardreef (OSM id 7059064) bad arc of length 3,78m http://www.openstreetmap.org/?lat=52.11916&lon=5.11821&zoom=17 Einsteindreef (OSM id 7059335) bad arc of length 2,80m http://www.openstreetmap.org/?lat=52.11914&lon=5.11285&zoom=17 Colombiadreef (OSM id 7059453) bad arc of length 3,78m http://www.openstreetmap.org/?lat=52.11916&lon=5.09669&zoom=17 Japuradreef (OSM id 7059454) bad arc of length 3,78m http://www.openstreetmap.org/?lat=52.11916&lon=5.09669&zoom=17 Valkenkamp (OSM id 7070206) bad arc of length 2,80m http://www.openstreetmap.org/?lat=52.14041&lon=5.00977&zoom=17 Valkenkamp (OSM id 7070266) bad arc of length 1,47m http://www.openstreetmap.org/?lat=52.14038&lon=5.00979&zoom=17 null (OSM id 29894188) bad arc of length 4,78m http://www.openstreetmap.org/?lat=52.47066&lon=5.02457&zoom=17 -- Durgerdamstraat 29, 1507 JL Zaandam; telefoon 075-7074579
Hi Valentijn, Thanks for the feedback. I can see where the problem is occuring. Wherever you have a node that is within the minimum arc length from a tile boundary you will get an error message. The question is: Is the routing actually broken at those locations? Cheers, Mark
Hi Mark, At Wed, Aug 12, 2009 at 09:19:36PM +0100, Mark Burton wrote:
I can see where the problem is occuring. Wherever you have a node that is within the minimum arc length from a tile boundary you will get an error message.
Your mail now sounds much less SEVERE than the error message :-)
The question is: Is the routing actually broken at those locations?
Will check. Tomorrow. V.
At Wed, Aug 12, 2009 at 10:37:14PM +0200, Valentijn Sessink wrote:
The question is: Is the routing actually broken at those locations? Will check. Tomorrow.
Actually, while thinking about it: I'm not sure what to test. Should I check one of the sites that has a SEVERE message? Does your patch specifically target these locations? Do you expect routing not to work at these locations without your patch? And does "not work" mean that there's a road, but you won't get a route over it? Like the infamous tunnel you couldn't get through, even if it were an 80 meters journey? That sort of problem? Best regards, Valentijn
At Wed, Aug 12, 2009 at 10:37:14PM +0200, Valentijn Sessink wrote:
The question is: Is the routing actually broken at those locations? Will check. Tomorrow.
Actually, while thinking about it: I'm not sure what to test. Should I check one of the sites that has a SEVERE message? Does your patch specifically target these locations? Do you expect routing not to work at these locations without your patch? And does "not work" mean that there's a road, but you won't get a route over it? Like the infamous tunnel you couldn't get through, even if it were an 80 meters journey? That sort of problem?
The patch should actually reduce the number of short arcs. The remaining arcs that it is now complaining about were there already, the new patch hasn't created them, it's just now detecting them! So, I would like to know if those ways it is griping about are routable or not. If possible, please test a few to see if you can route over them. Cheers, Mark
Mark, Again, a quick check, but I can't seem to route on the Fransiscusdreef: F'dreef to Vechtdijk sends me on a 1.2km odyssee :) Here's the data: 63240003: 0x24d000,0x34000 to 0x251000,0x3b000 63240008: 0x251000,0x25000 to 0x255000,0x39000 63240009: 0x251000,0x39000 to 0x255000,0x40000 java -Xmx1600m -enableassertions -jar ~/garmintest/splitter/dist/splitter.jar --split-file=areas.list netherlands.osm I used: java -enableassertions -Xmx1800m -jar ~/garmintest/mkgmap/dist/mkgmap.jar --country-name=Nederland --country-abbr=NL --latin1 --lower-case --preserve-element-order --location-autofill=1 --gmapsupp --route --net --tdbfile -c template.args See attached gdb-file. For now, I'll stop testing, but if you want me to test anything else, please tell me so. Best regards, Valentijn Mark Burton schreef:
So, I would like to know if those ways it is griping about are routable or not. If possible, please test a few to see if you can route over them. -- Durgerdamstraat 29, 1507 JL Zaandam; telefoon 075-7074579
Mark, Sorry for the misunderstanding. Without looking, I assumed the SEVERE error had been introduced by your patch, while it was probably somewhere between r1127 and r1131 (not sure, did not look again). Without your patch, the same errors show up. However, experimenting a bit with the Fransiscusdreef I sent, I think I have a small, simple, reproducable (in MapSource that is, so no guarantees) routing problem where A to C goes wrong, while A to B, B to C and A to B via C go right. I thought you might be interested, the MapSource file is attached. This goes wrong both with and without your patch (but both of them were compiled *without* any remove-short-arcs options, so I guess there is a chance that the unpatched version *with* remove-short-arcs behaves totally different from the new version without any remove-short-arcs (as r-s-arcs is default now), right? Best regards, Valentijn Mark Burton schreef:
The patch should actually reduce the number of short arcs. The remaining arcs that it is now complaining about were there already, the new patch hasn't created them, it's just now detecting them! -- Durgerdamstraat 29, 1507 JL Zaandam; telefoon 075-7074579
Hi Valentijn, Thanks for the feedback. I have now posted a new patch that should fix the majority of the short arcs introduced by the clipping. It's not perfect but (I hope) a step in the right direction. My own testing shows that the presence of a short arc does not guarantee that the routing will be borken at that point but it can be. Cheers, Mark
participants (2)
-
Mark Burton -
Valentijn Sessink