[patch] ignore unnamed generated POIs

Hi, I whipped up a patch to ignore unnamed POIs generated with the --add-pois-to-areas option. The patch adds the option to delete all tags with the 'delete' action using '*'. What do people think; is this a good approach? Thanks, Ben

Hi Ben, thanks for the patch. From my point of view it makes sense to skip an element from further processing. I would prefer to use a different approach. I see three possible options: 1. Implement a skip action or skip type so that the following rule skips all POIs with no name tag created by the --add-pois-to-areas option: name!=* & mkgmap:area2poi=true [ skip ] or name!=* & mkgmap:area2poi=true { skip } I am not sure which one is the better and cleaner way. I think it is the first one. 2. Use your delete * action but add a deleteAllTags method to the Element class. Modify the DeleteAction class so that the deleteAllTags method is called if the tagname is *. I think this is a cleaner way than to put this special tag name * into the deleteTag method. 3. Implement a deleteall action that calls the Element.deleteAllTags method described in 2. WanMil
Hi,
I whipped up a patch to ignore unnamed POIs generated with the --add-pois-to-areas option. The patch adds the option to delete all tags with the 'delete' action using '*'. What do people think; is this a good approach?
Thanks, Ben
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Am 23.05.2012 20:19, schrieb WanMil:
1. Implement a skip action or skip type so that the following rule skips all POIs with no name tag created by the --add-pois-to-areas option: name!=*& mkgmap:area2poi=true [ skip ] or name!=*& mkgmap:area2poi=true { skip }
I am not sure which one is the better and cleaner way. I think it is the first one. I think the second would be better, because skipping is an action an should be also in { } like all other actions.
Henning

I would like to get also POI without name-tag because you'll need a POI as node for searching. So please make it optional. Henning
participants (3)
-
aighes
-
Ben Konrath
-
WanMil