Serious mkgmap Bug - set unconnected type not respecting continue command!
Well the bug is quite serious and took me about 6 hours to find out why I'm missing roads in my maps. In case you have an "unconnected" type of a road that you set up a rule for, with " set mkgmap:set_unconnected_type=none" and [continue] - all subsequent commands for the object will be lost, if the set:unconnected becomes true. Reproduce: lines file (only this content needed). highway=motorway & bridge=yes {set mkgmap:set_unconnected_type=none} [0x13 road_class=1 road_speed=0 resolution 24 continue] highway=motorway [0x10001 resolution 24 continue] Now in all places that have a bridge, the motorway will be missing. If however the example is changed to the following, the bug is not present (as the unconnected type condition is not true): highway=motorway & bridge=yes {set mkgmap:set_unconnected_type=none} [0x13 road_class=1 road_speed=0 resolution 24 continue] highway=motorway [0x01 road_class=1 road_speed=0 resolution 24 continue] I don't know if there are any other problems related to this bug. However it is really defeating the purpose of set unconnected type right now, if working with overlays for bridges, routes, and many other things! -- keep on biking and discovering new trails Felix openmtbmap.org & www.velomap.org
No comments or solution to this bug? On Aug 26, 2013 9:37 PM, "Felix Hartmann" <extremecarver@gmail.com> wrote:
Well the bug is quite serious and took me about 6 hours to find out why I'm missing roads in my maps. In case you have an "unconnected" type of a road that you set up a rule for, with " set mkgmap:set_unconnected_type=**none" and [continue] - all subsequent commands for the object will be lost, if the set:unconnected becomes true.
Reproduce:
lines file (only this content needed). highway=motorway & bridge=yes {set mkgmap:set_unconnected_type=**none} [0x13 road_class=1 road_speed=0 resolution 24 continue] highway=motorway [0x10001 resolution 24 continue]
Now in all places that have a bridge, the motorway will be missing.
If however the example is changed to the following, the bug is not present (as the unconnected type condition is not true): highway=motorway & bridge=yes {set mkgmap:set_unconnected_type=**none} [0x13 road_class=1 road_speed=0 resolution 24 continue] highway=motorway [0x01 road_class=1 road_speed=0 resolution 24 continue]
I don't know if there are any other problems related to this bug. However it is really defeating the purpose of set unconnected type right now, if working with overlays for bridges, routes, and many other things!
-- keep on biking and discovering new trails
Felix openmtbmap.org & www.velomap.org
On 26/08/13 20:37, Felix Hartmann wrote:
lines file (only this content needed). highway=motorway & bridge=yes {set mkgmap:set_unconnected_type=none} [0x13 road_class=1 road_speed=0 resolution 24 continue] highway=motorway [0x10001 resolution 24 continue]
Its because the road is completely removed when it is unconnected and the unconnected type is none. Perhaps it shouldn't be completely removed, see attached patch. However the patch may break something that it is supposed to do though... ..Steve
okay, thanks, will try the patch on Monday - currently got time but server blocked. And on weekend no time... In most cases where I use type=none it's because of using invisible routing network over visible nonroutable types. I usually use them for routing on places, that should only under some conditions be routable - and if routable then only invisible and using another type to show the road/feature (limitation of very few types that are routable). On 30.08.2013 01:02, Steve Ratcliffe wrote:
On 26/08/13 20:37, Felix Hartmann wrote:
lines file (only this content needed). highway=motorway & bridge=yes {set mkgmap:set_unconnected_type=none} [0x13 road_class=1 road_speed=0 resolution 24 continue] highway=motorway [0x10001 resolution 24 continue]
Its because the road is completely removed when it is unconnected and the unconnected type is none.
Perhaps it shouldn't be completely removed, see attached patch.
However the patch may break something that it is supposed to do though...
..Steve
-- keep on biking and discovering new trails Felix openmtbmap.org & www.velomap.org
patch seems to work fine. I think it should be committed to trunk... On 30.08.2013 09:14, Felix Hartmann wrote:
okay, thanks, will try the patch on Monday - currently got time but server blocked. And on weekend no time...
In most cases where I use type=none it's because of using invisible routing network over visible nonroutable types. I usually use them for routing on places, that should only under some conditions be routable - and if routable then only invisible and using another type to show the road/feature (limitation of very few types that are routable). On 30.08.2013 01:02, Steve Ratcliffe wrote:
On 26/08/13 20:37, Felix Hartmann wrote:
lines file (only this content needed). highway=motorway & bridge=yes {set mkgmap:set_unconnected_type=none} [0x13 road_class=1 road_speed=0 resolution 24 continue] highway=motorway [0x10001 resolution 24 continue]
Its because the road is completely removed when it is unconnected and the unconnected type is none.
Perhaps it shouldn't be completely removed, see attached patch.
However the patch may break something that it is supposed to do though...
..Steve
-- keep on biking and discovering new trails Felix openmtbmap.org & www.velomap.org
participants (2)
-
Felix Hartmann -
Steve Ratcliffe