[PATCH v1] Thin out builtin-tag-list

I want to remove all tags that are not necessarily needed but are still remaining in the builtin-tag-list. From my point of view the following tags can be removed: day_off day_on hour_off hour_on => They are only used in the RestricationRelation class to warn the user that these tags are not supported. addr:phone openGeoDB:sort_name => they are not referenced by any java class natural => only accessed by the SeaGenerator and that adds the tag dynamically osm:id? => It is added by the HighwayHook but does it really exists in the source data? barrier cycleway fixme FIXME => only accessed by the HighwayHooks and are added dynamically using the attached patch WanMil

Actually, one question related to this patch. I currently delete all motorcar, motorcycle, emergency, and so on tags via the style-file. Could I instead just remove them from the built-in tag list and thereby make the map quicker to build? (I will set new values for them, but would prefer them not to be read in at all) On 11.04.2011 21:41, WanMil wrote:
I want to remove all tags that are not necessarily needed but are still remaining in the builtin-tag-list.
From my point of view the following tags can be removed:
day_off day_on hour_off hour_on => They are only used in the RestricationRelation class to warn the user that these tags are not supported.
addr:phone openGeoDB:sort_name => they are not referenced by any java class
natural => only accessed by the SeaGenerator and that adds the tag dynamically
osm:id? => It is added by the HighwayHook but does it really exists in the source data?
barrier cycleway fixme FIXME => only accessed by the HighwayHooks and are added dynamically using the attached patch
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Actually, one question related to this patch.
I currently delete all motorcar, motorcycle, emergency, and so on tags via the style-file. Could I instead just remove them from the built-in tag list and thereby make the map quicker to build? (I will set new values for them, but would prefer them not to be read in at all)
I am not sure if it's really the same. At least the HighwayHook that runs before the style is applied use these tags to configure the road exceptions. So if you remove it via style the exceptions seems to be already set. If you don't want to have it, you could better remove the tags from the built-in-tag list file but you must ensure that these tags are not referenced in one of your style file.
On 11.04.2011 21:41, WanMil wrote:
I want to remove all tags that are not necessarily needed but are still remaining in the builtin-tag-list.
From my point of view the following tags can be removed:
day_off day_on hour_off hour_on => They are only used in the RestricationRelation class to warn the user that these tags are not supported.
addr:phone openGeoDB:sort_name => they are not referenced by any java class
natural => only accessed by the SeaGenerator and that adds the tag dynamically
osm:id? => It is added by the HighwayHook but does it really exists in the source data?
barrier cycleway fixme FIXME => only accessed by the HighwayHooks and are added dynamically using the attached patch
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Actually, one question related to this patch.
I currently delete all motorcar, motorcycle, emergency, and so on tags via the style-file. Could I instead just remove them from the built-in tag list and thereby make the map quicker to build? (I will set new values for them, but would prefer them not to be read in at all)
I am not sure if it's really the same. At least the HighwayHook that runs before the style is applied use these tags to configure the road exceptions. So if you remove it via style the exceptions seems to be already set.
If you don't want to have it, you could better remove the tags from the built-in-tag list file but you must ensure that these tags are not referenced in one of your style file.
There is also an extra mkgmap option: --delete-tags-file=FILENAME Names a file that should contain one or more lines of the form TAG=VALUE or TAG=*. Blank lines and lines that start with # or ; are ignored. All tag/value pairs in the OSM input are compared with these patterns and those that match are deleted. This is the best way to be sure that a specific tag is not loaded from file. WanMil

On 12.04.2011 22:51, WanMil wrote:
Actually, one question related to this patch.
I currently delete all motorcar, motorcycle, emergency, and so on tags via the style-file. Could I instead just remove them from the built-in tag list and thereby make the map quicker to build? (I will set new values for them, but would prefer them not to be read in at all) I am not sure if it's really the same. At least the HighwayHook that runs before the style is applied use these tags to configure the road exceptions. So if you remove it via style the exceptions seems to be already set.
If you don't want to have it, you could better remove the tags from the built-in-tag list file but you must ensure that these tags are not referenced in one of your style file.
There is also an extra mkgmap option: --delete-tags-file=FILENAME Names a file that should contain one or more lines of the form TAG=VALUE or TAG=*. Blank lines and lines that start with # or ; are ignored. All tag/value pairs in the OSM input are compared with these patterns and those that match are deleted.
This is the best way to be sure that a specific tag is not loaded from file.
WanMil _______________________________________________
This extra mkgmap option is broken since a very very long time. I reported this once more than a year ago on the list. It got broken when the mkgmap speed branch got merged if I remember correctly.

Hi
This extra mkgmap option is broken since a very very long time. I reported this once more than a year ago on the list. It got broken when the mkgmap speed branch got merged if I remember correctly.
I just tried a couple of examples with --delete-tags-file and it behaved exactly as I expected both times. Could you be more specific in what way it is broken? ..Steve

BTW this patch decreased compilation time from 2:36 to 2:31 (min:seconds) for my austria map. So it is noticeable, but small effect. On 11.04.2011 21:41, WanMil wrote:
I want to remove all tags that are not necessarily needed but are still remaining in the builtin-tag-list.
From my point of view the following tags can be removed:
day_off day_on hour_off hour_on => They are only used in the RestricationRelation class to warn the user that these tags are not supported.
addr:phone openGeoDB:sort_name => they are not referenced by any java class
natural => only accessed by the SeaGenerator and that adds the tag dynamically
osm:id? => It is added by the HighwayHook but does it really exists in the source data?
barrier cycleway fixme FIXME => only accessed by the HighwayHooks and are added dynamically using the attached patch
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

On Mon, Apr 11, 2011 at 09:41:59PM +0200, WanMil wrote:
From my point of view the following tags can be removed:
day_off day_on hour_off hour_on => They are only used in the RestricationRelation class to warn the user that these tags are not supported.
The patch appears to make these warnings go away. Other than this, I guess that the patch is fine. I do not mind about losing the warnings, but it might be good to add a comment that explains that the check will be dead code. Marko
participants (4)
-
Felix Hartmann
-
Marko Mäkelä
-
Steve Ratcliffe
-
WanMil