default style points enhancements
Hi Gerd and followers of the default style Here are some enhancements to default style "points" - patch attached. I've been building up a list of changes to the default style for a while, and, with the current discussion about multiple POI for a single OSM object and the benefit of benches (I've just added this), it seemed like a good time to put forward these changes. Some of these derive from: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2019q4/030097.html Some from other comments in this forum and the rest are from when I've noticed something wrong or that could be improved. Summary of changes: - for amenity={atm/bar/cafe} allow additional POI from other tags, eg shop=bakery or any others: leisure/tourism/sport/...=... - create POI 0x6605 for bench (Geographic>Land>Bench) - don't create POI for private parking - create parking POI for parking_entrance - if parking unnamed, use access tag if exists, giving names like "Customer parking", "Permissive parking"... - explicit shelter_type=basic_hut rather that trying to exclude bus shelters etc for Find>Lodgings - marina code from 0x4300 to 0x2f09; searchable as "Others" - POI for nature_reserve, even if not named - don't create POI for pitch if no name or sport - don't create POI for private swimming pools - don't create POI for unnamed cliff - add POI 0x6503 for named bay (Geographic>Water>Bay) - for platforms, just 1 POI when --add-pois-to-lines - name unnamed shops as category, regardless of category being matched - add, commented out, extra shop categories supported by some devices - add POI for shop=outdoor - for {camp/caravan}_site have BOTH 0x2b03 AND 0x2b05; 03 not shown on modern devices, 05 not shown on old devices - have both Food & Lodging POI for same point if appropriate - landuse=basin code from 0x650f (Geographic>Water>Reservoir) to 0x6603 (Geographic>Land>Basin) - water=reservoir as well as landuse=reservoir - add POI 0x650d for named water=lake/pond (Geograhic>Water>Lake) I'm happy to explain any of these change in more detail and, if anyone considers a particular change incorrect, provide a revised patch. Ticker
Nice! I have reviewed mapnik.txt in relation to default style. Now I'm capable of generating (in automation) an Excel showing all tags, values and usage. Also for my own style. TYPFILE_mapnik_2020-04-22.xlsx <http://gis.19327.n8.nabble.com/file/t344065/TYPFILE_mapnik_2020-04-22.xlsx> In this Excel I have made some remarks or suggestions (in red). Of course this was a manual action. TYPFILE_Mapnik_Reviewed.xlsx <http://gis.19327.n8.nabble.com/file/t344065/TYPFILE_Mapnik_Reviewed.xlsx> In your list of POI's I miss: - leisure=picnic_table picnic_site most often has also a picnic_table, but not always. picnic_site might have more objects (hut, shelter, benches, drinking water, barbecue, fireplace). Or picnic_site is just a nice view only, no amenity. In wet circumstances we are only interested in picnic_table, not in picnic_site. leisure=picnic_table is a de facto tag since 2014. Rendered by JOSM since 2014. -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
Hé bug in "TYPFILE_mapnik_2020-04-22.xlsx"? No italian language? -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
Bugfix: subscript out of range. TYPFILE_mapnik_2020-04-22_FIX.xlsx <http://gis.19327.n8.nabble.com/file/t344065/TYPFILE_mapnik_2020-04-22_FIX.xlsx> Including italian language. -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
Hi Eric Happy to add: leisure=picnic_table to my proposed change list, using the same code as picnic_site (0x4a00, "Picnic Area", not searchable) I don't want to look through spreadsheets; if there are comments relevant to default style "points", please just post them as text. Also, all the codes in "points" render nicely on old devices without any TYP file, and are chosen to match, if as far as possible, the device FIND> functionality. mapnik.txt is not a consideration. Ticker On Wed, 2020-04-22 at 08:07 -0700, AnkEric wrote:
Nice!
I have reviewed mapnik.txt in relation to default style. Now I'm capable of generating (in automation) an Excel showing all tags, values and usage. Also for my own style.
TYPFILE_mapnik_2020-04-22.xlsx <http://gis.19327.n8.nabble.com/file/t344065/TYPFILE_mapnik_2020-04-2 2.xlsx> ;
In this Excel I have made some remarks or suggestions (in red). Of course this was a manual action.
TYPFILE_Mapnik_Reviewed.xlsx <http://gis.19327.n8.nabble.com/file/t344065/TYPFILE_Mapnik_Reviewed. xlsx> ;
In your list of POI's I miss:
- leisure=picnic_table
picnic_site most often has also a picnic_table, but not always. picnic_site might have more objects (hut, shelter, benches, drinking water, barbecue, fireplace). Or picnic_site is just a nice view only, no amenity. In wet circumstances we are only interested in picnic_table, not in picnic_site. leisure=picnic_table is a de facto tag since 2014. Rendered by JOSM since 2014.
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd As there were no objections to these enhancements to the default style, could you commit it. Thanks Ticker On Wed, 2020-04-22 at 15:24 +0100, Ticker Berkin wrote:
Hi Gerd and followers of the default style
Here are some enhancements to default style "points" - patch attached.
I've been building up a list of changes to the default style for a while, and, with the current discussion about multiple POI for a single OSM object and the benefit of benches (I've just added this), it seemed like a good time to put forward these changes.
Some of these derive from: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2019q4/030097.html
Some from other comments in this forum and the rest are from when I've noticed something wrong or that could be improved.
Summary of changes: - for amenity={atm/bar/cafe} allow additional POI from other tags, eg shop=bakery or any others: leisure/tourism/sport/...=... - create POI 0x6605 for bench (Geographic>Land>Bench) - don't create POI for private parking - create parking POI for parking_entrance - if parking unnamed, use access tag if exists, giving names like "Customer parking", "Permissive parking"... - explicit shelter_type=basic_hut rather that trying to exclude bus shelters etc for Find>Lodgings - marina code from 0x4300 to 0x2f09; searchable as "Others" - POI for nature_reserve, even if not named - don't create POI for pitch if no name or sport - don't create POI for private swimming pools - don't create POI for unnamed cliff - add POI 0x6503 for named bay (Geographic>Water>Bay) - for platforms, just 1 POI when --add-pois-to-lines - name unnamed shops as category, regardless of category being matched - add, commented out, extra shop categories supported by some devices - add POI for shop=outdoor - for {camp/caravan}_site have BOTH 0x2b03 AND 0x2b05; 03 not shown on modern devices, 05 not shown on old devices - have both Food & Lodging POI for same point if appropriate - landuse=basin code from 0x650f (Geographic>Water>Reservoir) to 0x6603 (Geographic>Land>Basin) - water=reservoir as well as landuse=reservoir - add POI 0x650d for named water=lake/pond (Geograhic>Water>Lake)
I'm happy to explain any of these change in more detail and, if anyone considers a particular change incorrect, provide a revised patch.
Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Ticker, OK, let's see what happens, I've only looked at the patch and did not see anything but did not try to find out the effects. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Montag, 8. Juni 2020 12:53 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] default style points enhancements Hi Gerd As there were no objections to these enhancements to the default style, could you commit it. Thanks Ticker On Wed, 2020-04-22 at 15:24 +0100, Ticker Berkin wrote:
Hi Gerd and followers of the default style
Here are some enhancements to default style "points" - patch attached.
I've been building up a list of changes to the default style for a while, and, with the current discussion about multiple POI for a single OSM object and the benefit of benches (I've just added this), it seemed like a good time to put forward these changes.
Some of these derive from: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2019q4/030097.html
Some from other comments in this forum and the rest are from when I've noticed something wrong or that could be improved.
Summary of changes: - for amenity={atm/bar/cafe} allow additional POI from other tags, eg shop=bakery or any others: leisure/tourism/sport/...=... - create POI 0x6605 for bench (Geographic>Land>Bench) - don't create POI for private parking - create parking POI for parking_entrance - if parking unnamed, use access tag if exists, giving names like "Customer parking", "Permissive parking"... - explicit shelter_type=basic_hut rather that trying to exclude bus shelters etc for Find>Lodgings - marina code from 0x4300 to 0x2f09; searchable as "Others" - POI for nature_reserve, even if not named - don't create POI for pitch if no name or sport - don't create POI for private swimming pools - don't create POI for unnamed cliff - add POI 0x6503 for named bay (Geographic>Water>Bay) - for platforms, just 1 POI when --add-pois-to-lines - name unnamed shops as category, regardless of category being matched - add, commented out, extra shop categories supported by some devices - add POI for shop=outdoor - for {camp/caravan}_site have BOTH 0x2b03 AND 0x2b05; 03 not shown on modern devices, 05 not shown on old devices - have both Food & Lodging POI for same point if appropriate - landuse=basin code from 0x650f (Geographic>Water>Reservoir) to 0x6603 (Geographic>Land>Basin) - water=reservoir as well as landuse=reservoir - add POI 0x650d for named water=lake/pond (Geograhic>Water>Lake)
I'm happy to explain any of these change in more detail and, if anyone considers a particular change incorrect, provide a revised patch.
Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
AnkEric -
Gerd Petermann -
Ticker Berkin