[PATCH] make tdbfile (fully) the default and remove --tdb-v3
Hi The tdbfile option is currently the default, except when there is only one input file. The attached patch removes that quirk and also removes the --tdb-v3 option. The version 3 is useless for routing and only ever existed because it took a long time to work out version 4. Also fix an obscure crash when you specify files that don't exist, that got exposed by the rest of the patch. ..Steve
Am 08.12.2012 15:53, schrieb Steve Ratcliffe:
Hi
The tdbfile option is currently the default, except when there is only one input file. The attached patch removes that quirk and also removes the --tdb-v3 option. The version 3 is useless for routing and only ever existed because it took a long time to work out version 4.
Also fix an obscure crash when you specify files that don't exist, that got exposed by the rest of the patch. Hi Steve, is this patch already committed?
I remember, that --tdbfile also is necessary to build the normal index then you use --index and --gmapsupp. So with new behaviour both indexes would be generated when you set --index and --gmapsupp, which needs quiet much memory (see help-file, or is help-file wrong?) I always generated both indexes and had no problem, so I can't say if memory increases much. Have a nice X-mas, Henning
Hi
is this patch already committed?
No it isn't yet, and that patch doesn't make tdbfile a default in a way that would affect its use with --index. Still, you make a good point. We shall have to think about how this should work. I don't really like using tdbfile with index to mean create a "desktop" index anyway. So either we should create the gmapsupp index if that option is given and the desktop index otherwise or create both if the gmapsupp option is given. Its always possible to have --index=gps,... but I don't like that much either.
I remember, that --tdbfile also is necessary to build the normal index then you use --index and --gmapsupp. So with new behaviour both indexes would be generated when you set --index and --gmapsupp, which needs quiet much memory (see help-file, or is help-file wrong?) I always generated both indexes and had no problem, so I can't say if memory
It does use more on average, but peak memory usage may not be different, since the peak memory use only occurs during one sorting operation. So maybe it is not so much of a problem as I thought. Certainly it would be possible to fix it so that it doesn't use any more memory. ..Steve
Hi Steve, I think a good solution would be to have --index as default. If --gmapsupp is set, first the index for MapSource is generated and then for gmapsupp, so there shouldn't be a memory-problem at all and typical the index is generated quiet fast (compared to complete mkgmap run). Without --gmapsupp only index for MapSource is generated. If --no-index is set and no index is generated at all. But I haven't a good idea for only generating an index for gmapsupp. Maybe --only-gmapsupp-index. Henning
participants (2)
-
Henning Scholland -
Steve Ratcliffe