MIssing public transport stops in default style
According to OSM wiki bus stops can be tagged as bus_stop=yes or as public_transport=platform + bus=yes (or both ways), but current default style only catches the first case. The same can be said about tram stops. Attached patch adds rules for the second way of tagging.
dont worry about the style as much why not make your own poi list like i have done and it works for me stephen On Thu, Aug 21, 2014 at 7:04 AM, Carlos Dávila <cdavilam@orangecorreo.es> wrote:
According to OSM wiki bus stops can be tagged as bus_stop=yes or as public_transport=platform + bus=yes (or both ways), but current default style only catches the first case. The same can be said about tram stops. Attached patch adds rules for the second way of tagging.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
El 20/08/14 23:03, Steve Sgalowski escribió:
dont worry about the style as much why not make your own poi list like i have done and it works for me
stephen
On Thu, Aug 21, 2014 at 7:04 AM, Carlos Dávilawrote:
According to OSM wiki bus stops can be tagged as bus_stop=yes or as public_transport=platform + bus=yes (or both ways), but current default style only catches the first case. The same can be said about tram stops. Attached patch adds rules for the second way of tagging.
I also use my own style since a very long time ago. I don't understand why you don't like if we try to improve default style, a general purpose one used by many people. That's what collaborative projects are for, isn't it?
On Wed, Aug 20, 2014 at 11:04:02PM +0200, Carlos Dávila wrote:
According to OSM wiki bus stops can be tagged as bus_stop=yes or as public_transport=platform + bus=yes (or both ways), but current default style only catches the first case. The same can be said about tram stops. Attached patch adds rules for the second way of tagging.
Thanks! I think that this can be simplified a little:
( public_transport=platform & (bus=yes | tram=yes) ) | (highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
I do not think that we need the & (bus=yes | tram=yes) here. These rules are only setting the name for any kind of stop. They are not yet creating the POI.
-highway=bus_stop [0x2f17 resolution 24] +( public_transport=platform & bus=yes ) | highway=bus_stop [0x2f17 resolution 24]
I would just group bus and tram stops together here, but move the rule after railway=* so that the railway-specific rules would fire first:
@@ -226,7 +226,7 @@
railway=halt [0x2f08 resolution 23] railway=station [0x2f08 resolution 22] -railway=tram_stop [0x2f17 resolution 24] +( public_transport=platform & tram=yes ) | railway=tram_stop [0x2f17 resolution 24]
Here, I would remove your + line and instead write: public_transform=platform & rail=yes [0x2f08...] highway=bus_stop|highway=tram_stop|public_transport=platform [0x2f17...] I did not check if rail=yes is a valid tag. In this way, if a public_transport=platform is not rail=yes, it will be assigned the type 0x2f17. All railway stops would be 0x2f08, except tram stops which are 0x2f17. Can you submit a revised patch for this? Marko
I'm a little busy this week, but will try to apply your suggestions and send a new patch. El 21/08/14 13:40, Marko Mäkelä escribió:
On Wed, Aug 20, 2014 at 11:04:02PM +0200, Carlos Dávila wrote:
According to OSM wiki bus stops can be tagged as bus_stop=yes or as public_transport=platform + bus=yes (or both ways), but current default style only catches the first case. The same can be said about tram stops. Attached patch adds rules for the second way of tagging.
Thanks! I think that this can be simplified a little:
( public_transport=platform & (bus=yes | tram=yes) ) | (highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
I do not think that we need the & (bus=yes | tram=yes) here. These rules are only setting the name for any kind of stop. They are not yet creating the POI.
-highway=bus_stop [0x2f17 resolution 24] +( public_transport=platform & bus=yes ) | highway=bus_stop [0x2f17 resolution 24]
I would just group bus and tram stops together here, but move the rule after railway=* so that the railway-specific rules would fire first:
@@ -226,7 +226,7 @@
railway=halt [0x2f08 resolution 23] railway=station [0x2f08 resolution 22] -railway=tram_stop [0x2f17 resolution 24] +( public_transport=platform & tram=yes ) | railway=tram_stop [0x2f17 resolution 24]
Here, I would remove your + line and instead write:
public_transform=platform & rail=yes [0x2f08...] highway=bus_stop|highway=tram_stop|public_transport=platform [0x2f17...]
I did not check if rail=yes is a valid tag.
In this way, if a public_transport=platform is not rail=yes, it will be assigned the type 0x2f17. All railway stops would be 0x2f08, except tram stops which are 0x2f17.
Can you submit a revised patch for this?
Marko _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Por favor, no me envíe documentos con extensiones .doc, .docx, .xls, .xlsx, .ppt, .pptx, .mdb, mdbx Instale LibreOffice desde http://es.libreoffice.org/descarga/ LibreOffice es libre: se puede copiar, modificar y redistribuir libremente. Gratis y totalmente legal. LibreOffice está en continuo desarrollo y no tendrá que pagar por las nuevas versiones.
El 21/08/14 13:40, Marko Mäkelä escribió:
On Wed, Aug 20, 2014 at 11:04:02PM +0200, Carlos Dávila wrote:
According to OSM wiki bus stops can be tagged as bus_stop=yes or as public_transport=platform + bus=yes (or both ways), but current default style only catches the first case. The same can be said about tram stops. Attached patch adds rules for the second way of tagging.
Thanks! I think that this can be simplified a little:
( public_transport=platform & (bus=yes | tram=yes) ) | (highway=bus_stop | railway=tram_stop | railway=halt | railway=station)
I do not think that we need the & (bus=yes | tram=yes) here. These rules are only setting the name for any kind of stop. They are not yet creating the POI. Done
-highway=bus_stop [0x2f17 resolution 24] +( public_transport=platform & bus=yes ) | highway=bus_stop [0x2f17 resolution 24]
I would just group bus and tram stops together here, but move the rule after railway=* so that the railway-specific rules would fire first:
@@ -226,7 +226,7 @@
railway=halt [0x2f08 resolution 23] railway=station [0x2f08 resolution 22] -railway=tram_stop [0x2f17 resolution 24] +( public_transport=platform & tram=yes ) | railway=tram_stop [0x2f17 resolution 24]
Here, I would remove your + line and instead write:
public_transform=platform & rail=yes [0x2f08...] highway=bus_stop|highway=tram_stop|public_transport=platform [0x2f17...]
I did not check if rail=yes is a valid tag. There are currently more than 600 rail=yes in Europe, so it must be a valid tag;-)
In this way, if a public_transport=platform is not rail=yes, it will be assigned the type 0x2f17. All railway stops would be 0x2f08, except tram stops which are 0x2f17.
Can you submit a revised patch for this? Attached
Hi Carlos, Thanks for the revised patch! It looks OK, and it resulted in a slightly bigger map of Finland than before, with the same source data. Committed as revision 3334. Marko
participants (3)
-
Carlos Dávila -
Marko Mäkelä -
Steve Sgalowski