[PATCH v1] - make cycleway tracks
As requested, here's an option (--make-cycleway-tracks) to enable the synthesis of cycleways when a (non-cycleway) way is tagged cycleway=track. I have also tweaked the code for making opposite cycleways - it now gives the synthesised way a highway=cycleway tag which it wasn't doing before. So anyone who was using the --make-opposite-cycleways option, please test to see it hasn't been broken. Cheers, Mark
Mark Burton <markb@ordern.com> wrote:
As requested, here's an option (--make-cycleway-tracks) to enable the synthesis of cycleways when a (non-cycleway) way is tagged cycleway=track.
Wow, that was fast! Anyway looking at the patch this seems to be incomplete. We should synthesise a cycleway for the following tags: track,left,rigt,lane and yes. Where left or right will imply oneway=yes.
I have also tweaked the code for making opposite cycleways - it now gives the synthesised way a highway=cycleway tag which it wasn't doing before.
Hm, I'm not shure if this is a good idea, because the Garmin devices tend to prefer real cycleways over generic roads. This may not be the expected behaviour for one-way roads thus it might be better to assign the real type of "highway". Sven -- This golden age of communication Means everyone talks at the same time (Lyrics of "New Model Army" song "225") /me is giggls@ircnet, http://sven.gegg.us/ on the Web
Hi Sven,
Anyway looking at the patch this seems to be incomplete. We should synthesise a cycleway for the following tags: track,left,rigt,lane and yes.
Where left or right will imply oneway=yes.
I have no problem with matching more tags. However, left, right and yes are not discussed on http://wiki.openstreetmap.org/wiki/Key:cycleway how are they meant to be used?
I have also tweaked the code for making opposite cycleways - it now gives the synthesised way a highway=cycleway tag which it wasn't doing before.
Hm, I'm not shure if this is a good idea, because the Garmin devices tend to prefer real cycleways over generic roads. This may not be the expected behaviour for one-way roads thus it might be better to assign the real type of "highway".
Sorry, not sure what you're saying here. Cheers, Mark
Mark Burton <markb@ordern.com> wrote:
I have no problem with matching more tags. However, left, right and yes are not discussed on http://wiki.openstreetmap.org/wiki/Key:cycleway how are they meant to be used?
http://wiki.openstreetmap.org/wiki/Proposed_features/Advanced_footway_and_cy... left and right are major roads with cycleways on one side of the road only.
Hm, I'm not shure if this is a good idea, because the Garmin devices tend to prefer real cycleways over generic roads. This may not be the expected behaviour for one-way roads thus it might be better to assign the real type of "highway".
Sorry, not sure what you're saying here.
Is this due to my improper english? I'm not a native speaker after all. I will try to explain along the lines of the patch... You replaced cycleWay.copyTags with new code, this way you end e.g. up with something like this: highway=cycleway (+ more tags) instead of: highway=residential (+ more tags) However, this may lead to a situation, where cycling one-way roads into the opposite direction might get _prefered_ over cycling into the ordinary direction in cases where cycleways are prefered over residential roads. This is almost certainly not an expected behaviour. Sven -- C is quirky, flawed, and an enormous success (Dennis M. Ritchie) /me is giggls@ircnet, http://sven.gegg.us/ on the Web
Sven Geggus schreef:
You replaced cycleWay.copyTags with new code, this way you end e.g. up with something like this:
highway=cycleway (+ more tags)
instead of:
highway=residential (+ more tags)
However, this may lead to a situation, where cycling one-way roads into the opposite direction might get _prefered_ over cycling into the ordinary direction in cases where cycleways are prefered over residential roads.
So you mean: if a certain way has "highway=$something; oneway=yes; cycleway = opposite" mkgmap should ADD a fake road that has "highway=$something, oneway=-1" and then access restrictions for pretty much everything except bikes, is that what you're saying? (I think it's not your English, it's the complicated situation) V.
Valentijn Sessink <valentyn@blub.net> wrote:
So you mean: if a certain way has "highway=$something; oneway=yes; cycleway = opposite" mkgmap should ADD a fake road that has "highway=$something, oneway=-1" and then access restrictions for pretty much everything except bikes, is that what you're saying?
Exactly! It has been my impression looking at the code, that this has been the case before adding the patch Mark provided. Sven -- This APT has Super Cow Powers. (apt-get --help on debian woody) /me is giggls@ircnet, http://sven.gegg.us/ on the Web
On Fri, 24 Jul 2009 13:56:19 +0000 (UTC) Sven Geggus <lists@fuchsschwanzdomain.de> wrote:
Mark Burton <markb@ordern.com> wrote:
I have no problem with matching more tags. However, left, right and yes are not discussed on http://wiki.openstreetmap.org/wiki/Key:cycleway how are they meant to be used?
http://wiki.openstreetmap.org/wiki/Proposed_features/Advanced_footway_and_cy...
left and right are major roads with cycleways on one side of the road only.
OK - thanks for the link. So, as the cycleway gets generated using the same points as the original way, left and right can't really work as expected. However, we can still generate the cycleway, it just won't be biased to either side of the original way. The tag value "yes" doesn't get mentioned so I don't think we should accept that. The tags it can match could be: track, lane, both, left and right.
Hm, I'm not shure if this is a good idea, because the Garmin devices tend to prefer real cycleways over generic roads. This may not be the expected behaviour for one-way roads thus it might be better to assign the real type of "highway".
Sorry, not sure what you're saying here.
Is this due to my improper english? I'm not a native speaker after all.
No, I don't think it is your english, I can perfectly understand everything else you write!
I will try to explain along the lines of the patch...
You replaced cycleWay.copyTags with new code, this way you end e.g. up with something like this:
highway=cycleway (+ more tags)
instead of:
highway=residential (+ more tags)
Yes, but only on the cycleway, not the orginal way.
However, this may lead to a situation, where cycling one-way roads into the opposite direction might get _prefered_ over cycling into the ordinary direction in cases where cycleways are prefered over residential roads.
This is almost certainly not an expected behaviour.
Let me see if I understand this right: you are saying that with the opposite cycleway now tagged as highway=cycleway, it could be possible for that way to be used in preference to another way (that isn't a cycleway) because cycleways have a higher precedence for bicycle routing? Hmm, this will depend on what Garmin codes are assigned to the different ways and the effect that has on the routing. What line type codes do people use for cycleways? Cheers, Mark
participants (3)
-
Mark Burton -
Sven Geggus -
Valentijn Sessink