Turn restriction warnings too verbose and terse at the same time

In the warning output of finland.osm, I see 219 warnings about turn restriction relations. Apparently, there not that many errors in the map data, because I see duplicates, like this: 2009/10/20 15:39:32 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 2009/10/20 15:39:32 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 ... 2009/10/20 15:39:32 WARNING (RestrictionRelation): Turn restriction 167929 'to' way (18628061) doesn't start or end at 'via' node (62,59660/23,66127) ... 2009/10/20 15:40:11 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 2009/10/20 15:40:11 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 ... 2009/10/20 15:40:11 WARNING (RestrictionRelation): Turn restriction 167929 'to' way (18628061) doesn't start or end at 'via' node (62,59660/23,66127) Could I get the two sets of warnings because I am running with --max-jobs=2? Would it be possible to suppress the duplicate warnings, or at least display a download URL for each violation, e.g., for the 'via' node? All in all, there do not seem to be too many errors in roundabouts and turn restrictions in Finland. I should be able to fix them myself, eventually. I did not enable the checks on flare roads yet. In many roundabouts, the flare roads are bidirectional "radial spokes" instead of triangle-shaped oneway streets. Are these converted by mkgmap automatically? If not, could they be? Best regards, Marko

Hi Marko,
In the warning output of finland.osm, I see 219 warnings about turn restriction relations. Apparently, there not that many errors in the map data, because I see duplicates, like this:
2009/10/20 15:39:32 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 2009/10/20 15:39:32 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 ... 2009/10/20 15:39:32 WARNING (RestrictionRelation): Turn restriction 167929 'to' way (18628061) doesn't start or end at 'via' node (62,59660/23,66127) ... 2009/10/20 15:40:11 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 2009/10/20 15:40:11 WARNING (RestrictionRelation): Turn restriction 167929 has multiple 'to' members - first 'to' member is 18628061 ... 2009/10/20 15:40:11 WARNING (RestrictionRelation): Turn restriction 167929 'to' way (18628061) doesn't start or end at 'via' node (62,59660/23,66127)
Could I get the two sets of warnings because I am running with --max-jobs=2? Would it be possible to suppress the duplicate warnings, or at least display a download URL for each violation, e.g., for the 'via' node?
Yes, those warnings are not ideal - I will take a look and see if I can remove the dups. Also, I nearly added the download URL the other day but I was too lazy, I'll do it now!
All in all, there do not seem to be too many errors in roundabouts and turn restrictions in Finland. I should be able to fix them myself, eventually.
I did not enable the checks on flare roads yet. In many roundabouts, the flare roads are bidirectional "radial spokes" instead of triangle-shaped oneway streets. Are these converted by mkgmap automatically? If not, could they be?
The thing about automatically converting stuff is that you have to be 100% sure that it's wrong otherwise you just make the problem worse. I guess the triangle shaped flares could be fixed automatically but when I go and edit the OSM data where the flare road errors are, I am finding all sorts of bad stuff and fixing that as well so it has a double benefit. Cheers, Mark

Hi Marko,
Could I get the two sets of warnings because I am running with --max-jobs=2? Would it be possible to suppress the duplicate warnings, or at least display a download URL for each violation, e.g., for the 'via' node?
I've added the OSM URL into the turn restriction messages. As for duplicates, it could be that if you are processing multiple tiles, the turn restriction occurs in more than one tile and so the messages get repeated. If that is the case, it's hard to fix because the maps are processed independently. A fix would be a lot of work for very little gain. Probably a lot less effort to fix the OSM data! Cheers, Mark

Hi Mark,
I've added the OSM URL into the turn restriction messages.
Thanks, it works. Now I know to look mkgmap.log.0 for messages. I first looked at the highest-numbered log file, but it was the oldest one.
As for duplicates, it could be that if you are processing multiple tiles, the turn restriction occurs in more than one tile and so the messages get repeated. If that is the case, it's hard to fix because the maps are processed independently. A fix would be a lot of work for very little gain. Probably a lot less effort to fix the OSM data!
I am processing 3 tiles. Agreed, it is better to fix the problem than to shoot the messenger. :-) Marko
participants (2)
-
Mark Burton
-
Marko Mäkelä