improving address search

Some time ago Klaus suggested to remove the prefixes "Gemeinde" and "Stadt" from the address search string, see http://www.mail-archive.com/mkgmap-dev@lists.mkgmap.org.uk/msg10981.html Also on the osm forum someone is asking for the same while searching Austrian addresses. See http://forum.openstreetmap.org/viewtopic.php?pid=335462#p335462 I suggested the following improvement, mkgmap:country=AUT & mkgmap:city!=* & mkgmap:admin_level10=* { set mkgmap:city='${mkgmap:admin_level10|subst:Gemeinde |subst:Stadt }' } mkgmap:country=AUT & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8|subst:Gemeinde |subst:Stadt }' } Also for Germany the default rules can be improved, any ideas?

I'm using the following for Germany: # Germany = DEU mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level4=Hamburg {set mkgmap:city='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level4=Berlin {set mkgmap:city='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:region!=* & mkgmap:admin_level4=* { set mkgmap:region='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level7=* { set mkgmap:city='${mkgmap:admin_level7|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level6=* { set mkgmap:city='${mkgmap:admin_level6|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level9=* { set mkgmap:city='${mkgmap:admin_level9|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level10=* { set mkgmap:city='${mkgmap:admin_level10|subst:Gemeinde |subst:Stadt}' }

Das Thema sollte sich in DE eigentlich durch die "guten" Daten erledigt haben? ludwich Am 21.05.2013 um 12:06 schrieb Henning Scholland:
I'm using the following for Germany:
# Germany = DEU mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level4=Hamburg {set mkgmap:city='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level4=Berlin {set mkgmap:city='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:region!=* & mkgmap:admin_level4=* { set mkgmap:region='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level7=* { set mkgmap:city='${mkgmap:admin_level7|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level6=* { set mkgmap:city='${mkgmap:admin_level6|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level9=* { set mkgmap:city='${mkgmap:admin_level9|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level10=* { set mkgmap:city='${mkgmap:admin_level10|subst:Gemeinde |subst:Stadt}' }
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

On Tue, May 21, ludwich wrote:
Das Thema sollte sich in DE eigentlich durch die "guten" Daten erledigt haben?
What does "good" data help if you don't interpret them right? Thorsten
ludwich
Am 21.05.2013 um 12:06 schrieb Henning Scholland:
I'm using the following for Germany:
# Germany = DEU mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level4=Hamburg {set mkgmap:city='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level4=Berlin {set mkgmap:city='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:region!=* & mkgmap:admin_level4=* { set mkgmap:region='${mkgmap:admin_level4}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level7=* { set mkgmap:city='${mkgmap:admin_level7|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level6=* { set mkgmap:city='${mkgmap:admin_level6|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level9=* { set mkgmap:city='${mkgmap:admin_level9|subst:Gemeinde |subst:Stadt}' } mkgmap:country=DEU & mkgmap:city!=* & mkgmap:admin_level10=* { set mkgmap:city='${mkgmap:admin_level10|subst:Gemeinde |subst:Stadt}' }
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Thorsten Kukuk, Project Manager/Release Manager SLES SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)

Hi, I noticed that a small difference in the name label between the address node and the street name will result in a not found housenumber. For instance if the address has a tag addr:street="Main Street" and on OSM the highway itself is labeled with name=Mainstreet. Is it possible for mkgmap to ignore the spaces when matching the address to a nearby street?

Hi Minko, it would be possible. But I fear that this would be the start point for a bunch of rules which names match and which names do not match: Main Street MainStreet Main Str. Main St. Main main street Mein Street Str. Main Main Road ... WanMil
Hi,
I noticed that a small difference in the name label between the address node and the street name will result in a not found housenumber.
For instance if the address has a tag addr:street="Main Street" and on OSM the highway itself is labeled with name=Mainstreet. Is it possible for mkgmap to ignore the spaces when matching the address to a nearby street?
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

On Thu, May 23, 2013 at 08:28:57PM +0200, WanMil wrote:
Hi Minko,
it would be possible. But I fear that this would be the start point for a bunch of rules which names match and which names do not match:
Main Street MainStreet Main Str. Main St. Main main street Mein Street Str. Main Main Road ...
Sure about the "Mein Street"? :-) This is a bit in the "garbage in, garbage out" category. What about very similar street names, such as Mäyräkuja and Myyräkuja that are very close to each other? Or lots of $basename{tie,kuja,polku,rinne} next to each other? Or, in Estonia, you should not mix the street name suffixes tn and mnt. I wonder if there is any misspelled "nt" that could be either "mnt" (first letter missing) or "tn" (transposed). I am against automatic "correction" of the data. If this is implemented, it should be issuing warnings, and map makers should either fix or blacklist those warnings on a case-by-case basis. (By blacklisting, I mean something like "grep -vf blacklist.txt mkgmap.log.0" and adding suitable regexps to blacklist.txt to suppress bogus warnings). Best regards, Marko

+1 on no auto correct, unless it really necessary. G. "Marko Mäkelä" <marko.makela@iki.fi> wrote:
On Thu, May 23, 2013 at 08:28:57PM +0200, WanMil wrote:
Hi Minko,
it would be possible. But I fear that this would be the start point for a bunch of rules which names match and which names do not match:
Main Street MainStreet Main Str. Main St. Main main street Mein Street Str. Main Main Road ...
Sure about the "Mein Street"? :-)
This is a bit in the "garbage in, garbage out" category. What about very similar street names, such as Mäyräkuja and Myyräkuja that are very close to each other? Or lots of $basename{tie,kuja,polku,rinne} next to
each other? Or, in Estonia, you should not mix the street name suffixes
tn and mnt. I wonder if there is any misspelled "nt" that could be either "mnt" (first letter missing) or "tn" (transposed).
I am against automatic "correction" of the data. If this is implemented, it should be issuing warnings, and map makers should either fix or blacklist those warnings on a case-by-case basis. (By blacklisting, I mean something like "grep -vf blacklist.txt mkgmap.log.0" and adding suitable regexps to blacklist.txt to suppress bogus warnings).
Best regards,
Marko _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi, if you fear, there will be regular new errors, then your local community should thnk about a bot, fixing some misspellings in the data. Eg. in Germany we have a bot fixing "[sS]tr." or "[sS]trasse" to "[sS]traße". mkgmap shouldn't do there any black-box-things. This will make debugging quite hard. Henning Am 23.05.2013 20:28, schrieb WanMil:
Main Street MainStreet Main Str. Main St. Main main street Mein Street Str. Main Main Road ...

On Thu, May 23, 2013 at 02:07:00PM +0200, Minko wrote:
Hi,
I noticed that a small difference in the name label between the address node and the street name will result in a not found housenumber.
For instance if the address has a tag addr:street="Main Street" and on OSM the highway itself is labeled with name=Mainstreet. Is it possible for mkgmap to ignore the spaces when matching the address to a nearby street?
This needs to corrected in the data - Geofabrik has an excellent Adress debugging view for exactly this issue. And its even fixable in seconds. Flo -- Florian Lohoff f@zz.de

Hi, About the differences in names I agree it should be corrected on OSM. But what if mkgmap changes the name? For instance by adding ref tag in the name, the addresses are not findable anymore: highway=secondary | highway=tertiary {name '${ref|highway-symbol:oval} ${name}' | '${ref|highway-symbol:oval}' | '${name}'; add mkgmap:display_name = '${name} (${ref})' } If I remove this line from the default style, the housenumbers appear on the map. In the housenumber search, the ref tag should be ignored if added to the name tag in the styles. Tested in this area http://www.openstreetmap.org/?lat=51.837357&lon=5.86719&zoom=18&layers=M http://www.openstreetmap.org/browse/way/6871910
On Thu, May 23, 2013 at 02:07:00PM +0200, Minko wrote:
Hi,
I noticed that a small difference in the name label between the address node and the street name will result in a not found housenumber.
For instance if the address has a tag addr:street="Main Street" and on OSM the highway itself is labeled with name=Mainstreet. Is it possible for mkgmap to ignore the spaces when matching the address to a nearby street?
This needs to corrected in the data - Geofabrik has an excellent Adress debugging view for exactly this issue.
And its even fixable in seconds.
Flo -- Florian Lohoff f@zz.de
participants (8)
-
Florian Lohoff
-
Geoff Sherlock
-
Henning Scholland
-
ludwich
-
Marko Mäkelä
-
Minko
-
Thorsten Kukuk
-
WanMil