Bug in --check-roundabouts?
One user of my maps told me he was getting wrong direction instructions for most of the roundabouts in his city (Cerdanyola del Vallés, North of Barcelona). Checking roundabouts in that area I found some of them that were badly constructed (wrong direction, auto-crossing, etc.) but after fixing them the problem continued to happen. Finally I compiled the same data without --check-roundabouts and now they are routed correctly. osm data can be downloaded here: http://mapas.alternativaslibres.es/63240005.osm.gz screenshot with the wrong route: http://mapas.alternativaslibres.es/imagenes/roundabouts-wrong.png screenshot with the right route: http://mapas.alternativaslibres.es/imagenes/roundabouts-right.png The only difference between the wrong and the right routes is the --check-roundabouts option passed to mkgmap. OSM: http://www.openstreetmap.org/?lat=41.4882&lon=2.1525&zoom=13&layers=B000FTF P.S. Studying this issue I've seen there's no "junction=roundabout {add oneway = yes}" rule in the lines style file. Is it hard coded somewhere or should we add this line? Cheers, Carlos
Carlos Dávila wrote:
The only difference between the wrong and the right routes is the --check-roundabouts option passed to mkgmap.
You have to tell mkgmap wether your country is left-hand-drive or right-hand-drive. If you don't the direction of the first roundabout it encounters sets this. So if the first roundabout in your OSM file is the wrong way round all will fail.
From the documentation:
--drive-on-left --drive-on-right Explicitly specify which side of the road vehicles are expected to drive on. If neither of these options are specified, it is assumed that vehicles drive on the right unless --check-roundabouts is specified and the first roundabout processed is clockwise.
Ralf Kleineisel escribió:
Carlos Dávila wrote:
The only difference between the wrong and the right routes is the --check-roundabouts option passed to mkgmap.
You have to tell mkgmap wether your country is left-hand-drive or right-hand-drive. If you don't the direction of the first roundabout it encounters sets this. So if the first roundabout in your OSM file is the wrong way round all will fail.
OK, I'll search the logs for the guilty ones.
From the documentation:
--drive-on-left --drive-on-right Explicitly specify which side of the road vehicles are expected to drive on. If neither of these options are specified, it is assumed that vehicles drive on the right unless --check-roundabouts is specified and the first roundabout processed is clockwise.
I will run the checkround-test for spain in the next days daily .. You can find a File called spain-date.htm here http://toolserver.org/~flacus/OSM/checkround/ With this file you can fix a lot of wrong roundabouts in spain in a few days Tell it to your people Flacus
On Sun, 15 Nov 2009 23:20:13 +0100 FlaBot <flabot@googlemail.com> wrote:
I will run the checkround-test for spain in the next days daily .. You can find a File called spain-date.htm here http://toolserver.org/~flacus/OSM/checkround/ With this file you can fix a lot of wrong roundabouts in spain in a few days
Tell it to your people
Flacus _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
I looked at the GB output for that tool and its accuracy was very poor compared to the checks built in to mkgmap. YMMV. Cheers, Mark
FlaBot escribió:
I will run the checkround-test for spain in the next days daily .. You can find a File called spain-date.htm here http://toolserver.org/~flacus/OSM/checkround/ With this file you can fix a lot of wrong roundabouts in spain in a few days
Tell it to your people
I did it some months ago (talk-es)
Flacus I have used your checktouch page a lot in the past (currently not updated very often), but with roundabouts I found many of them were already fixed/wrongly detected.
Carlos
Hi Carlos,
One user of my maps told me he was getting wrong direction instructions for most of the roundabouts in his city (Cerdanyola del Vallés, North of Barcelona). Checking roundabouts in that area I found some of them that were badly constructed (wrong direction, auto-crossing, etc.) but after fixing them the problem continued to happen. Finally I compiled the same data without --check-roundabouts and now they are routed correctly. osm data can be downloaded here: http://mapas.alternativaslibres.es/63240005.osm.gz screenshot with the wrong route: http://mapas.alternativaslibres.es/imagenes/roundabouts-wrong.png screenshot with the right route: http://mapas.alternativaslibres.es/imagenes/roundabouts-right.png The only difference between the wrong and the right routes is the --check-roundabouts option passed to mkgmap. OSM: http://www.openstreetmap.org/?lat=41.4882&lon=2.1525&zoom=13&layers=B000FTF
If you don't explicitly specify --drive-on-left or --drive-on-right, it uses the direction of the first roundabout to determine the driving side and also the expected roundabout direction. So if the first roundabout it processed was the wrong direction, it would chose that as the expected direction and reverse the directions of all of the good roundabouts!
P.S. Studying this issue I've seen there's no "junction=roundabout {add oneway = yes}" rule in the lines style file. Is it hard coded somewhere or should we add this line?
You do not need to add that, it's done for you. Cheers, Mark
participants (4)
-
Carlos Dávila -
FlaBot -
Mark Burton -
Ralf Kleineisel