Commit: r2784: Clear maps after use. The tests now pass.
Version 2784 was committed by steve on Wed, 23 Oct 2013 Clear maps after use. The tests now pass.
Hi Steve, would you mind to allocate new instances instead of using clear() ? Depending on the style and parms, the collections can be quite large and thus may increase peak memory. A call to clear() doesn't free the memory for the arrays. Gerd
From: svn@mkgmap.org.uk To: mkgmap-svn@lists.mkgmap.org.uk Date: Wed, 23 Oct 2013 20:59:21 +0100 Subject: [mkgmap-dev] Commit: r2784: Clear maps after use. The tests now pass.
Version 2784 was committed by steve on Wed, 23 Oct 2013
Clear maps after use. The tests now pass. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
On 24/10/13 05:47, Gerd Petermann wrote:
would you mind to allocate new instances instead of using clear() ?
Yes that would be better. However I wondered why end() was being called twice anyway, this is surely not a good idea. So I've fixed the test to recreate the converter between each step of the test and reverted the previous change back to nulling the fields.
Depending on the style and parms, the collections can be quite large and thus may increase peak memory. A call to clear() doesn't free the memory for the arrays.
..Steve
participants (3)
-
Gerd Petermann -
Steve Ratcliffe -
svn commit