Progressing patches
I have 3 patches currently out for evaluation: mb-min-arc-length-v4.patch various tweaks related to short arcs including making remove-short-arcs enabled by default with a min arc length of 5m - could effect any map that has routing mb-extended-types-v2.patch Support the 3-byte marine/extended types - should (if not buggy) have no bad effects on maps that don't use those types. mb-zero-style-v3.patch allows styling to be done by external program - no effect on maps that don't use this feature Naturally, I believe them all to be completely sound and worthy of inclusion in mkgmap. Shall I commit them? or is more testing/discussion required? No hurry here, just seeing what people think. Cheers, Mark
--- Lun 17/8/09, Mark Burton <markb@ordern.com> ha scritto:
Da: Mark Burton <markb@ordern.com> Oggetto: [mkgmap-dev] Progressing patches A: "Development list for mkgmap" <mkgmap-dev@lists.mkgmap.org.uk> Data: Lunedì 17 agosto 2009, 01:13
I have 3 patches currently out for evaluation:
mb-min-arc-length-v4.patch various tweaks related to short arcs including making remove-short-arcs enabled by default with a min arc length of 5m - could effect any map that has routing
Hi Mark, I did not follow very well last discussions. I agree in enabling remove-short-arcs by default, but with no min length (i.e. min lenght=0). Could you please explain why arcs shorter than 5m should be collapsed? Ciao, Marco.
Naturally, I believe them all to be completely sound and worthy of inclusion in mkgmap.
Shall I commit them? or is more testing/discussion required?
No hurry here, just seeing what people think.
Cheers,
Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Marco,
Hi Mark, I did not follow very well last discussions. I agree in enabling remove-short-arcs by default, but with no min length (i.e. min lenght=0).
Could you please explain why arcs shorter than 5m should be collapsed?
Arc lengths appear to be encoded in units of 16 feet. That is equal to approx 4.8m. i.e. an arc that is less than 4.8m is encoded as length 0. So if we want all arcs to have a non-zero length, they must be at least 4.8 metres, rounding up to an integer gives 5m. Personally, I am not convinced that having zero length arcs really makes a difference. However, some people report that the minimum length needs to be greater than 0 otherwise routing is broken in some places. Cheers, Mark
Quoting Mark Burton <markb@ordern.com>:
I have 3 patches currently out for evaluation:
mb-min-arc-length-v4.patch various tweaks related to short arcs including making remove-short-arcs enabled by default with a min arc length of 5m - could effect any map that has routing
From reading posts on the list, I am not convinced everything is known about what the minimum length should be. If your patch still allows for users to test and experiment with different min lengths then I would commit it. I use a length greater than 5m, but I edit the map data by hand. I must test to see how my hand edits differ from the automatic adjustments.
mb-extended-types-v2.patch Support the 3-byte marine/extended types - should (if not buggy) have no bad effects on maps that don't use those types.
I did not try this patch, but from others reports it sounds good.
mb-zero-style-v3.patch allows styling to be done by external program - no effect on maps that don't use this feature
I tested this and it worked nicely. Its useful for me when converting from mp to osm format. I would commit it.
Naturally, I believe them all to be completely sound and worthy of inclusion in mkgmap.
Shall I commit them? or is more testing/discussion required?
No hurry here, just seeing what people think.
Cheers,
Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Garvan, Thanks for the feedback, much appreciated. Cheers, Mark On Mon, 17 Aug 2009 08:58:04 +0700 garvan.maew@online.com.kh wrote:
Quoting Mark Burton <markb@ordern.com>:
I have 3 patches currently out for evaluation:
mb-min-arc-length-v4.patch various tweaks related to short arcs including making remove-short-arcs enabled by default with a min arc length of 5m - could effect any map that has routing
From reading posts on the list, I am not convinced everything is known about what the minimum length should be. If your patch still allows for users to test and experiment with different min lengths then I would commit it. I use a length greater than 5m, but I edit the map data by hand. I must test to see how my hand edits differ from the automatic adjustments.
mb-extended-types-v2.patch Support the 3-byte marine/extended types - should (if not buggy) have no bad effects on maps that don't use those types.
I did not try this patch, but from others reports it sounds good.
mb-zero-style-v3.patch allows styling to be done by external program - no effect on maps that don't use this feature
I tested this and it worked nicely. Its useful for me when converting from mp to osm format. I would commit it.
Naturally, I believe them all to be completely sound and worthy of inclusion in mkgmap.
Shall I commit them? or is more testing/discussion required?
No hurry here, just seeing what people think.
Cheers,
Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
garvan.maew＠online.com.kh -
Marco Certelli -
Mark Burton