Hi I presume this will be most use to people who generate sea-latest.zip. I use --generate-sea=..., so using the current OSM data for the area concerned, and, before loading onto a device, look at the overview map with GPSMapEdit to check the sea has worked correctly. If the country cut has problems, eg Spain without Portugal, I use sea.z ip and again check with the overview map. If still problems, try an older or newer version of sea.zip Ticker On Sat, 2021-04-24 at 13:12 +0000, Gerd Petermann wrote:

Hi all,

just noticed that this branch was not merged because I got no feedback. A few weeks ago Eric complained about bad precomp-sea data and a lot of wasted time to find it. Any reason why nobody is interested?

Gerd

________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Donnerstag, 17. September 2020 11:34 An: Development list for mkgmap Betreff: [mkgmap-dev] Please try branch check-precomp-sea

Hi all,

I've implemented some basic checks to detect large flooded areas in the precomp-sea data in this new branch. A link to the latest binary (r4579 as of now) is a the bottom of the normal download page : http://www.mkgmap.org.uk/download/mkgmap.html

- If PrecompSeaGenerator is used to calculate the sea data and the index check fails a warning is printed and the program ends with rc -1. - If mkgmap is used with a "dubious" sea.zip one or more messages about the problematic areas are written and the program stops with an ExitException unless option --x-check-precomp-sea=0 is given before the first input file.

The index test is normally performed once for the whole planet, so it doesn't care about the actual tile boundaries. If e.g. only a part of Australia is flooded and you create a map for the UK you'll still see the errors.

BTW: The current code (also in trunk version) doesn't support to use --precomp-sea with different values. Results are rather unpredictable.

Gerd

_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Gerd, I have reproduced the issue by using the "bad precomp-sea data": - sea-latest.zip - 254.705.164 bytes - 30-03-2021 05:38 Mkgmap - Rev 4689: merge the check-precomp-sea branch to do some basic plausibilty tests on precompiled sea data. The new file sea-check.txt contains characters s (sea), m(mixed), and l(land). Each character represents one entry in the index file that comes with precompiled sea (sea.zip) with the expected result. Tiles near the coastline have m. - If PrecompSeaGenerator is used to calculate the sea data and the index check fails a warning is printed and the program ends with rc -1. - If mkgmap is used with a "dubious" sea.zip one or more messages about the problematic areas are written and the program stops with an ExitException unless option --x-check-precomp-sea=0 is given before the first input file. The index test is normally performed once for the whole planet, so it doesn't care about the actual tile boundaries. If e.g. only a part of Australia is flooded and you create a map for the UK you'll still see the errors. Mkgmap (version 4689) will stop execution after 1 second ("ExitExceptions: 1") and write to mkgmap.log: (mkgmap.log, 2.154.367, 04-05-2021 17:28) Mkgmap version 4689 Time started: Tue May 04 17:28:28 CEST 2021 SEVERE (SeaGenerator): G:\OSM_SPLITTER_Benelux\43010001.o5m: Precomp sea data seems to be wrong, land-only tile is flooded around 76.992188,103.007813, index key is 3571712_4784128 <!-- skip: 11885 lines > SEVERE (SeaGenerator): G:\OSM_SPLITTER_Benelux\43010001.o5m: Precomp sea data seems to be wrong, land-only tile is flooded around 2.460938,103.007813, index key is 98304_4784128 WARNING (global): Setting max-jobs to 4 SEVERE (global): Precomp sea data seems to be wrong. Use option --x-check-precomp-sea=0 to continue risking bad sea data. Number of ExitExceptions: 1 Time finished: Tue May 04 17:28:29 CEST 2021 Total time taken: 1 second Which is oké and does resolve the issue by using "bad precomp-sea data". Eric (AnkEric) -----Original Message----- From: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> On Behalf Of Gerd Petermann Sent: zaterdag 24 april 2021 15:13 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Please try branch check-precomp-sea Hi all, just noticed that this branch was not merged because I got no feedback. A few weeks ago Eric complained about bad precomp-sea data and a lot of wasted time to find it. Any reason why nobody is interested? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <GPetermann_muenchen@hotmail.com> Gesendet: Donnerstag, 17. September 2020 11:34 An: Development list for mkgmap Betreff: [mkgmap-dev] Please try branch check-precomp-sea Hi all, I've implemented some basic checks to detect large flooded areas in the precomp-sea data in this new branch. A link to the latest binary (r4579 as of now) is a the bottom of the normal download page : http://www.mkgmap.org.uk/download/mkgmap.html - If PrecompSeaGenerator is used to calculate the sea data and the index check fails a warning is printed and the program ends with rc -1. - If mkgmap is used with a "dubious" sea.zip one or more messages about the problematic areas are written and the program stops with an ExitException unless option --x-check-precomp-sea=0 is given before the first input file. The index test is normally performed once for the whole planet, so it doesn't care about the actual tile boundaries. If e.g. only a part of Australia is flooded and you create a map for the UK you'll still see the errors. BTW: The current code (also in trunk version) doesn't support to use --precomp-sea with different values. Results are rather unpredictable. Gerd