Hi, the OSM forum reported that Loch Ness (way 4049566) is not displayed using the default style. It is tagged as name=Loch Ness natural=water tourism=attraction The default style contains the matching rule tourism=* & area!=no & waterway!=* [0x13 resolution 24] The rule for natural=water is included from the waters style but it seems to be ordered after the rules of the default style. I guess included styles are processed last? Two questions: 1. Should the default style be changed so that natural=water supersedes the tourism tag? I think yes. 2. I remember that there have been discussions about inclusion of style. From my unexperienced view (I do not change styles very often) the current inclusion seems to be not very useful. I would prefer to have a kind of #include rule within the style file itself. Another idea would be to have a base-style-pre and base-style-post in the info file. base-style-pre would be included before the stlye whereas base-style-post would be included after the style. The unuseable location style is also an example that the current inclusion system should be improved. Is it possible to change the inclusion of styles so that it is more self-explanatory and more useful? WanMil
On Fri, Aug 24, WanMil wrote:
1. Should the default style be changed so that natural=water supersedes the tourism tag? I think yes.
I think so, too.
2. I remember that there have been discussions about inclusion of style. From my unexperienced view (I do not change styles very often) the current inclusion seems to be not very useful. I would prefer to have a kind of #include rule within the style file itself.
Absolute agree to this, and I think quite some people build maps do so, too. I know at least several people who wrote their own "include" statement by using a preprocessor before calling mkgmap. Thorsten -- Thorsten Kukuk, Project Manager/Release Manager SLES SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
The rule for natural=water is included from the waters style but it seems to be ordered after the rules of the default style. I guess included styles are processed last?
Yes, they are processed last. This makes sense often, since the earlier rule matches when there are two with the same expression. In other cases such as this one it doesn't work. I don't think there is any way to improve this, if things were different, other cases would be confusing instead. I've agreed that an inclusion mechanism would be useful, I should have time to work on it tomorrow, and I have some idea how I would implement it. ..Steve
The rule for natural=water is included from the waters style but it seems to be ordered after the rules of the default style. I guess included styles are processed last?
Yes, they are processed last. This makes sense often, since the earlier rule matches when there are two with the same expression. In other cases such as this one it doesn't work. I don't think there is any way to improve this, if things were different, other cases would be confusing instead.
Ok, I understand. It makes sense how it is implemented although in some cases it is not very intuitive. But there would be also some non intuitive cases if the other style is processed last. So this type of inclusion is implemented well but does not hit all needs.
I've agreed that an inclusion mechanism would be useful, I should have time to work on it tomorrow, and I have some idea how I would implement it.
Great! WanMil
..Steve
Hi
Ok, I understand. It makes sense how it is implemented although in some cases it is not very intuitive. But there would be also some non intuitive cases if the other style is processed last. So this type of inclusion is implemented well but does not hit all needs.
Yes, I originally only imagined it as a quick way of taking a style and adding or changing a few rules.
I've agreed that an inclusion mechanism would be useful, I should have time to work on it tomorrow, and I have some idea how I would implement it.
Great!
I'm going to create a branch 'style-include' for this. ..Steve
participants (4)
-
Chris66 -
Steve Ratcliffe -
Thorsten Kukuk -
WanMil