[Patch v1] use role=label member to place POI
Hi all, quite a lot of mp-relations have a node member with role=label. The attached patch changes the code for the --add-pois-to-areas option so that the location of this node is used for the generated POI when the name of the node and the name of the relation are equal (like with role=admin_centre) A binary is here: http://files.mkgmap.org.uk/download/268/mkgmap.jar Gerd
Hi Gerd, What happens when the relation has both role=label and role=admin_centre ? Le 20 mai 2015 à 16:41, Gerd Petermann <gpetermann_muenchen@hotmail.com> a écrit :
Hi all,
quite a lot of mp-relations have a node member with role=label.
The attached patch changes the code for the --add-pois-to-areas option so that the location of this node is used for the generated POI when the name of the node and the name of the relation are equal (like with role=admin_centre)
A binary is here: http://files.mkgmap.org.uk/download/268/mkgmap.jar
Gerd
<use-label-node-v1.patch>_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Paco, the first one that matches is used. Do you think that one should be prefered? Do you have a case where both nodes have the same name as the relation itself? Gerd From: paco.tyson@free.fr Date: Wed, 20 May 2015 16:58:45 +0200 To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI Hi Gerd, What happens when the relation has both role=label and role=admin_centre ? Le 20 mai 2015 à 16:41, Gerd Petermann <gpetermann_muenchen@hotmail.com> a écrit :Hi all, quite a lot of mp-relations have a node member with role=label. The attached patch changes the code for the --add-pois-to-areas option so that the location of this node is used for the generated POI when the name of the node and the name of the relation are equal (like with role=admin_centre) A binary is here: http://files.mkgmap.org.uk/download/268/mkgmap.jar Gerd <use-label-node-v1.patch>_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Gerd, I don't really have an opinion on which one should be preferred, I was just asking out of curiosity. The first matching means the first in the list of objects linked to the relation, am I right ? I have seen label used in the past, I can't guarantee you that both were set but as usual with OSM, we can't eliminate this combination. Paco Le 20 mai 2015 à 17:07, Gerd Petermann <gpetermann_muenchen@hotmail.com> a écrit :
Hi Paco,
the first one that matches is used. Do you think that one should be prefered? Do you have a case where both nodes have the same name as the relation itself?
Gerd
From: paco.tyson@free.fr Date: Wed, 20 May 2015 16:58:45 +0200 To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI
Hi Gerd,
What happens when the relation has both role=label and role=admin_centre ?
Le 20 mai 2015 à 16:41, Gerd Petermann <gpetermann_muenchen@hotmail.com> a écrit :
Hi all,
quite a lot of mp-relations have a node member with role=label.
The attached patch changes the code for the --add-pois-to-areas option so that the location of this node is used for the generated POI when the name of the node and the name of the relation are equal (like with role=admin_centre)
A binary is here: http://files.mkgmap.org.uk/download/268/mkgmap.jar
Gerd
<use-label-node-v1.patch>_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing listmkgmap-dev@lists.mkgmap.org.ukhttp://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I found the case I was talking about, it's the relation for France ( http://www.openstreetmap.org/relation/2202162 ) Paco. ----- Mail original ----- De: "Gerd Petermann" <gpetermann_muenchen@hotmail.com> À: mkgmap-dev@lists.mkgmap.org.uk Envoyé: Mercredi 20 Mai 2015 17:07:32 Objet: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI Hi Paco, the first one that matches is used. Do you think that one should be prefered? Do you have a case where both nodes have the same name as the relation itself? Gerd From: paco.tyson@free.fr Date: Wed, 20 May 2015 16:58:45 +0200 To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI Hi Gerd, What happens when the relation has both role=label and role=admin_centre ? Le 20 mai 2015 à 16:41, Gerd Petermann < gpetermann_muenchen@hotmail.com > a écrit : Hi all, quite a lot of mp-relations have a node member with role=label. The attached patch changes the code for the --add-pois-to-areas option so that the location of this node is used for the generated POI when the name of the node and the name of the relation are equal (like with role=admin_centre) A binary is here: http://files.mkgmap.org.uk/download/268/mkgmap.jar Gerd <use-label-node-v1.patch> _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Paco, no problem here, the admin_centre is Paris, so only the label node matches the name of the boundary. Gerd
Date: Thu, 28 May 2015 15:10:46 +0200 From: paco.tyson@free.fr To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI
Hi Gerd,
I found the case I was talking about, it's the relation for France ( http://www.openstreetmap.org/relation/2202162 )
Paco.
----- Mail original ----- De: "Gerd Petermann" <gpetermann_muenchen@hotmail.com> À: mkgmap-dev@lists.mkgmap.org.uk Envoyé: Mercredi 20 Mai 2015 17:07:32 Objet: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI
Hi Paco,
the first one that matches is used. Do you think that one should be prefered? Do you have a case where both nodes have the same name as the relation itself?
Gerd
From: paco.tyson@free.fr Date: Wed, 20 May 2015 16:58:45 +0200 To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI
Hi Gerd,
What happens when the relation has both role=label and role=admin_centre ?
Le 20 mai 2015 à 16:41, Gerd Petermann < gpetermann_muenchen@hotmail.com > a écrit :
Hi all,
quite a lot of mp-relations have a node member with role=label.
The attached patch changes the code for the --add-pois-to-areas option so that the location of this node is used for the generated POI when the name of the node and the name of the relation are equal (like with role=admin_centre)
A binary is here: http://files.mkgmap.org.uk/download/268/mkgmap.jar
Gerd
<use-label-node-v1.patch> _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
jHi Gerd, see the error with this binary, I had to use the --going to proceed ______________________ Time started: Wed May 20 23:01:32 BRT 2015 java.lang.NullPointerException at uk.me.parabola.mkgmap.reader.osm.POIGeneratorHook.addPOIsToMPs(POIGen eratorHook.java:388) at uk.me.parabola.mkgmap.reader.osm.POIGeneratorHook.end(POIGeneratorHoo k.java:162) at uk.me.parabola.mkgmap.reader.osm.OsmReadingHooksChain.end(OsmReadingH ooksChain.java:79) at uk.me.parabola.mkgmap.reader.osm.bin.OsmBinMapDataSource.load(OsmBinM apDataSource.java:63) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSour ce.java:129) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:255) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:251) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Exiting - if you want to carry on regardless, use the --keep-going option Number of ExitExceptions: 1 _______________________________________________________________________________________________________ Anor C. A. de Souza Concórdia SC 49-8866-3290 Claro49-8808-4963 Vivo49-9975-2560 Tim From: paco.tyson@free.fr Date: Wed, 20 May 2015 16:58:45 +0200 To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] use role=label member to place POI Hi Gerd, What happens when the relation has both role=label and role=admin_centre ? Le 20 mai 2015 à 16:41, Gerd Petermann <gpetermann_muenchen@hotmail.com> a écrit :Hi all, quite a lot of mp-relations have a node member with role=label. The attached patch changes the code for the --add-pois-to-areas option so that the location of this node is used for the generated POI when the name of the node and the name of the relation are equal (like with role=admin_centre) A binary is here: http://files.mkgmap.org.uk/download/268/mkgmap.jar Gerd <use-label-node-v1.patch>_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (4)
-
A. Carlos -
Gerd Petermann -
Paco Tyson -
paco.tyson＠free.fr