Re : [PATCH v1] Multipolygon: do not remove ways that completely, contain the bounding box (WanMil)
Hello Wanmil, I tried your patch and it did not work for me. As Steve pointed out the problem, I commented all the code of the patched removeWaysOutsideBox() and the sea multipolygon is generated as expected. I don't know if it is linked but there are still some artefacts which appear in Mapsource and GPS display depending on zoom level and visible in all detail levels. These artefacts are horizontal or vertical holes between pieces of lands (islands) and/or map border (tested with latest mkgmap and ireland.osm from geofabrik.de 2010/02/07, generate-sea=multipolygon,close-gap=1000 and default style). Cheers, David PS : thank you Steve
Hello Wanmil,
I tried your patch and it did not work for me. As Steve pointed out the problem, I commented all the code of the patched removeWaysOutsideBox() and the sea multipolygon is generated as expected. I don't know if it is linked but there are still some artefacts which appear in Mapsource and GPS display depending on zoom level and visible in all detail levels. These artefacts are horizontal or vertical holes between pieces of lands (islands) and/or map border (tested with latest mkgmap and ireland.osm from geofabrik.de 2010/02/07, generate-sea=multipolygon,close-gap=1000 and default style).
Cheers, David
PS : thank you Steve
David, thanks for your feedback. I don't have time to investigate this today but I will do within the next days. WanMil
Hello Wanmil,
I tried your patch and it did not work for me. As Steve pointed out the problem, I commented all the code of the patched removeWaysOutsideBox() and the sea multipolygon is generated as expected. I don't know if it is linked but there are still some artefacts which appear in Mapsource and GPS display depending on zoom level and visible in all detail levels. These artefacts are horizontal or vertical holes between pieces of lands (islands) and/or map border (tested with latest mkgmap and ireland.osm from geofabrik.de 2010/02/07, generate-sea=multipolygon,close-gap=1000 and default style).
Cheers, David
PS : thank you Steve
David,
thanks for your feedback. I don't have time to investigate this today but I will do within the next days.
WanMil
In v1 latitude and longitude were interchanged. I've tested the patch against the ireland map and it worked for me. WanMil
participants (2)
-
David -
WanMil