Raise an error when levels and dem-dists mismatch

Hi all, I've debugged the past two days why a custom map won't be recognized by my Garmin Oregon 700 device. The issue was the dem configuration. My style uses this level mapping: levels = 0:24, 1:22, 2:20, 3:18, 4:16 While my dem distribution line was: dem-dists=3312,6624,9936,13248,16560,19872,23184,26496 So there are only 5 levels defined, but the distribution maps to 8. (I copied the dem-dists line from Freizeitkarte-style without thinking about it...) The build process was successfully, but the map was never listed in the device map selection. After fixing the level mapping in the style/option file, the map gets listed. So may I ask to add a check/exception to prevent building maps when there is a mismatch between levels vs. dem-dists? Thank you! -- Best regards / Mit freundlichen Grüßen Daniel Vogelbacher

Hi Daniel, thanks for your post. I think there is no problem when the number of dem-dists is smaller than the number of levels. Can you confirm that? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Daniel Vogelbacher <daniel@vogelbacher.name> Gesendet: Sonntag, 10. Juli 2022 17:34 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Raise an error when levels and dem-dists mismatch Hi all, I've debugged the past two days why a custom map won't be recognized by my Garmin Oregon 700 device. The issue was the dem configuration. My style uses this level mapping: levels = 0:24, 1:22, 2:20, 3:18, 4:16 While my dem distribution line was: dem-dists=3312,6624,9936,13248,16560,19872,23184,26496 So there are only 5 levels defined, but the distribution maps to 8. (I copied the dem-dists line from Freizeitkarte-style without thinking about it...) The build process was successfully, but the map was never listed in the device map selection. After fixing the level mapping in the style/option file, the map gets listed. So may I ask to add a check/exception to prevent building maps when there is a mismatch between levels vs. dem-dists? Thank you! -- Best regards / Mit freundlichen Grüßen Daniel Vogelbacher

Hi Gerd, yes, I can confirm that a smaller dem-dists count is no problem. So I change my request to a validity check for dem-dists-levels <= levels. On 7/11/22 14:00, Gerd Petermann wrote:
Hi Daniel,
thanks for your post. I think there is no problem when the number of dem-dists is smaller than the number of levels. Can you confirm that?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Daniel Vogelbacher <daniel@vogelbacher.name> Gesendet: Sonntag, 10. Juli 2022 17:34 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Raise an error when levels and dem-dists mismatch
Hi all,
I've debugged the past two days why a custom map won't be recognized by my Garmin Oregon 700 device. The issue was the dem configuration. My style uses this level mapping:
levels = 0:24, 1:22, 2:20, 3:18, 4:16
While my dem distribution line was:
dem-dists=3312,6624,9936,13248,16560,19872,23184,26496
So there are only 5 levels defined, but the distribution maps to 8. (I copied the dem-dists line from Freizeitkarte-style without thinking about it...)
The build process was successfully, but the map was never listed in the device map selection. After fixing the level mapping in the style/option file, the map gets listed.
So may I ask to add a check/exception to prevent building maps when there is a mismatch between levels vs. dem-dists? Thank you!
-- Best regards / Mit freundlichen Grüßen Daniel Vogelbacher _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Daniel, OK, I've added a corresponding check in r4905. Hope the error message is clear enough? With your example I see now: SCHWERWIEGEND (global): More dem-dist values than levels: [3312, 6624, 9936, 13248, 16560, 19872, 23184, 26496] [L4 B16, L3 B18, L2 B20, L1 B22, L0 B24] (thrown in MapBuilder.buildDem()) ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Daniel Vogelbacher <daniel@vogelbacher.name> Gesendet: Dienstag, 12. Juli 2022 18:19 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Raise an error when levels and dem-dists mismatch Hi Gerd, yes, I can confirm that a smaller dem-dists count is no problem. So I change my request to a validity check for dem-dists-levels <= levels. On 7/11/22 14:00, Gerd Petermann wrote:
Hi Daniel,
thanks for your post. I think there is no problem when the number of dem-dists is smaller than the number of levels. Can you confirm that?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Daniel Vogelbacher <daniel@vogelbacher.name> Gesendet: Sonntag, 10. Juli 2022 17:34 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Raise an error when levels and dem-dists mismatch
Hi all,
I've debugged the past two days why a custom map won't be recognized by my Garmin Oregon 700 device. The issue was the dem configuration. My style uses this level mapping:
levels = 0:24, 1:22, 2:20, 3:18, 4:16
While my dem distribution line was:
dem-dists=3312,6624,9936,13248,16560,19872,23184,26496
So there are only 5 levels defined, but the distribution maps to 8. (I copied the dem-dists line from Freizeitkarte-style without thinking about it...)
The build process was successfully, but the map was never listed in the device map selection. After fixing the level mapping in the style/option file, the map gets listed.
So may I ask to add a check/exception to prevent building maps when there is a mismatch between levels vs. dem-dists? Thank you!
-- Best regards / Mit freundlichen Grüßen Daniel Vogelbacher _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Gerd, thank you very much for the patch. This is exactly what I'm was looking for :) On 7/13/22 07:22, Gerd Petermann wrote:
Hi Daniel,
OK, I've added a corresponding check in r4905. Hope the error message is clear enough? With your example I see now: SCHWERWIEGEND (global): More dem-dist values than levels: [3312, 6624, 9936, 13248, 16560, 19872, 23184, 26496] [L4 B16, L3 B18, L2 B20, L1 B22, L0 B24] (thrown in MapBuilder.buildDem())
ciao, Gerd
-- Best regards / Mit freundlichen Grüßen Daniel Vogelbacher
participants (2)
-
Daniel Vogelbacher
-
Gerd Petermann