Mark Burton wrote:

Hi Felix,

...

Are you sure that 80 is the critical limit?

Of course not!

...

I found somewhere on the net 94-96 as critical limit (and have been using 94 since) - badly I can't find that document anymore. Was on some Russian site about cgpsmapper.

Twould be easily testable by just running against a testmap on which one increases the points in a way until it crashes.

On the map I was testing today, 80 was OK 83 caused errors.

I just tried a way with ~240 nodes (using max 300) and it routed perfectly fine. I think we can actually safely incease this value.... max 80 did degrade routing over long distances (though I don't think there are many ways with more than 200 nodes without intersection or change in attributes (routing works without any probs on this testmap): find attached map base as osm.

Cheers,

Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Mark Burton wrote:

Hi Felix,

...

I just tried a way with ~240 nodes (using max 300) and it routed perfectly fine. I think we can actually safely incease this value.... max 80 did degrade routing over long distances (though I don't think there are many ways with more than 200 nodes without intersection or change in attributes (routing works without any probs on this testmap): find attached map base as osm.

Yes, I know that many ways that have lots of points route perfectly OK so it's not the number of points per se that is causing the routing issue. However, restricting the number of points an arc can have does fix the routing issue that has been reported to me.

So in the long term, we probably don't need to limit the number of points in an arc but until we know what the real issue is here, it's the only way of fixing a particular routing problem that someone is having with their map.

You probably saw my reply to Chris just now, it contains a patch that should make a better job of limiting the number of points per arc. Could you be so kind as to try it out and report any goodness/badness?

Makes routing over long distances no better, I am on some routes able to get routed over 1 or 2 additional turns when using max nodes 250! I still achieve best results by simply setting max nodes to 250 (which I assume of being quite save, yet sufficient). As testmaps with streets longer than 260 points (using max 300) caused no probs, I am pretty sure problem lies somewhere else

Cheers,

Mark _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Felix,

Using your patch but setting the values to: private final int MAX_POINTS_IN_WAY = 300; private final int MAX_POINTS_IN_ARC = 200;

private final int MAX_NODES_IN_WAY = 64;

Gave me the best results so far, is there any reason why max_nodes_in_way is set to 16?

Yes, in the past, some maps failed to route when more nodes than that were in a way.

Increasing it to 64 really improved routing over long distances (by about 2-3 additional turns).

What do you mean by 2-3 additional turns? It may be that when the real problem is understood and fixed, these limits can be revised. Cheers, Mark

Here is some changes to the help - options documentation. If it is OK will someone (I suppose Steve / Mark) please commit it? It is my first patch, so please advice where necessary Groete BennieD Steve, Is the zipped forum archives broken, or just avaialable to a select few? I know it was discussed earlier, but I think you were away at the time? I could not surmise from the previous discussion exactly what the cause / solution was? ##################################################################################### Scanned by MailMarshal - Marshal's comprehensive email content security solution. Download a free evaluation of MailMarshal at www.marshal.com #####################################################################################

Thanks Charlie, Although it's not the ideal solution it already helps a bit. Ideal would be to do extensive searching, offline, leisurely;) -----Original Message----- From: charlie@cferrero.net [mailto:charlie@cferrero.net] Sent: 10 November 2009 11:46 AM To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Help Options patch Quoting "Du Plessis, Bennie" <Bennie.DuPlessis@sappi.com>:

Steve,

Is the zipped forum archives broken, or just avaialable to a select few?

I know it was discussed earlier, but I think you were away at the

time?

I could not surmise from the previous discussion exactly what the

cause

/ solution was?

Bennie, While the zipped archives are unavailable, I'd recommend using Google to search the archive. Specifically, enter the following into Google: [your search terms] site:http://www.mkgmap.org.uk/pipermail/mkgmap-dev/ e.g. tweeze site:http://www.mkgmap.org.uk/pipermail/mkgmap-dev/ "garmin yellow" site:http://www.mkgmap.org.uk/pipermail/mkgmap-dev/ etc Obviously this is only of use if you know roughly what you're looking for. -- Charlie The opinions contained in this message are those of the sender only and do not reflect those of Sappi Limited or any of its subsidiary or associated companies. "This message, including any attachment(s), may contain information which is private, privileged or confidential and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient of this message, please notify the sender thereof and destroy/delete the message. Neither the sender nor Sappi Limited (including its subsidiaries and associated companies, jointly referred to as 'Sappi') shall incur any liability resulting directly or indirectly from accessing any of the attached files which may contain a virus or the like. Any opinions, statements, conclusions and other information contained in this message and/or its attachment(s) that do not relate or refer to the official business of Sappi Limited or any of its subsidiary or associated companies shall be regarded as neither provided nor approved by any Sappi company. Views expressed in this message or its attachment(s) may not necessarily be those of Sappi and Sappi cannot be held liable for any direct or indirect loss or injury resulting from the contents of a message and/or its attachments." Directors names A list of Sappi companies and the names of their directors can be retrieved from http://www.sappi.com/SappiWeb/Investor+info/Corporate+governance/Board+resum... ##################################################################################### Scanned by MailMarshal - Marshal's comprehensive email content security solution. Download a free evaluation of MailMarshal at www.marshal.com #####################################################################################

Hi Nakor,

...

Well, today's commit to limit the number of points in a way appears to have fixed that issue as well.

Good news indeed. I'll try this next time I update my maps and let you know.

I got it wrong. I tested with a smaller OSM file and the problem doesn't appear with that but if I use the full tile that you supplied, the problem still exists. Sorry to raise your hopes. As recompense I will put more time into trying to find what the real problem is. Cheers, Mark