[PATCH] Add way link to "contains zero length arc" output

Hello Ævar,
This helps me debug potential zero length arc issues.
How about the attached patch based on your idea, does that give you the info you need? It actually makes the code smaller rather than adding to it! If it's OK for you, I can commit that. Cheers, Mark

On Tue, Feb 16, 2010 at 23:17, Mark Burton <markb@ordern.com> wrote:
Hello Ævar,
This helps me debug potential zero length arc issues.
How about the attached patch based on your idea, does that give you the info you need?
It actually makes the code smaller rather than adding to it!
If it's OK for you, I can commit that.
Unless you have another patch that modifies the toOSMUR() function to print a /browse/way/* link in addition to the bbox link it currently prints that doesn't give me the info I need. The idea was to not have to copy/paste the ID that was printed into a manually constructed URL that I'd have to make.

Hi,
Unless you have another patch that modifies the toOSMUR() function to print a /browse/way/* link in addition to the bbox link it currently prints that doesn't give me the info I need. The idea was to not have to copy/paste the ID that was printed into a manually constructed URL that I'd have to make.
Hmm, bit confused now as the RoadDef toString() class does (should) include the browse blurb when processing OSM input. Are you using MP input? If so, you must call the showOSMBrowseURL() for the RoadDef. I didn't do that before because when using MP input, it's not obvious that the road id is an OSM when processing MP input. Mark

Hello Ævar, Please try this version, it should now print the browse URL whether the road is from OSM input or MP input. Mark

On Thu, Feb 18, 2010 at 20:41, Mark Burton <markb@ordern.com> wrote:
Hello Ævar,
Have you tried this patch? Did it perform OK? If so, I will commit it.
Yes, thanks. It works fine: SEVERE (RoadNetwork): /var/www/osm.nix.is/archive/2010-02-18/Iceland.osm: Road (http://www.openstreetmap.org/browse/way/44463609) contains zero length arc at http://www.openstreetmap.org/?mlat=64.12497&mlon=-21.75756&zoom=17 SEVERE (RoadNetwork): /var/www/osm.nix.is/archive/2010-02-18/Iceland.osm: Road (http://www.openstreetmap.org/browse/way/38675480) contains zero length arc at http://www.openstreetmap.org/?mlat=65.67507&mlon=-18.09360&zoom=17
participants (2)
-
Mark Burton
-
Ævar Arnfjörð Bjarmason