[PATCH v1] - drive on left + roundabout direction checking
As suggested, moved from rhd to dol. Two options are now available --drive-on-left and --drive-on-right. By default, you should not have to specify either because mkgmap now determines the side of the road to drive on from the direction of the first roundabout it processes. But if you don't like its choice, you can specify one of these options to override it. Also, it now issues a warning for each roundabout it finds that appears to go in the wrong direction. I just got 720 warnings when I processed the GB map so either there is a problem with the code or there is a lot of duff roundabouts. I checked a handful of them and they were all wrong. Please give it a go and if you find any of the warnings to be wrong, please post the OSM URL of the roundabout in question. Mark
2009/9/27 Mark Burton <markb@ordern.com>:
Also, it now issues a warning for each roundabout it finds that appears to go in the wrong direction. I just got 720 warnings when I processed the GB map so either there is a problem with the code or there is a lot of duff roundabouts. I checked a handful of them and they were all wrong.
Hi Mark, I've tried this on my map of Ireland and it works fine. Unexpectedly, though, I see _no_ errors for wrong way roundabouts. One theory is that our roundabouts are all pointing the right way... Is there any verbose mode I need to have on to see these? Dermot -- -------------------------------------- Iren sind menschlich
Hi Dermot,
I've tried this on my map of Ireland and it works fine. Unexpectedly, though, I see _no_ errors for wrong way roundabouts. One theory is that our roundabouts are all pointing the right way...
Hmm, that would be rather amazing.
Is there any verbose mode I need to have on to see these?
The warnings are output using the standard mkgmap logging mechanism so you may have it configured to only show errors. You can configure the logging by adding -Dlog.config=logging.properties to your java command line. This is a java option not a mkgmap option. Below is the current contents of my logging.properties file. It changes often as I focus on different parts of the code. Cheers, Mark --------- # The default level FINE, WARNING, INFO, SEVERE .level=WARNING #.level=INFO #handlers: java.util.logging.ConsoleHandler handlers: java.util.logging.FileHandler java.util.logging.ConsoleHandler # package or class name with .level appended and then the level #uk.me.parabola.mkgmap.main.Main.level=FINE #uk.me.parabola.mkgmap.general.RoadNetwork.level=INFO #uk.me.parabola.mkgmap.general.MapLine.level=INFO #uk.me.parabola.mkgmap.main.Main.level=INFO #uk.me.parabola.mkgmap.main.MapMaker.level=INFO #uk.me.parabola.mkgmap.osmstyle.StyledConverter.level=INFO #uk.me.parabola.mkgmap.reader.osm.xml.level=INFO #uk.me.parabola.mkgmap.build.MapBuilder.level=WARNING #uk.me.parabola.mkgmap.build.level=WARNING #uk.me.parabola.mkgmap.reader.osm.RestrictionRelation.level=INFO #uk.me.parabola.mkgmap.reader.osm.level=INFO #uk.me.parabola.imgfmt.app.net.RouteArc.level=INFO #uk.me.parabola.imgfmt.app.net.NOD1Part.level=FINE #uk.me.parabola.mkgmap.build.MapSplitter.level=INFO #WARNING # For ConsoleHandler java.util.logging.ConsoleHandler.level=WARNING java.util.logging.ConsoleHandler.formatter=uk.me.parabola.log.UsefulFormatter # For FileHandler java.util.logging.FileHandler.level=FINE java.util.logging.FileHandler.formatter=uk.me.parabola.log.UsefulFormatter java.util.logging.FileHandler.limit=5000000 java.util.logging.FileHandler.count=4 java.util.logging.FileHandler.pattern=mkgmap.log java.util.logging.FileHandler.append=false
participants (2)
-
Dermot McNally -
Mark Burton