Commit r4245: correction: if precomp--sea option is used, closed ways with the tag natural=coastline where only processed as lines, not as polygons.
Version mkgmap-r4245 was committed by gerd on Fri, 19 Oct 2018 correction: if precomp--sea option is used, closed ways with the tag natural=coastline where only processed as lines, not as polygons. The code in SeaGenerator creates a copy of the original way, but it doesn't copy the tags, only the geometry. The copy has only two tags: mkgmap:removed_natural=coastline, mkgmap:stylefilter=polygon The problem is that the code also adds the tag mkgmap:stylefilter=polyline to the original way, so that it is not processed as a polygon. Now the original tags are copied, the natural tag is changed as shown above and mkgmap:stylefilter=polygon is added so that the copy is only processed by the polygon rules. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4245
Hi all, I wonder why nobody noticed this error before. In areas with many islands I'd expect quite a massive change when all the additional polygons are rendered. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von svn commit <svn@mkgmap.org.uk> Gesendet: Freitag, 19. Oktober 2018 07:22 An: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Commit r4245: correction: if precomp--sea option is used, closed ways with the tag natural=coastline where only processed as lines, not as polygons. Version mkgmap-r4245 was committed by gerd on Fri, 19 Oct 2018 correction: if precomp--sea option is used, closed ways with the tag natural=coastline where only processed as lines, not as polygons. The code in SeaGenerator creates a copy of the original way, but it doesn't copy the tags, only the geometry. The copy has only two tags: mkgmap:removed_natural=coastline, mkgmap:stylefilter=polygon The problem is that the code also adds the tag mkgmap:stylefilter=polyline to the original way, so that it is not processed as a polygon. Now the original tags are copied, the natural tag is changed as shown above and mkgmap:stylefilter=polygon is added so that the copy is only processed by the polygon rules. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4245 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hello Gerd, Thx again, problem solved with 4245 ! I was using the old 4244 Actually I encountered it already almost a year ago for my trip to Norway (lot of islands) but because 99 times out of 100 it's the draworder , bugs in the style file, outdated osm data, 'wrong' --options, outdated mkgmap.jar 😊 etcetera, that I did not yet felt comfortable enough asking for help. It works better and better every build. I don't have proof but since somewhere June I also think my maps are more stable when routing on my Oregon. Kind regards Joris -----Oorspronkelijk bericht----- Van: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> Namens Gerd Petermann Verzonden: vrijdag 19 oktober 2018 07:28 Aan: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Onderwerp: Re: [mkgmap-dev] Commit r4245: correction: if precomp--sea option is used, closed ways with the tag natural=coastline where only processed as lines, not as polygons. Hi all, I wonder why nobody noticed this error before. In areas with many islands I'd expect quite a massive change when all the additional polygons are rendered. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von svn commit <svn@mkgmap.org.uk> Gesendet: Freitag, 19. Oktober 2018 07:22 An: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] Commit r4245: correction: if precomp--sea option is used, closed ways with the tag natural=coastline where only processed as lines, not as polygons. Version mkgmap-r4245 was committed by gerd on Fri, 19 Oct 2018 correction: if precomp--sea option is used, closed ways with the tag natural=coastline where only processed as lines, not as polygons. The code in SeaGenerator creates a copy of the original way, but it doesn't copy the tags, only the geometry. The copy has only two tags: mkgmap:removed_natural=coastline, mkgmap:stylefilter=polygon The problem is that the code also adds the tag mkgmap:stylefilter=polyline to the original way, so that it is not processed as a polygon. Now the original tags are copied, the natural tag is changed as shown above and mkgmap:stylefilter=polygon is added so that the copy is only processed by the polygon rules. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4245 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
Gerd Petermann -
Joris Bo -
svn commit