[PATCH v1] mp improved tag handling
Current mp implementation does not remove polygon tags from unclosed ways. I have observed that the unclosed polygons sometimes are closed in a later step of mkgmap. This causes flooding of areas around seas. Finnland is a great test area for this. Attached patch removes all polygon tags from ways that are used in multipolygons. WanMil
On Thu, Jan 28, 2010 at 08:56:42PM +0100, WanMil wrote:
Current mp implementation does not remove polygon tags from unclosed ways. I have observed that the unclosed polygons sometimes are closed in a later step of mkgmap. This causes flooding of areas around seas. Finnland is a great test area for this.
Thanks for testing Finland, WanMil! Please wake me up when it mostly works, and I will enable generate-sea for my map, and flood you with further bug reports if needed. :-)
Attached patch removes all polygon tags from ways that are used in multipolygons.
I am happy to commit it for you, if someone gives positive feedback first. Or perhaps Mark can test and commit it? Marko
Marko,
On Thu, Jan 28, 2010 at 08:56:42PM +0100, WanMil wrote:
Current mp implementation does not remove polygon tags from unclosed ways. I have observed that the unclosed polygons sometimes are closed in a later step of mkgmap. This causes flooding of areas around seas. Finnland is a great test area for this.
Thanks for testing Finland, WanMil! Please wake me up when it mostly works, and I will enable generate-sea for my map, and flood you with further bug reports if needed. :-)
What happens if you use polygons rather than multipolygon for the sea generation? If it still floods with polygons, the problem is in the sea code, not in MP code.
Attached patch removes all polygon tags from ways that are used in multipolygons.
I am happy to commit it for you, if someone gives positive feedback first. Or perhaps Mark can test and commit it?
I will be happy to commit it when I understand what it does, I will look at it soon. Mark
Marko,
On Thu, Jan 28, 2010 at 08:56:42PM +0100, WanMil wrote:
Current mp implementation does not remove polygon tags from unclosed ways. I have observed that the unclosed polygons sometimes are closed in a later step of mkgmap. This causes flooding of areas around seas. Finnland is a great test area for this.
Thanks for testing Finland, WanMil! Please wake me up when it mostly works, and I will enable generate-sea for my map, and flood you with further bug reports if needed. :-)
What happens if you use polygons rather than multipolygon for the sea generation? If it still floods with polygons, the problem is in the sea code, not in MP code.
That statement heals my mp coders soul ;-))
Attached patch removes all polygon tags from ways that are used in multipolygons.
I am happy to commit it for you, if someone gives positive feedback first. Or perhaps Mark can test and commit it?
I will be happy to commit it when I understand what it does, I will look at it soon.
It removes all tags known as polygon tags (natural, boundary, landuse ...) from the original non closed ways. WanMil
On Thu, Jan 28, 2010 at 08:07:56PM +0000, Mark Burton wrote:
What happens if you use polygons rather than multipolygon for the sea generation? If it still floods with polygons, the problem is in the sea code, not in MP code.
It floods. I can't remember if I ever tried generate-sea with the MP code. Maybe I should try it now, because it should be faster. I am seeing natural=forest islands on sea around my residence. The flooded areas differ depending on the zoom level. With today's mkgmap, it looks roughly the same as it did a few weeks ago. One notable exception is that the middle tile (starting in Jyväskylä) is almost completely flooded now. Mark, can you please download my scripts from http://www.polkupyoraily.net/osm/ and try it yourself? Just add --generate-sea=polygons to the mkgmap options. Marko
participants (3)
-
Mark Burton -
Marko Mäkelä -
WanMil