Hi Gerd, please find attached a patch that makes some minor improvements to the documentation. Please review and commit if OK. Cheers, Mike
Hi Mike, thanks for the patch. I am not sure if I like the part for coastlines. I'm not 100% sure but I think the tag natural=coastline is really just removed before the OSM way is processed by the style rules. A way with more than a natural=coastline tag is still processed. That's very different to being "ignored", isn't it? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 31. Dezember 2020 16:14 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch Hi Gerd, please find attached a patch that makes some minor improvements to the documentation. Please review and commit if OK. Cheers, Mike
HI Gerd, Thanks for the quick response. My issue with the existing wording is that it reads as if the input files are actually being modified. I'd be happy with "filtered out" or "are not loaded from the input OSM files". (Just noticed it actually says OSM tiles rather than OSM files in the first mention, so I think that needs changing as well.) Do either of the two suggestions seem better to you? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 02 January 2021 09:53 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Minor documentation patch Hi Mike, thanks for the patch. I am not sure if I like the part for coastlines. I'm not 100% sure but I think the tag natural=coastline is really just removed before the OSM way is processed by the style rules. A way with more than a natural=coastline tag is still processed. That's very different to being "ignored", isn't it? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 31. Dezember 2020 16:14 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch Hi Gerd, please find attached a patch that makes some minor improvements to the documentation. Please review and commit if OK. Cheers, Mike
Hi Mike & Gerd I'd suggest something like: ... When this option is specified the land and sea polygons are derived from the given precompiled data rather than the natural=coastline ways from the input OSM files. ... The coastline ways not removed or modified, leaving it up the style to decide to render then as lines. However --coastlinefile is different and doesn't pass them on Ticker On Sat, 2021-01-02 at 17:43 +0000, Mike Baggaley wrote:
HI Gerd,
Thanks for the quick response. My issue with the existing wording is that it reads as if the input files are actually being modified. I'd be happy with "filtered out" or "are not loaded from the input OSM files". (Just noticed it actually says OSM tiles rather than OSM files in the first mention, so I think that needs changing as well.) Do either of the two suggestions seem better to you?
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 02 January 2021 09:53 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Minor documentation patch
Hi Mike,
thanks for the patch. I am not sure if I like the part for coastlines. I'm not 100% sure but I think the tag natural=coastline is really just removed before the OSM way is processed by the style rules. A way with more than a natural=coastline tag is still processed. That's very different to being "ignored", isn't it?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 31. Dezember 2020 16:14 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch
Hi Gerd, please find attached a patch that makes some minor improvements to the documentation.
Please review and commit if OK.
Cheers, Mike
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Parts of what I said is not quite correct (I was looking at my modified version of SeaGenerator). The suggested wording for doc/options.txt is ok. However the trunk SeaGenerator.java does manipulate the coastline way but it is still available for rendering by the style. With option --coastlinefile, no manipulation takes place. Ticker On Sat, 2021-01-02 at 18:09 +0000, Ticker Berkin wrote:
Hi Mike & Gerd
I'd suggest something like: ... When this option is specified the land and sea polygons are derived from the given precompiled data rather than the natural=coastline ways from the input OSM files. ...
The coastline ways not removed or modified, leaving it up the style to decide to render then as lines.
However --coastlinefile is different and doesn't pass them on
Ticker On Sat, 2021-01-02 at 17:43 +0000, Mike Baggaley wrote:
HI Gerd,
Thanks for the quick response. My issue with the existing wording is that it reads as if the input files are actually being modified. I'd be happy with "filtered out" or "are not loaded from the input OSM files". (Just noticed it actually says OSM tiles rather than OSM files in the first mention, so I think that needs changing as well.) Do either of the two suggestions seem better to you?
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 02 January 2021 09:53 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Minor documentation patch
Hi Mike,
thanks for the patch. I am not sure if I like the part for coastlines. I'm not 100% sure but I think the tag natural=coastline is really just removed before the OSM way is processed by the style rules. A way with more than a natural=coastline tag is still processed. That's very different to being "ignored", isn't it?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 31. Dezember 2020 16:14 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch
Hi Gerd, please find attached a patch that makes some minor improvements to the documentation.
Please review and commit if OK.
Cheers, Mike
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Ticker, not sure what to do now. Do you think i should commit Mikes patch without changes? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Montag, 4. Januar 2021 15:52 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Minor documentation patch Hi Parts of what I said is not quite correct (I was looking at my modified version of SeaGenerator). The suggested wording for doc/options.txt is ok. However the trunk SeaGenerator.java does manipulate the coastline way but it is still available for rendering by the style. With option --coastlinefile, no manipulation takes place. Ticker On Sat, 2021-01-02 at 18:09 +0000, Ticker Berkin wrote:
Hi Mike & Gerd
I'd suggest something like: ... When this option is specified the land and sea polygons are derived from the given precompiled data rather than the natural=coastline ways from the input OSM files. ...
The coastline ways not removed or modified, leaving it up the style to decide to render then as lines.
However --coastlinefile is different and doesn't pass them on
Ticker On Sat, 2021-01-02 at 17:43 +0000, Mike Baggaley wrote:
HI Gerd,
Thanks for the quick response. My issue with the existing wording is that it reads as if the input files are actually being modified. I'd be happy with "filtered out" or "are not loaded from the input OSM files". (Just noticed it actually says OSM tiles rather than OSM files in the first mention, so I think that needs changing as well.) Do either of the two suggestions seem better to you?
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 02 January 2021 09:53 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Minor documentation patch
Hi Mike,
thanks for the patch. I am not sure if I like the part for coastlines. I'm not 100% sure but I think the tag natural=coastline is really just removed before the OSM way is processed by the style rules. A way with more than a natural=coastline tag is still processed. That's very different to being "ignored", isn't it?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 31. Dezember 2020 16:14 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Minor documentation patch
Hi Gerd, please find attached a patch that makes some minor improvements to the documentation.
Please review and commit if OK.
Cheers, Mike
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd I think it is simplest to do that. Then later some of the sea options texts can be reworded if any of us feel strongly about it. Ticker On Mon, 2021-01-04 at 15:30 +0000, Gerd Petermann wrote:
Hi Ticker,
not sure what to do now. Do you think i should commit Mikes patch without changes?
Gerd
participants (4)
-
Gerd Petermann -
Mike Baggaley -
Ticker Berkin -
Ticker Berkin