default style and underground pipelines
Hi all, is it intended that these ways are placed in the map? sample: http://www.openstreetmap.org/way/60575011 man_made=pipeline type=water location=underground This rule in lines fires: man_made=cable|(man_made=* & man_made ~ '.*pipe.*') {name '${name} (${operator})' | '${name}' | '${operator}' } [0x28 resolution 23] Ciao, Gerd
Hi Gerd,
is it intended that these ways are placed in the map? sample: http://www.openstreetmap.org/way/60575011
man_made=pipeline type=water location=underground
This rule in lines fires:
man_made=cable|(man_made=* & man_made ~ '.*pipe.*') {name '${name} (${operator})' | '${name}' | '${operator}' } [0x28 resolution 23]
I wrote this rule with visible features in mind, such as oil or gas pipelines in rural areas. In well-mapped urban areas, this can cause unnecessary clutter, just like subways and tunnels with access=private, which are being omitted by the default style. Maybe there should be a way to limit the visibility of some objects based on the map density or nearby map features. If a cycleway or highway is parallel to a pipeline, then the pipeline should be hidden except maybe in resolution=24. Likewise, if a cycleway is parallel to a highway, it should be hidden at lower zoom levels. If there are two antiparallel oneways for a highway=*, only one should be generated at lower zoom levels. Best regards, Marko
Hi Marko, thanks for reporting this. I did not change two routines to use high precision coordinates. See http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3109 for details. Gerd
Date: Tue, 18 Feb 2014 11:04:59 +0200 From: marko.makela@iki.fi To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] default style and underground pipelines
Hi Gerd,
is it intended that these ways are placed in the map? sample: http://www.openstreetmap.org/way/60575011
man_made=pipeline type=water location=underground
This rule in lines fires:
man_made=cable|(man_made=* & man_made ~ '.*pipe.*') {name '${name} (${operator})' | '${name}' | '${operator}' } [0x28 resolution 23]
I wrote this rule with visible features in mind, such as oil or gas pipelines in rural areas. In well-mapped urban areas, this can cause unnecessary clutter, just like subways and tunnels with access=private, which are being omitted by the default style.
Maybe there should be a way to limit the visibility of some objects based on the map density or nearby map features. If a cycleway or highway is parallel to a pipeline, then the pipeline should be hidden except maybe in resolution=24. Likewise, if a cycleway is parallel to a highway, it should be hidden at lower zoom levels. If there are two antiparallel oneways for a highway=*, only one should be generated at lower zoom levels.
Best regards,
Marko _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Sorry, replied to the wrong post. It was meant to be this: http://gis.19327.n5.nabble.com/Bogus-anti-island-warnings-for-tiny-natural-c... Gerd From: gpetermann_muenchen@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Thu, 13 Mar 2014 09:28:39 +0100 Subject: Re: [mkgmap-dev] default style and underground pipelines Hi Marko, thanks for reporting this. I did not change two routines to use high precision coordinates. See http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3109 for details. Gerd
Date: Tue, 18 Feb 2014 11:04:59 +0200 From: marko.makela@iki.fi To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] default style and underground pipelines
Hi Gerd,
is it intended that these ways are placed in the map? sample: http://www.openstreetmap.org/way/60575011
man_made=pipeline type=water location=underground
This rule in lines fires:
man_made=cable|(man_made=* & man_made ~ '.*pipe.*') {name '${name} (${operator})' | '${name}' | '${operator}' } [0x28 resolution 23]
I wrote this rule with visible features in mind, such as oil or gas pipelines in rural areas. In well-mapped urban areas, this can cause unnecessary clutter, just like subways and tunnels with access=private, which are being omitted by the default style.
Maybe there should be a way to limit the visibility of some objects based on the map density or nearby map features. If a cycleway or highway is parallel to a pipeline, then the pipeline should be hidden except maybe in resolution=24. Likewise, if a cycleway is parallel to a highway, it should be hidden at lower zoom levels. If there are two antiparallel oneways for a highway=*, only one should be generated at lower zoom levels.
Best regards,
Marko _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Am 18.02.2014 10:04, schrieb Marko Mäkelä:
man_made=pipeline type=water location=underground
This rule in lines fires:
man_made=cable|(man_made=* & man_made ~ '.*pipe.*') {name '${name} (${operator})' | '${name}' | '${operator}' } [0x28 resolution 23]
I wrote this rule with visible features in mind, such as oil or gas pipelines in rural areas. In well-mapped urban areas, this can cause unnecessary clutter, just like subways and tunnels with access=private, which are being omitted by the default style.
I think underground pipelines should not be displayed, so a filter for location=underground should be added IMHO. Chris
Hi Chris, I agree, but I am not an expert reg. style rules. Please send a proposal. Gerd
To: mkgmap-dev@lists.mkgmap.org.uk From: chris66nrw@gmx.de Date: Thu, 13 Mar 2014 09:36:57 +0100 Subject: Re: [mkgmap-dev] default style and underground pipelines
Am 18.02.2014 10:04, schrieb Marko Mäkelä:
man_made=pipeline type=water location=underground
This rule in lines fires:
man_made=cable|(man_made=* & man_made ~ '.*pipe.*') {name '${name} (${operator})' | '${name}' | '${operator}' } [0x28 resolution 23]
I wrote this rule with visible features in mind, such as oil or gas pipelines in rural areas. In well-mapped urban areas, this can cause unnecessary clutter, just like subways and tunnels with access=private, which are being omitted by the default style.
I think underground pipelines should not be displayed, so a filter for location=underground should be added IMHO.
Chris
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
On Thu, Mar 13, 2014 at 09:46:26AM +0100, chris66 wrote:
Something like:
man_made=* & location=underground {delete man_made}
in front of the main rule.
Yes, and maybe others, such as: man_made=* & tunnel=yes {delete man_made} But, there could be a caveat. What is the scope of "delete"? If a polygon rule uses "delete", will the tag be visible in a line rule? Or vice versa? By the way, the man_made=* rule at the bottom could accidentally catch some man_made that were skipped because of area=yes earlier. I think that we should do one of: man_made=* & area=yes {delete man_made} or add area!=yes to the cable/pipe rule. If the delete action could interfere with rules in other files, I guess we should change the bottom rule from man_made=cable|(man_made=* & man_made ~ '.*pipe.*') to something like this: (man_made=cable|(man_made=* & man_made ~ '.*pipe.*')) & area!=yes & tunnel!=yes & location!=underground Marko
Hi Marko,
But, there could be a caveat. What is the scope of "delete"? If a polygon rule uses "delete", will the tag be visible in a line rule? Or vice versa?
If the way is not closed, only the rules in the lines file are used. If the way is closed, the rules in the lines file are used before the rules in the polygons file. In this case the rules are combined are if they were placed in one file. So yes, if you delete a tag in the lines file, the tag is not visible in the rules of the polygons file. A special case: Some ways are only passed to the polygon rules or only to the lines rules, this happens for ways that are members of mp relations or created by mp-processing. Gerd
On Thu, Mar 13, 2014 at 10:32:24AM +0100, Gerd Petermann wrote:
So yes, if you delete a tag in the lines file, the tag is not visible in the rules of the polygons file.
OK. I committed a fix in r3110 that adds additional conditions instead of deleting the man_made tag. I guess that this could lead to closed pipelines becoming polygons on the map. I did not find any such example when I checked the generated map. Marko
participants (3)
-
chris66 -
Gerd Petermann -
Marko Mäkelä