Commit: r1524: Let the background polygon (type 0x4b) cover the whole map area.

Version 1524 was commited by markb on 2010-01-28 13:25:35 +0000 (Thu, 28 Jan 2010) Let the background polygon (type 0x4b) cover the whole map area.

On 28/01/10 13:25, svn commit wrote:
Version 1524 was commited by markb on 2010-01-28 13:25:35 +0000 (Thu, 28 Jan 2010)
Let the background polygon (type 0x4b) cover the whole map area.
I forgot to say when this patch came out: what if the polygon really is too big? Garmin maps may only have one, but they also presumably make sure that tiles are not too big, whereas I'm not sure that we do in low feature density areas. ..Steve

Hi Steve,
Let the background polygon (type 0x4b) cover the whole map area.
I forgot to say when this patch came out: what if the polygon really is too big?
Garmin maps may only have one, but they also presumably make sure that tiles are not too big, whereas I'm not sure that we do in low feature density areas.
As far as I am aware, the limiting factor to the size of the 0x4b poly (in mkgmap) is the number of bits used to encode the sequence of points and, correct me if I am wrong, that is dynamically worked out based on the range of values required. If it proves to be problematic, let's just revert that commit because it's not a vital tweak. Mark

On 28.01.2010 21:24, Mark Burton wrote:
If it proves to be problematic, let's just revert that commit because it's not a vital tweak.
I suggest to do that. This patch breaks the display of the background polygon on my eTrex Legend HCx. With r1523 everything is fine. I define 0x4b as white in the typ file and it is shown white. With r1524 the background appears the standard yellow. All settings and styles unchanged. In mapsource the background is white with r1524 and later, too.

Hi Ralf,
On 28.01.2010 21:24, Mark Burton wrote:
If it proves to be problematic, let's just revert that commit because it's not a vital tweak.
I suggest to do that.
This patch breaks the display of the background polygon on my eTrex Legend HCx.
With r1523 everything is fine. I define 0x4b as white in the typ file and it is shown white.
With r1524 the background appears the standard yellow. All settings and styles unchanged.
In mapsource the background is white with r1524 and later, too.
OK, I will do that for you. It's interesting that Garmin maps use the big background poly but then they don't mind having "Garmin yellow" as the background colour. Also, my etrex vista hcx has always ignored the colour of the 0x4b poly so you're lucky it works at all! Cheers, Mark

On 02/10/2010 07:44 PM, Mark Burton wrote:
Also, my etrex vista hcx has always ignored the colour of the 0x4b poly so you're lucky it works at all!
I think I saw it working with my map on a friend's Vista HCx recently. Is it possible that it depends on how the TYP file was made? I don't understand why different Garmin units and Mapsource versions behave so differently - the data format is their own invention after all. If your patch has advantages for others you might make it an option.
participants (4)
-
Mark Burton
-
Ralf Kleineisel
-
Steve Ratcliffe
-
svn commit