Request for feature: show wrong roundabouts
Hi, from time to time I see this in the log files: Attention: Tile contains both drive-on-left (1) and drive-on-right roads (15389) The one "drive-on-left" road is clearly a bug in the OSM data. But finding that is pretty hard (I found one once by accident ...). I wanted to try to implement this myself, but I currently don't see that I have the time to dig into the code myself, that's why I write here my idea: Could we add an option (--x-report-wrong-direction or something similar), and if drive-on=left or drive-on=right is set, write the roads with the wrong direction into the log file? If drive-on= isn't set at all or to "detect", nothing should be written. So, additonal to increasing the counter, write the ID at that time to the log, too. Thanks, Thorsten -- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg)
Hi Thorsten, I think it should be easy to report the "wrong" ones, but I am not sure what bug is causing this. I'd say the problem is in the boundaries then, and it has nothing to do with round-abouts here. The two counters are based on the result of the LocationHook which depends on the --bounds and maybe the --autofill-location option and also on --country and --country-abbr. The check works like this: For each road, the LocationHook sets the values like mkgmap:admin_level2 .. mkgmap:admin_level10 These are used in inc/address to set the mkgmap:country which in turn is used to get the drive_on rule from resources\LocatorConfig.xml When this returns a wrong result, I guess that either the LocationHook sets a wrong mkgmap:admin_level2 or the country is missing in LocatorConfig.xml. Gerd
Date: Mon, 4 May 2015 14:59:38 +0200 From: kukuk@suse.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Request for feature: show wrong roundabouts
Hi,
from time to time I see this in the log files:
Attention: Tile contains both drive-on-left (1) and drive-on-right roads (15389)
The one "drive-on-left" road is clearly a bug in the OSM data. But finding that is pretty hard (I found one once by accident ...).
I wanted to try to implement this myself, but I currently don't see that I have the time to dig into the code myself, that's why I write here my idea:
Could we add an option (--x-report-wrong-direction or something similar), and if drive-on=left or drive-on=right is set, write the roads with the wrong direction into the log file? If drive-on= isn't set at all or to "detect", nothing should be written. So, additonal to increasing the counter, write the ID at that time to the log, too.
Thanks, Thorsten
-- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, On Mon, May 04, Gerd Petermann wrote:
The check works like this: For each road, the LocationHook sets the values like mkgmap:admin_level2 .. mkgmap:admin_level10 These are used in inc/address to set the mkgmap:country which in turn is used to get the drive_on rule from resources\LocatorConfig.xml When this returns a wrong result, I guess that either the LocationHook sets a wrong mkgmap:admin_level2 or the country is missing in LocatorConfig.xml.
Ok, I had in mind that we count the roundabouts. But if this is not the case ... For example on the channel islands, there are a log of wrong mapped roundabouts (according to the OSM wiki), and I hoped to find them easier. But getting a warning that a country is missing in LocatorConfig.xml or that mkgmap:admin_level2 could be wrong would help already a lot. Else this "SEVERE" log is pretty useless. Thanks, Thorsten -- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg)
Hi Thorsten, attached is a first patch for StyledConverter. I can imagine that the problem is caused by ferry connecting a drive-on-left and a drive-on-right country, so I decided to remove them from the counting. Besides that a warning with the way url is logged when option --drive-on=left or --drive-on=right is used and the way is "wrong", and all ways are reported with logging level FINE. You are right, I'd also prefer to have a warning that a country was not found in LocatorConfig.xml. I'll have a look at this now. Gerd
Date: Mon, 4 May 2015 15:43:38 +0200 From: kukuk@suse.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Request for feature: show wrong roundabouts
Hi Gerd,
On Mon, May 04, Gerd Petermann wrote:
The check works like this: For each road, the LocationHook sets the values like mkgmap:admin_level2 .. mkgmap:admin_level10 These are used in inc/address to set the mkgmap:country which in turn is used to get the drive_on rule from resources\LocatorConfig.xml When this returns a wrong result, I guess that either the LocationHook sets a wrong mkgmap:admin_level2 or the country is missing in LocatorConfig.xml.
Ok, I had in mind that we count the roundabouts. But if this is not the case ... For example on the channel islands, there are a log of wrong mapped roundabouts (according to the OSM wiki), and I hoped to find them easier.
But getting a warning that a country is missing in LocatorConfig.xml or that mkgmap:admin_level2 could be wrong would help already a lot.
Else this "SEVERE" log is pretty useless.
Thanks, Thorsten
-- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, On Mon, May 04, Gerd Petermann wrote:
attached is a first patch for StyledConverter. I can imagine that the problem is caused by ferry connecting a drive-on-left and a drive-on-right country, so I decided to remove them from the counting.
Thanks, works. For my now tested cases it really seems to be caused by ferry connections, I don't get a SEVERE message anymore. Thorsten -- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg)
Hi Thorsten, great! So I think I will commit report-driving-side-v1.patch soon. Attached is a patch that should report a warning in LocatorConfig when the ISO code is not known and the driving side is requested. It also adds the evaluation of country-abbr to StyledConverter so that it is possible to work without bounds. The test looks first for the mkgmap:country tag in the road, if that is not set and --country-abbr is set, that the latter value is used to request the driving side from LocatorConfig.xml. Gerd
Date: Mon, 4 May 2015 16:25:35 +0200 From: kukuk@suse.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Request for feature: show wrong roundabouts
Hi Gerd,
On Mon, May 04, Gerd Petermann wrote:
attached is a first patch for StyledConverter. I can imagine that the problem is caused by ferry connecting a drive-on-left and a drive-on-right country, so I decided to remove them from the counting.
Thanks, works. For my now tested cases it really seems to be caused by ferry connections, I don't get a SEVERE message anymore.
Thorsten
-- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Could this warning be taken out if "--check-roundabouts" is not given? As my maps are not for cars - I don't mind a roundabout being mapped in the wrong direction... On 4 May 2015 at 16:36, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Thorsten,
great! So I think I will commit report-driving-side-v1.patch soon.
Attached is a patch that should report a warning in LocatorConfig when the ISO code is not known and the driving side is requested.
It also adds the evaluation of country-abbr to StyledConverter so that it is possible to work without bounds. The test looks first for the mkgmap:country tag in the road, if that is not set and --country-abbr is set, that the latter value is used to request the driving side from LocatorConfig.xml.
Gerd
Date: Mon, 4 May 2015 16:25:35 +0200 From: kukuk@suse.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Request for feature: show wrong roundabouts
Hi Gerd,
On Mon, May 04, Gerd Petermann wrote:
attached is a first patch for StyledConverter. I can imagine that the problem is caused by ferry connecting a drive-on-left and a drive-on-right country, so I decided to remove them from the counting.
Thanks, works. For my now tested cases it really seems to be caused by ferry connections, I don't get a SEVERE message anymore.
Thorsten
-- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Floragasse 9/11 1040 Wien Austria - Österreich
Hi Felix, I guess you mean the "Attention: Tile contains both drive-on-left (2917) and drive-on-right roads (3647)" message. it was Steve who suggested to "warn loudly" . http://gis.19327.n5.nabble.com/Manage-drive-on-left-drive-on-right-in-resour... and at that time we believed that we would change mkgmap to allow non-rectangular tile boundaries to fix the problem soon. I don't mind to change the severity level of the message to WARNING. Gerd Date: Wed, 20 May 2015 21:10:59 +0200 From: extremecarver@gmail.com To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Request for feature: show wrong roundabouts Could this warning be taken out if "--check-roundabouts" is not given? As my maps are not for cars - I don't mind a roundabout being mapped in the wrong direction... On 4 May 2015 at 16:36, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote: Hi Thorsten, great! So I think I will commit report-driving-side-v1.patch soon. Attached is a patch that should report a warning in LocatorConfig when the ISO code is not known and the driving side is requested. It also adds the evaluation of country-abbr to StyledConverter so that it is possible to work without bounds. The test looks first for the mkgmap:country tag in the road, if that is not set and --country-abbr is set, that the latter value is used to request the driving side from LocatorConfig.xml. Gerd
Date: Mon, 4 May 2015 16:25:35 +0200 From: kukuk@suse.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Request for feature: show wrong roundabouts
Hi Gerd,
On Mon, May 04, Gerd Petermann wrote:
attached is a first patch for StyledConverter. I can imagine that the problem is caused by ferry connecting a drive-on-left and a drive-on-right country, so I decided to remove them from the counting.
Thanks, works. For my now tested cases it really seems to be caused by ferry connections, I don't get a SEVERE message anymore.
Thorsten
-- Thorsten Kukuk, Senior Architect SLES & Common Code Base SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg) _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Floragasse 9/11 1040 Wien Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
Felix Hartmann -
Gerd Petermann -
Thorsten Kukuk