NSIS installer improvements phase 3 v1
Hi, Please find attached a patch with a new set of enhancement/fixes for the NSIS installer: * new installer page allowing the user to delete MapSource cache * fix for maps with a space in the overview name * fix issues with custom versions of installer.nsi Thanks, N.
Hi ! I think i found another bug. Take a look at my NSI-File (http://dev.openstreetmap.de/aio/germany-daily/img/osmmap.nsi) Everytime the path of the basemap.TYP-file is hard-coded. Why ? Is there any need ? If you download all the *.img and osmmap.* files you can generate outputs for Mapsource, Basemap or gmapsupp.img with there same date. greetings Dirk -- Wikipedia -- http://tools.wikimedia.de/~flacus/IWLC/ OSM -- http://osm.flacus.de/
On 4/5/2011 9:39 AM, flabot@googlemail.com wrote:
Hi !
I think i found another bug. Take a look at my NSI-File (http://dev.openstreetmap.de/aio/germany-daily/img/osmmap.nsi)
Everytime the path of the basemap.TYP-file is hard-coded. Why ? Is there any need ?
If you download all the *.img and osmmap.* files you can generate outputs for Mapsource, Basemap or gmapsupp.img with there same date.
greetings Dirk
Let me turn the question around. Is there any need to have the TYP file not hardcoded? At the moment I get the TYP file name from the arguments passed to mkgmap because I cannot assume that the TYP filename will be the same as the map name. If I understand correctly your second point, I am not in favor of using wildcards for packaging the files because we just do not know what is in the directory and might package too much. Thanks, N.
Let me turn the question around. Is there any need to have the TYP file not hardcoded?
At the moment I get the TYP file name from the arguments passed to mkgmap because I cannot assume that the TYP filename will be the same as the map name.
If I understand correctly your second point, I am not in favor of using wildcards for packaging the files because we just do not know what is in the directory and might package too much.
Thanks,
N.
Let me turn your question. Why is only the Typ-File hard-coded an not every file ? At http://dev.openstreetmap.de/aio/germany-daily/img/ you can download the raw-info and make whatever you want to make from. For me it is no problem to use sed and change the *.nsi in a way user can use them from a drive with different path and foldernames. I was only woundering why only one file ist hard-coded. Dirk -- Wikipedia -- http://tools.wikimedia.de/~flacus/IWLC/ OSM -- http://osm.flacus.de/
On Tue, Apr 5, 2011 at 20:25, flabot@googlemail.com <flabot@googlemail.com> wrote:
Let me turn the question around. Is there any need to have the TYP file not hardcoded?
Maybe because you are creating nsis config file on linux and compiling it on windows, or generally somewhere else. This bug was originally reported by me on 14:40, 4 June 2010 (UTC), please fix it:) -- Michal Grézl http://openstreetmap.cz
Let me turn your question. Why is only the Typ-File hard-coded an not every file ?
At http://dev.openstreetmap.de/aio/germany-daily/img/ you can download the raw-info and make whatever you want to make from. For me it is no problem to use sed and change the *.nsi in a way user can use them from a drive with different path and foldernames. I was only woundering why only one file ist hard-coded.
Dirk
Please correct me if I am wrong but it loos like your question is why the TYP file has its path hardcoded and not the other files. If I remember correctly some people does not have the TYP file in the same directory as the other files and wanted to have the path to that file in the NSI file so that the installer would build properly. What parameters are you supplying to mkgmap? Do you give just the TYP filename or its full path? Thanks, N.
participants (3)
-
flabot＠googlemail.com -
Michal Grézl -
Nakor