[PATCH v1] Do not process boundary relations

At the moment processing of multipolygon boundary relations creates a lot of unwanted effects (artificial boundaries on tile bounds, lots of warnings etc.). The patch excludes the boundary relations from the multipolygon processing. This can be changed with the new option --process-boundary-relations. An additional spin-off is the improved performance and less warnings. WanMil

WanMil schrieb am 28.03.2010 21:43:
The patch excludes the boundary relations from the multipolygon processing. This can be changed with the new option --process-boundary-relations.
This might solve the actual problem, but I think it is a dirty hack. When we have the next tag with such a problem, will we add another option switch? Instead we should look for a cleaner solution, where either the mp processing can be better controlled via a style file (e.g. a new style file applicable tags for the mp-processing or perhaps limit the mp-processing to the expressions listed in the polygon file), or where the results of the mp-processings will be marked, so that the original and the artifical polygons can be distinguished in the following processings. Gruss Torsten

WanMil schrieb am 28.03.2010 21:43:
The patch excludes the boundary relations from the multipolygon processing. This can be changed with the new option --process-boundary-relations.
This might solve the actual problem, but I think it is a dirty hack. When we have the next tag with such a problem, will we add another option switch?
Instead we should look for a cleaner solution, where either the mp processing can be better controlled via a style file (e.g. a new style file applicable tags for the mp-processing or perhaps limit the mp-processing to the expressions listed in the polygon file), or where the results of the mp-processings will be marked, so that the original and the artifical polygons can be distinguished in the following processings.
Gruss Torsten
I agree that we should look for a cleaner solution. But at the moment we don't have one. It will take some time until we have a reasonable solution for this. I started with an idea to tag all polygons created by the mp processing. But I think that's too complicated for the style file. Please start a new thread where we can think about how the new tag handling of the mp processing and the connection to the style system should look like. I am happy if more than two of us (I don't have good knowledge of the style system) are talking about fundamental improvements. Just for now I strongly recommend to use this patch until a better solution is ready to use. WanMil

On 28.03.2010 21:43, WanMil wrote:
At the moment processing of multipolygon boundary relations creates a lot of unwanted effects (artificial boundaries on tile bounds, lots of warnings etc.).
The patch excludes the boundary relations from the multipolygon processing. This can be changed with the new option --process-boundary-relations.
An additional spin-off is the improved performance and less warnings.
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev For me the patch works very well (I don't know of any reason why I would need to have this behaviour tuneable via style-file, but as often, needs only arise once it is possible). Especially the annoying border artefacts of borders on the geofabrik cuttings are gone.... .... However even though I don't really know if it is the same reason. When compiling contourlines, there are also very often straight artefact lines crossing the whole image, maybe the same patch should be used when outputting lines 0x20-0x26 and 0x17??? (these are the contourline regions, and cannot be used for other features)

On 28.03.2010 21:43, WanMil wrote:
At the moment processing of multipolygon boundary relations creates a lot of unwanted effects (artificial boundaries on tile bounds, lots of warnings etc.).
The patch excludes the boundary relations from the multipolygon processing. This can be changed with the new option --process-boundary-relations.
An additional spin-off is the improved performance and less warnings.
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev For me the patch works very well (I don't know of any reason why I would need to have this behaviour tuneable via style-file, but as often, needs only arise once it is possible). Especially the annoying border artefacts of borders on the geofabrik cuttings are gone.... .... However even though I don't really know if it is the same reason. When compiling contourlines, there are also very often straight artefact lines crossing the whole image, maybe the same patch should be used when outputting lines 0x20-0x26 and 0x17??? (these are the contourline regions, and cannot be used for other features)
Mmmh, I don't see any dependency between contourlines and the multipolygon processing. If you see any please let me know. WanMil

At the moment processing of multipolygon boundary relations creates a lot of unwanted effects (artificial boundaries on tile bounds, lots of warnings etc.).
The patch excludes the boundary relations from the multipolygon processing. This can be changed with the new option --process-boundary-relations.
An additional spin-off is the improved performance and less warnings.
WanMil
Can you please commit this patch? I think this patch is quite needed unless we have a good overall working concept for such relations and it definitely removes the ugly boundary lines on tile borders. Thanks! WanMil
participants (3)
-
Felix Hartmann
-
Torsten Leistikow
-
WanMil