Hi all, I am not sure what to use in the overview map (and how) option --copyright-message can be used to place a msg into each *.img file. This message is displayed in GPSMapEdit -> File -> Map Properties as "Copyright information", preceded by the text "PROGRAM LICENCED UNDER GPL V2" which is always added by mkgmap. option --license-file can be used to place license messages into each *.img file. MapSource displays these lines when you click on the Copyright button in the map manager (German : "Kartenproduktmanager") When reading *.img files, mkgmap r2636 cannot (yet) extract the data from the "--copyright-message", it can only extract the "--license-file" info. Reg. the overview map: r2636 places the "--license-file" info into the *.tdb file and into the place where the "--copyright-message" info would normally go. I would prefer to extract the "--copyright-message" from the ovm_*.img, but I don't know how complicated that is (at least it seems not simple), so for now I've committed r2637: evaluate options --license-file and --copyright-message when creating the overview map. @Steve: TreFileReader.getCopyrights() contains this comment: // TODO This needs the label section to work... Is this the right place to extract the data? I think it should better be placed in uk.me.parabola.imgfmt.app.map.MapReader as this has the labels ? Gerd -- View this message in context: http://gis.19327.n5.nabble.com/licence-and-copyright-in-overview-map-tp57636... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd As the overview map seems to apply to Mapsource/Basecamp the only other place to insert additional copyright info is in the tdb file. Nick -- View this message in context: http://gis.19327.n5.nabble.com/licence-and-copyright-in-overview-map-tp57636... Sent from the Mkgmap Development mailing list archive at Nabble.com.
On 01/06/13 09:18, GerdP wrote:
@Steve: TreFileReader.getCopyrights() contains this comment: // TODO This needs the label section to work...
That comment was written well before we had MapReader and LBLFileReader To handle the labels the same way as in RGN or NET would be to pass the LBLFileReader to the TREFileReader in the MapReader constructor. Then you can use lblFile.fetchLabel(labelNum) to get the strings. ..Steve
Hi Steve, okay, after a closer look to the sources I know how to extract the copyright now. I still have a few open problems: 1) error: TreHeader.java lines 144 to 149 override the copyright section which is already read (correctly) in line 120. I think I have to remove these lines? 2) Order of lines : The MapBuilder.processInfo() method adds the "--license-file data " in the right order. The help file says: Specify a file which content will be added as license. Every line is one entry. All entrys of all maps will be merged, unified and shown in random order. AFAIK this "randomization" only happens when the data is added to the *.tdb file? If no "--license-file" option is used, a message is generated by MapBuilder.processInfo() : mapInfo.add("Map data (c) OpenStreetMap and its contributors"); mapInfo.add("http://www.openstreetmap.org/copyright"); mapInfo.add(""); mapInfo.add("This map data is made available under the Open Database License:"); mapInfo.add("http://opendatacommons.org/licenses/odbl/1.0/"); mapInfo.add("Any rights in individual contents of the database are licensed under the"); mapInfo.add("Database Contents License: http://opendatacommons.org/licenses/dbcl/1.0/"); mapInfo.add(""); These lines make not much sense if they apear in random order. 3) Even worse results will be produced if a mapper combines *.img files with different copyright or licence-infos. Conclusion: a) If we extract the info from the input files: I prefer to keep the order of the copyright section and licence-info of each input file. If a mapper combines files with different values in these sections, each different "block" will appear once. Don't know if it makes sense to combine data in one img file that was created with differnt copyrights? b) if we use options --licence-file and --copyright-message for the overview map: Should we print a warning if any of the input files has different copyright or licence info sections? Gerd Steve Ratcliffe wrote
On 01/06/13 09:18, GerdP wrote:
@Steve: TreFileReader.getCopyrights() contains this comment: // TODO This needs the label section to work...
That comment was written well before we had MapReader and LBLFileReader
To handle the labels the same way as in RGN or NET would be to pass the LBLFileReader to the TREFileReader in the MapReader constructor.
Then you can use lblFile.fetchLabel(labelNum) to get the strings.
..Steve _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/licence-and-copyright-in-overview-map-tp57636... Sent from the Mkgmap Development mailing list archive at Nabble.com.
On 02/06/13 09:08, GerdP wrote:
Hi Steve,
okay, after a closer look to the sources I know how to extract the copyright now. I still have a few open problems: 1) error: TreHeader.java lines 144 to 149 override the copyright section which is already read (correctly) in line 120. I think I have to remove these lines?
Yes, those lines must be removed.
If no "--license-file" option is used, a message is generated by MapBuilder.processInfo() : mapInfo.add("Map data (c) OpenStreetMap and its contributors"); mapInfo.add("http://www.openstreetmap.org/copyright"); mapInfo.add(""); mapInfo.add("This map data is made available under the Open Database License:"); mapInfo.add("http://opendatacommons.org/licenses/odbl/1.0/"); mapInfo.add("Any rights in individual contents of the database are licensed under the"); mapInfo.add("Database Contents License: http://opendatacommons.org/licenses/dbcl/1.0/"); mapInfo.add("");
These lines make not much sense if they apear in random order.
Each piece of licence information needs to be a single line in that case. Thats assuming it is not mkgmap that is randomising the lines, if that is the case, then just stop it doing that.
Conclusion: a) If we extract the info from the input files: I prefer to keep the order of the copyright section and licence-info of each input file. If a mapper combines files with different values in these sections, each different "block" will appear once. Don't know if it makes sense to combine data in one img file that was created with differnt copyrights?
It may not happen often but there is nothing wrong with having multiple copyrights applying to a map set or even an individual map. I don't see an a need for a warning.
b) if we use options --licence-file and --copyright-message for the overview map: Should we print a warning if any of the input files has different copyright or licence info sections?
participants (3)
-
GerdP -
nwillink -
Steve Ratcliffe