Hi Thanks to everyone who commented on the options issue. I also went back and read the thread started by Felix in 2010. Yes 2010, so it is time to do something. I am giving Greg's statement that currently "ignoring options does not lead to success" a lot of weight in deciding what to do. Many of our options are really input data that have to be options because the input file does not contain them. Compare with the Polish format which does in fact include several of our options (FID, CountryName etc) in its data. These options generally don't cause confusion or bugs and so are mostly harmless even if there are quite a few of them. So I will concentrate on "true" options that cause mkgmap to operate in different ways or produce different outputs. In the next days or weeks I am going to do the following. 1. Create a way of setting the default value of an option in the options help file. The help will then always be up to date with the actual default value. 2. Move options that already have a default value (eg description is "OSM street map") from code to the help file. 3. Create a way to mark an option as obsolete with a reason. So a warning can be printed for options that are being removed or having their names changed and what you can do instead. 4. Implement a --warnings option, so that the warning-type options can be migrated there. 5. Expand the list of options that can be given in the "options" file of a style to include all data input options. This is the preliminary list of changes to be made, last chance for comments! Options to be defaulted ----------------------- add-pois-to-areas code-page=1252 generate-sea=sectors,close-gaps=6000 ignore-maxspeeds index location-autofill=is_in min-size-polygon nsis preserve-element-order process-destination reduce-point-density=5 route tdbfile Options to be removed --------------------- Some of these involve a good amount of code removal too. block-size charset ignore-builtin-relations ignore-osm-bounds lower-case make-all-cycleways make-cycleways make-poi-index map-features max-flare-length-ratio net no-poi-address road-name-pois tdb-v3 latin1 Options to change name ---------------------- gmapsupp --> gps keep-going --> ignore-errors Options to become --warnings sub-options ------------------------------------- check-roundabout-flares check-roundabouts report-dead-ends report-similar-arcs Options allowed in style 'options' file --------------------------------------- Start off with the list from Geoff, excluding ones that are already allowed and removing ones that will be removed anyway. Probably more to add. mapname=name description=text country-name=name country-abbr=abbreviation region-name=name region-abbr=abbreviation code-page=number family-id family-name product-id product-version series-name area-name overview-mapname=name overview-mapnumber=8 digit number drive-on-left drive-on-right ..Steve
El 05/01/13 23:17, Steve Ratcliffe escribió:
Options to be removed road-name-pois
As I commented in the past, this option is still necessary for countries where streets/roads are named with the type of way before the name, that is "street foo" instead of "foo street" as in English. I can think at least in Spanish, Portuguese, French and Italian speaking countries to work this way (probably most latin languages), so until a predictive search method is implemented I vote for keeping this option alive.
Options allowed in style 'options' file ---------------------------------------
Start off with the list from Geoff, excluding ones that are already allowed and removing ones that will be removed anyway. Probably more to add.
mapname=name description=text country-name=name country-abbr=abbreviation region-name=name region-abbr=abbreviation code-page=number family-id family-name product-id product-version series-name area-name overview-mapname=name overview-mapnumber=8 digit number drive-on-left drive-on-right
If the above options have to be set in the style, would that mean a different style is necessary for each country? Could we use something like current inc/address file to define these options?
Hi
road-name-pois
As I commented in the past, this option is still necessary for countries where streets/roads are named with the type of way before the name, that
OK, although I also understood that having so many POI's caused problems.
least in Spanish, Portuguese, French and Italian speaking countries to work this way (probably most latin languages), so until a predictive search method is implemented I vote for keeping this option alive.
This is something that I should work on then. I believe that I know how to make it work.
If the above options have to be set in the style, would that mean a different style is necessary for each country? Could we use something like current inc/address file to define these options?
No it is 'can be' not 'have to be' set in the style. The command line options override any option that is set in the style. Sometimes it would make sense to set options in a style and sometimes it wouldn't - your choice. Being able to define options like drive-on-left for different countries would be great, but that is a separate enhancement. ..Steve
El 06/01/13 00:23, Steve Ratcliffe escribió:
Hi
road-name-pois
As I commented in the past, this option is still necessary for countries where streets/roads are named with the type of way before the name, that
OK, although I also understood that having so many POI's caused problems.
I heard about problems when using road-name-pois, specially from Felix, but I've been using this option for years and don't remember facing any problem I could relate to it, apart from the long time searches take.
least in Spanish, Portuguese, French and Italian speaking countries to work this way (probably most latin languages), so until a predictive search method is implemented I vote for keeping this option alive.
This is something that I should work on then. I believe that I know how to make it work.
I would really thank you if you could do it.
If the above options have to be set in the style, would that mean a different style is necessary for each country? Could we use something like current inc/address file to define these options?
No it is 'can be' not 'have to be' set in the style. The command line options override any option that is set in the style. Sometimes it would make sense to set options in a style and sometimes it wouldn't - your choice.
OK, now it's clear
Being able to define options like drive-on-left for different countries would be great, but that is a separate enhancement. This would also be great for maps including left and right driving.
participants (2)
-
Carlos Dávila -
Steve Ratcliffe