building catch all
Hi, at the end of polygons we have some catch all rule: (building=* | amenity=*) & area!=no [0x13 resolution 24] tourism=* & area!=no & waterway!=* [0x13 resolution 24] # man_made can be used on areas or lines man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench) [0x13 resolution 24] man_made=* & area=yes [0x13 resolution 24] This causes that following osm elements are mapped to building (0x13): tourism=camp_site (should be mapped to 0x17 or 0x19) amenity=grave_yard (should be mapped to 0x1a) So I think we should have more specific rules here instead a catch-all. Chris
Chris wrote
Hi, at the end of polygons we have some catch all rule:
(building=* | amenity=*) & area!=no [0x13 resolution 24]
tourism=* & area!=no & waterway!=* [0x13 resolution 24]
# man_made can be used on areas or lines man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench) [0x13 resolution 24]
man_made=* & area=yes [0x13 resolution 24]
This causes that following osm elements are mapped to building (0x13):
tourism=camp_site (should be mapped to 0x17 or 0x19) amenity=grave_yard (should be mapped to 0x1a)
So I think we should have more specific rules here instead a catch-all.
I agree, there are more frequently used polygons as tourism=zoo, theme_park, attraction, picnic_site etc. Also 0x1f can be used (rendered in Mapsource as green area (Provincial park in gpsmapedit) tourism=* & area!=no & waterway!=* [0x1f resolution 24] So someone who mantains a typ file can distinguish between tourism=* (0x1f), leisure=park (0x17) or leisure=pitch (0x19) 0x1a is indeed the common Garmin tag for graveyards, I wonder why this isnt listed anymore?
I wrote:
0x1a is indeed the common Garmin tag for graveyards, I wonder why this isnt listed anymore?
I noticed it is rendered AFTER (building=* | amenity=*) & area!=no [0x13 resolution 24] in the landuse_polygons, so this line should be corrected too (move before the processing of buildings?): include 'inc/landuse_polygons';
Hi Minko, could you post a patch for all the changes? Otherwise I will not be able to commit it soon because I do not have much time at the moment... WanMil
I wrote:
0x1a is indeed the common Garmin tag for graveyards, I wonder why this isnt listed anymore?
I noticed it is rendered AFTER (building=* | amenity=*) & area!=no [0x13 resolution 24] in the landuse_polygons, so this line should be corrected too (move before the processing of buildings?):
include 'inc/landuse_polygons';
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Am 22.06.2014 22:33, schrieb WanMil:
could you post a patch for all the changes? Otherwise I will not be able to commit it soon because I do not have much time at the moment...
Hi, this is my suggestion: ---------------------------------------------------------------------- # building tag should be last (building=* | amenity=*) & area!=no [0x13 resolution 24] tourism=* & area!=no & waterway!=* [0x13 resolution 24] # man_made can be used on areas or lines man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench) [0x13 resolution 24] man_made=* & area=yes [0x13 resolution 24] ---------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tourism=camp_site [0x19 resolution 21] tourism=picnic_site [0x19 resolution 21] tourism=hotel [0x13 resolution 24] tourism=guest_house [0x13 resolution 24] tourism=motel [0x13 resolution 24] tourism=museum [0x13 resolution 24] tourism=zoo [0x17 resolution 21] building=* [0x13 resolution 24] man_made=chimney [0x13 resolution 24] man_made=silo [0x13 resolution 24] man_made=storage_tank [0x13 resolution 24] man_made=wastewater_plant [0x0c resolution 21] man_made=works [0x0c resolution 21] ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris
In the polygons file, I would suggest to change these lines: - (building=* | amenity=*) & area!=no [0x13 resolution 24] - tourism=* & area!=no & waterway!=* [0x13 resolution 24] + (building=* | amenity=*) & area!=no & amenity!=grave_yard [0x13 resolution 24] + tourism=* & area!=no & waterway!=* [0x1f resolution 24] Wanmil wrote:
could you post a patch for all the changes? Otherwise I will not be able to commit it soon because I do not have much time at the moment...
Chris wrote:
Hi, this is my suggestion:
----------------------------------------------------------------------
# building tag should be last (building=* | amenity=*) & area!=no [0x13 resolution 24] tourism=* & area!=no & waterway!=* [0x13 resolution 24] # man_made can be used on areas or lines man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench) [0x13 resolution 24] man_made=* & area=yes [0x13 resolution 24]
----------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tourism=camp_site [0x19 resolution 21] tourism=picnic_site [0x19 resolution 21] tourism=hotel [0x13 resolution 24] tourism=guest_house [0x13 resolution 24] tourism=motel [0x13 resolution 24] tourism=museum [0x13 resolution 24] tourism=zoo [0x17 resolution 21]
building=* [0x13 resolution 24]
man_made=chimney [0x13 resolution 24] man_made=silo [0x13 resolution 24] man_made=storage_tank [0x13 resolution 24] man_made=wastewater_plant [0x0c resolution 21] man_made=works [0x0c resolution 21]
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Can someone commit this to the styles, tourism areas and grave yards are still rendered as buildings. In the polygons file, I would suggest to change these lines: - (building=* | amenity=*) & area!=no [0x13 resolution 24] - tourism=* & area!=no & waterway!=* [0x13 resolution 24] + (building=* | amenity=*) & area!=no & amenity!=grave_yard [0x13 resolution 24] + tourism=* & area!=no & waterway!=* [0x1f resolution 24] Then there are more non-building man_made areas that are rendered as buildings: man_made=groyne man_made=man_made=reinforced_slope These should be added to the polygon style file: man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench & man_made!=groyne & man_made!=reinforced_slope) [0x13 resolution 24]
Wanmil wrote:
could you post a patch for all the changes? Otherwise I will not be able to commit it soon because I do not have much time at the moment...
Chris wrote:
Hi, this is my suggestion:
----------------------------------------------------------------------
# building tag should be last (building=* | amenity=*) & area!=no [0x13 resolution 24] tourism=* & area!=no & waterway!=* [0x13 resolution 24] # man_made can be used on areas or lines man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench) [0x13 resolution 24] man_made=* & area=yes [0x13 resolution 24]
----------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tourism=camp_site [0x19 resolution 21] tourism=picnic_site [0x19 resolution 21] tourism=hotel [0x13 resolution 24] tourism=guest_house [0x13 resolution 24] tourism=motel [0x13 resolution 24] tourism=museum [0x13 resolution 24] tourism=zoo [0x17 resolution 21]
building=* [0x13 resolution 24]
man_made=chimney [0x13 resolution 24] man_made=silo [0x13 resolution 24] man_made=storage_tank [0x13 resolution 24] man_made=wastewater_plant [0x0c resolution 21] man_made=works [0x0c resolution 21]
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi
In the polygons file, I would suggest to change these lines:
- (building=* | amenity=*) & area!=no [0x13 resolution 24] - tourism=* & area!=no & waterway!=* [0x13 resolution 24]
+ (building=* | amenity=*) & area!=no & amenity!=grave_yard [0x13 resolution 24] + tourism=* & area!=no & waterway!=* [0x1f resolution 24]
OK I can do that.
These should be added to the polygon style file:
man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench & man_made!=groyne & man_made!=reinforced_slope) [0x13 resolution 24]
There is already a section that looks like this, should it be replaced with the above? man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench) [0x13 resolution 24] man_made=* & area=yes [0x13 resolution 24] ..Steve
Thanks Steve,
These should be added to the polygon style file:
man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench & man_made!=groyne & man_made!=reinforced_slope) [0x13 resolution 24]
There is already a section that looks like this, should it be replaced with the above?
man_made=* & area!=no & (man_made!=door & man_made!=embankment & man_made!=breakwater & man_made!=cable_line & man_made!=cutline & man_made!=cutting & man_made!=levee & man_made!=trench) [0x13 resolution 24] man_made=* & area=yes [0x13 resolution 24]
Yes, that was my intention. I'd like to add man_made!=groyne & man_made!=reinforced_slope because those aren't buildings
participants (4)
-
chris66 -
Minko -
Steve Ratcliffe -
WanMil