Further possible removals from builtin-tag-list

Hi, I want to remove a long list of tags from the builtin-tag-list by different actions. The advantage is that specialised styles that do not need these tags are faster and do consume less memory. == Tags that are no longer used == Tag: osm:id There are only two references in mkgmap source code: HighwayHook sets this tag and StyleConverter that reads this tag. I think this is not an OSM tag but a tag set internally by mkgmap. If so we should rename it to mkgmap:osmid. Any objections? Tag: openGeoDB:postal_codes I haven't found any references in the source code. openGeoDB workout have been removed with locator branch merge. == Tags that can be moved to style handling == I am thinking about moving some static coded rules (e.g. name of a POI street is taken from tag "addr:street") to the style system as it has been done with other location items: mkgmap:street!=* & addr:street=* { set mkgmap:street='${addr:street}' } This has two advantages: 1. Speed improvement for styles that don't use this information. (Marko: this should help you with your need for speed improvements for special styles) 2. More flexiblity: If someone likes to use different tags for a POI street name it is easy to configure that. Possible downside: * Little more memory requirement for styles that use address information The tags to be changed are: addr:street addr:housename addr:housenumber addr:phone (is currently not used in mkgmap) phone is_in == Tags that are used only if --route is set == I am not sure if that's correct. Can someone please confirm that? access bicycle carpool delivery emergency except exception foot goods hgv motorcar motorcycle psv restriction route taxi toll WanMil

WanMil (wmgcnfg@web.de) wrote:
Hi,
I want to remove a long list of tags from the builtin-tag-list by different actions. The advantage is that specialised styles that do not need these tags are faster and do consume less memory.
== Tags that are no longer used ==
Tag: osm:id There are only two references in mkgmap source code: HighwayHook sets this tag and StyleConverter that reads this tag. I think this is not an OSM tag but a tag set internally by mkgmap. If so we should rename it to mkgmap:osmid. Any objections?
Tag: openGeoDB:postal_codes I haven't found any references in the source code. openGeoDB workout have been removed with locator branch merge.
== Tags that can be moved to style handling ==
I am thinking about moving some static coded rules (e.g. name of a POI street is taken from tag "addr:street") to the style system as it has been done with other location items: mkgmap:street!=* & addr:street=* { set mkgmap:street='${addr:street}' }
This has two advantages: 1. Speed improvement for styles that don't use this information. (Marko: this should help you with your need for speed improvements for special styles)
2. More flexiblity: If someone likes to use different tags for a POI street name it is easy to configure that.
Possible downside: * Little more memory requirement for styles that use address information
The tags to be changed are: addr:street addr:housename addr:housenumber addr:phone (is currently not used in mkgmap) phone is_in
== Tags that are used only if --route is set ==
I am not sure if that's correct. Can someone please confirm that?
access bicycle carpool delivery emergency except exception foot goods hgv motorcar motorcycle psv restriction route taxi toll
I would certainly agree with you on the addr: tags; the way it is currently done internal to the mkgmap code is a little confusing and it would be much more flexible if the address treatment was moved to the points style file. Not sure about addr:phone though - isn't this deprecated and instead phone=* is used to fill the telephone field in the address form? Just my two fils, Charlie

Attached patch realizes the proposals. Please test it and if possible give a note if there is a speed improvement for specialized styles. WanMil
Hi,
I want to remove a long list of tags from the builtin-tag-list by different actions. The advantage is that specialised styles that do not need these tags are faster and do consume less memory.
== Tags that are no longer used ==
Tag: osm:id There are only two references in mkgmap source code: HighwayHook sets this tag and StyleConverter that reads this tag. I think this is not an OSM tag but a tag set internally by mkgmap. If so we should rename it to mkgmap:osmid. Any objections?
Tag: openGeoDB:postal_codes I haven't found any references in the source code. openGeoDB workout have been removed with locator branch merge.
== Tags that can be moved to style handling ==
I am thinking about moving some static coded rules (e.g. name of a POI street is taken from tag "addr:street") to the style system as it has been done with other location items: mkgmap:street!=*& addr:street=* { set mkgmap:street='${addr:street}' }
This has two advantages: 1. Speed improvement for styles that don't use this information. (Marko: this should help you with your need for speed improvements for special styles)
2. More flexiblity: If someone likes to use different tags for a POI street name it is easy to configure that.
Possible downside: * Little more memory requirement for styles that use address information
The tags to be changed are: addr:street addr:housename addr:housenumber addr:phone (is currently not used in mkgmap) phone is_in
== Tags that are used only if --route is set ==
I am not sure if that's correct. Can someone please confirm that?
access bicycle carpool delivery emergency except exception foot goods hgv motorcar motorcycle psv restriction route taxi toll
I would certainly agree with you on the addr: tags; the way it is currently done internal to the mkgmap code is a little confusing and it would be much more flexible if the address treatment was moved to the points style file.
Not sure about addr:phone though - isn't this deprecated and instead phone=* is used to fill the telephone field in the address form?
Just my two fils,
Charlie
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

On Sun, Aug 28, 2011 at 06:51:44AM +0100, charlie@cferrero.net wrote:
Not sure about addr:phone though - isn't this deprecated and instead phone=* is used to fill the telephone field in the address form?
I believe that phone=* is being replaced with contact:phone, just like url is being replaced with contact:website. I guess we should support both. Marko

Not sure about addr:phone though - isn't this deprecated and instead phone=* is used to fill the telephone field in the address form?
I believe that phone=* is being replaced with contact:phone, just like url is being replaced with contact:website. I guess we should support both.
Marko
Ok, I will commit phone=* only. If you think that contact:phone should additionally used that you can add that later on to the style. WanMil
participants (3)
-
charlie@cferrero.net
-
Marko Mäkelä
-
WanMil