Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Hi Gerd, No problem with that, but I don't think it should be a hidden option, and the use of 'force' suggests it will reverse ways that are direction sensitive. I suggest --allow-reverse-merge and add it to the documentation stating that if your style includes mkgmap:has_direction is it on by default. I don't have any direction sensitive ways in my style and hence will need to use the option. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 11 May 2021 12:21 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Mike, it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet). Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Gerd, I may be misunderstanding this, but the explanation of when it is enabled seems illogical. It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it. Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true. Cheers, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Mike, okay, I commited the code to get some more feedback regarding the usability ;) Please check attached patch which would document new option --allow-reverse-merge=detect|no|yes I still don't know how to document the new internal tag. It probably needs a new section. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 11. Mai 2021 14:08 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Gerd, No problem with that, but I don't think it should be a hidden option, and the use of 'force' suggests it will reverse ways that are direction sensitive. I suggest --allow-reverse-merge and add it to the documentation stating that if your style includes mkgmap:has_direction is it on by default. I don't have any direction sensitive ways in my style and hence will need to use the option. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 11 May 2021 12:21 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Mike, it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet). Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Gerd, I may be misunderstanding this, but the explanation of when it is enabled seems illogical. It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it. Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true. Cheers, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (2)
-
Gerd Petermann -
Mike Baggaley