drive-on-left/right detection broken with max-jobs > 1
While looking through the source code I observed that the drive-on-left/right flag is set statically in the NODHEader class. That means that a threads of one tile modifies this flag of all other tiles. So when compiling a european map with GB included, it's a kind of lottery if the GB areas really have this flag set. Do I miss something? WanMil
On 04/01/2012 22:46, WanMil wrote:
While looking through the source code I observed that the drive-on-left/right flag is set statically in the NODHEader class. That means that a threads of one tile modifies this flag of all other tiles. So when compiling a european map with GB included, it's a kind of lottery if the GB areas really have this flag set.
Do I miss something?
WanMil _______________________________________________
I'm sorry not to be able to answer your question, but it did trigger a question of my own. Can drive-on-left or drive-on-right be set on a per-tile basis e.g. mapname:63240001 description=UK drive-on-left input-file=63240001.osm.gz mapname:63240002 description=France drive-on-right input-file=63240002.osm.gz Is this currently possible? -- Charlie
Think of using the bounderies-info to find out in with land you are ... Dirk
On 04/01/2012 22:46, WanMil wrote:
While looking through the source code I observed that the drive-on-left/right flag is set statically in the NODHEader class. That means that a threads of one tile modifies this flag of all other tiles. So when compiling a european map with GB included, it's a kind of lottery if the GB areas really have this flag set.
Do I miss something?
WanMil _______________________________________________
I'm sorry not to be able to answer your question, but it did trigger a question of my own.
Can drive-on-left or drive-on-right be set on a per-tile basis e.g.
mapname:63240001 description=UK drive-on-left input-file=63240001.osm.gz
mapname:63240002 description=France drive-on-right input-file=63240002.osm.gz
Is this currently possible?
I think you can but it has the same problem as described above. When compiling both tiles it seems to be possible (I cannot reproduce it - it's just my findings of a code inspection) that the france tile get drive-on-left or the UK tile gets drive-on-right.
On 04/01/12 18:46, WanMil wrote:
While looking through the source code I observed that the drive-on-left/right flag is set statically in the NODHEader class. That means that a threads of one tile modifies this flag of all other tiles. So when compiling a european map with GB included, it's a kind of lottery if the GB areas really have this flag set.
Yes it is totally wrong to save any parameter that can vary per map in a static field. But I guess you knew that ;) The real problem is finding the right place to set it. Most of the code in StyledConverter should be moved elsewhere in my opinion. ..Steve
participants (4)
-
Charlie Ferrero -
flabot＠googlemail.com -
Steve Ratcliffe -
WanMil