option --mdr7-del: change or add new option?
Hi all, the current implementation only removes words from the right. Felix and Mike both suggested to change that so that the listed words are removed anywhere, and I think Arndt's Style would also benefit. Should I simply change the implementation and documentation or is backward compatibility important? If we want to be backward compatible we need a new option. This could be something like --mdr7-delx or --mdr7-del-all Gerd
Hi Gerd, My suggestion was simply that it was more logical to remove them from anywhere, I don't actually use the option. I would be in favour of changing the existing option unless anyone states they specifically need to only remove the words from the end of the label. I would not be in favour of adding a new option unless there are users that need both implementations (which I think is unlikely). The removal of words from anywhere would also give better results in the case where a number of words are added to the label, but one or more of the words has inadvertently been missed from the --mdr7-del option. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 17 January 2022 07:58 To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] option --mdr7-del: change or add new option? Hi all, the current implementation only removes words from the right. Felix and Mike both suggested to change that so that the listed words are removed anywhere, and I think Arndt's Style would also benefit. Should I simply change the implementation and documentation or is backward compatibility important? If we want to be backward compatible we need a new option. This could be something like --mdr7-delx or --mdr7-del-all Gerd
Hi Mike, I fear it is even worth. The usage of mdr7-del seems to corrupt the address search index. Maybe only that for the PC. @Ticker: When mdr7-del is used I see a lot of errors reported by MdrCheck and I can reproduce wrong search results in MapSource. I think the problem is that we calculate the flags based on the name which was processed by mdr7-del, but instead we should use the real name from the label. I hope I can fix that... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Januar 2022 16:13 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] option --mdr7-del: change or add new option? Hi Gerd, My suggestion was simply that it was more logical to remove them from anywhere, I don't actually use the option. I would be in favour of changing the existing option unless anyone states they specifically need to only remove the words from the end of the label. I would not be in favour of adding a new option unless there are users that need both implementations (which I think is unlikely). The removal of words from anywhere would also give better results in the case where a number of words are added to the label, but one or more of the words has inadvertently been missed from the --mdr7-del option. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 17 January 2022 07:58 To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] option --mdr7-del: change or add new option? Hi all, the current implementation only removes words from the right. Felix and Mike both suggested to change that so that the listed words are removed anywhere, and I think Arndt's Style would also benefit. Should I simply change the implementation and documentation or is backward compatibility important? If we want to be backward compatible we need a new option. This could be something like --mdr7-delx or --mdr7-del-all Gerd _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi I was noticing MdrCheck problems in Mdr7 with unicode and string compression - not using mdr7-del so probably because of the shield/prefix/sep/suffix markers. Looks like a slightly related problem. Ticker On Mon, 2022-01-17 at 16:20 +0000, Gerd Petermann wrote:
Hi Mike,
I fear it is even worth. The usage of mdr7-del seems to corrupt the address search index. Maybe only that for the PC.
@Ticker: When mdr7-del is used I see a lot of errors reported by MdrCheck and I can reproduce wrong search results in MapSource. I think the problem is that we calculate the flags based on the name which was processed by mdr7-del, but instead we should use the real name from the label.
I hope I can fix that... Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Januar 2022 16:13 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] option --mdr7-del: change or add new option?
Hi Gerd,
My suggestion was simply that it was more logical to remove them from anywhere, I don't actually use the option. I would be in favour of changing the existing option unless anyone states they specifically need to only remove the words from the end of the label. I would not be in favour of adding a new option unless there are users that need both implementations (which I think is unlikely).
The removal of words from anywhere would also give better results in the case where a number of words are added to the label, but one or more of the words has inadvertently been missed from the --mdr7-del option.
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 17 January 2022 07:58 To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] option --mdr7-del: change or add new option?
Hi all,
the current implementation only removes words from the right. Felix and Mike both suggested to change that so that the listed words are removed anywhere, and I think Arndt's Style would also benefit.
Should I simply change the implementation and documentation or is backward compatibility important? If we want to be backward compatible we need a new option. This could be something like --mdr7-delx or --mdr7-del-all
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Ticker I don't think it's related to compression. I disabled compression and can still reproduce the error. I'll try to assemble a small test set that shows the problem. A simple fix would be to use one of the attached patches. The longer one implements the "remove all words". Both have the negative effect that the list which is shown in MapSource may show the same name multiple times in a weird order. See attached screen shot. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Montag, 17. Januar 2022 17:43 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] option --mdr7-del: change or add new option? Hi I was noticing MdrCheck problems in Mdr7 with unicode and string compression - not using mdr7-del so probably because of the shield/prefix/sep/suffix markers. Looks like a slightly related problem. Ticker On Mon, 2022-01-17 at 16:20 +0000, Gerd Petermann wrote:
Hi Mike,
I fear it is even worth. The usage of mdr7-del seems to corrupt the address search index. Maybe only that for the PC.
@Ticker: When mdr7-del is used I see a lot of errors reported by MdrCheck and I can reproduce wrong search results in MapSource. I think the problem is that we calculate the flags based on the name which was processed by mdr7-del, but instead we should use the real name from the label.
I hope I can fix that... Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Januar 2022 16:13 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] option --mdr7-del: change or add new option?
Hi Gerd,
My suggestion was simply that it was more logical to remove them from anywhere, I don't actually use the option. I would be in favour of changing the existing option unless anyone states they specifically need to only remove the words from the end of the label. I would not be in favour of adding a new option unless there are users that need both implementations (which I think is unlikely).
The removal of words from anywhere would also give better results in the case where a number of words are added to the label, but one or more of the words has inadvertently been missed from the --mdr7-del option.
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 17 January 2022 07:58 To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] option --mdr7-del: change or add new option?
Hi all,
the current implementation only removes words from the right. Felix and Mike both suggested to change that so that the listed words are removed anywhere, and I think Arndt's Style would also benefit.
Should I simply change the implementation and documentation or is backward compatibility important? If we want to be backward compatible we need a new option. This could be something like --mdr7-delx or --mdr7-del-all
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Ticker, one more remark reg. MdrCheck: You have to comment the line collator.setStrength(Collator.SECONDARY); when you check the results from mdr2 branch. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Montag, 17. Januar 2022 18:01 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] option --mdr7-del: change or add new option? Hi Ticker I don't think it's related to compression. I disabled compression and can still reproduce the error. I'll try to assemble a small test set that shows the problem. A simple fix would be to use one of the attached patches. The longer one implements the "remove all words". Both have the negative effect that the list which is shown in MapSource may show the same name multiple times in a weird order. See attached screen shot. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Montag, 17. Januar 2022 17:43 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] option --mdr7-del: change or add new option? Hi I was noticing MdrCheck problems in Mdr7 with unicode and string compression - not using mdr7-del so probably because of the shield/prefix/sep/suffix markers. Looks like a slightly related problem. Ticker On Mon, 2022-01-17 at 16:20 +0000, Gerd Petermann wrote:
Hi Mike,
I fear it is even worth. The usage of mdr7-del seems to corrupt the address search index. Maybe only that for the PC.
@Ticker: When mdr7-del is used I see a lot of errors reported by MdrCheck and I can reproduce wrong search results in MapSource. I think the problem is that we calculate the flags based on the name which was processed by mdr7-del, but instead we should use the real name from the label.
I hope I can fix that... Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Januar 2022 16:13 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] option --mdr7-del: change or add new option?
Hi Gerd,
My suggestion was simply that it was more logical to remove them from anywhere, I don't actually use the option. I would be in favour of changing the existing option unless anyone states they specifically need to only remove the words from the end of the label. I would not be in favour of adding a new option unless there are users that need both implementations (which I think is unlikely).
The removal of words from anywhere would also give better results in the case where a number of words are added to the label, but one or more of the words has inadvertently been missed from the --mdr7-del option.
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 17 January 2022 07:58 To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] option --mdr7-del: change or add new option?
Hi all,
the current implementation only removes words from the right. Felix and Mike both suggested to change that so that the listed words are removed anywhere, and I think Arndt's Style would also benefit.
Should I simply change the implementation and documentation or is backward compatibility important? If we want to be backward compatible we need a new option. This could be something like --mdr7-delx or --mdr7-del-all
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (5)
-
Arndt Röhrig -
Gerd Petermann -
Gerd Petermann
-
Mike Baggaley -
Ticker Berkin