Occasional header corruption in gmapsupp.img

Hi all, once again I stumbled over a really weird problem: In rare cases mkgmap produces a gmasupp.img that shows up as "Map data (c) OpenSt" in the list of maps on my Oregon 550. Screenshots: <http://gis.19327.n5.nabble.com/file/n5825759/bad_01.png> <http://gis.19327.n5.nabble.com/file/n5825759/bad03.png> <http://gis.19327.n5.nabble.com/file/n5825759/bad04.png> <http://gis.19327.n5.nabble.com/file/n5825759/good_01.png> <http://gis.19327.n5.nabble.com/file/n5825759/good03.png> <http://gis.19327.n5.nabble.com/file/n5825759/good04.png> There is no error message or warning when building the gmapsupp.img, I observe this problem for some 4 month now and I can 100% reproduce the bug. It seems to be triggered by the OSM-inputdata although the OSM-data itself is OK. The problem occurred on a DACH-extract with my bikeroute-highlights-overlay style a few months ago, now I have it with a ITALY-extract and my housenumbers-overlay style. Usually I build 6 different gamapsupp.img files for 6 different styles from the same tiles. Only one of them, if any, has the buggy header. The problem usually disappears after an update of the OSM-data, just to reappear a few days or weeks later. I kept 2 versions of the ITALY-extract for reference and with those I can 100% reproduce a faulty gmapsupp.img. I often update the versions of splitter and mkgmap I use for building the maps. mkgmap-r3356 and splitter-r414 still produce the same bug. The problem assembling a test-case is that the ITALY-extract has a size of 1.2 GB . When I remove just one tile from the split extract the gmapsupp.img is OK. I cannot produce a small testcase. I uploaded a sample of a gmapsupp.img with the bug, and one that is error free. http://files.mkgmap.org.uk/download/233/maps.tgz Ciao, Franco -- View this message in context: http://gis.19327.n5.nabble.com/Occasional-header-corruption-in-gmapsupp-img-... Sent from the Mkgmap Development mailing list archive at Nabble.com.

On 29/11/14 07:42, franco_bez wrote:
I uploaded a sample of a gmapsupp.img with the bug, and one that is error free. http://files.mkgmap.org.uk/download/233/maps.tgz
Thanks for the test case. I can see that the 'bad' one is missing the MPS file. If I pull apart the gmapsupp into the separate .img files and then re-make the gmapsupp I can reproduce the missing component. So I should be able to track down the cause. Thanks ..Steve

Hi Steve, sounds great :-) Just in case you need any further information or files, just let me know. I'll try my best to provide them. --- The procedure of creating the to samples was identical save to the slightly different italy-extracts ( one or two days appart ) . So if the MPS file is missing in the image, either mkgmap failed to create it ( but no error message was issued ), or mkgmap failed to include it in the image. Ciao, Franco Steve Ratcliffe wrote
Thanks for the test case. I can see that the 'bad' one is missing the MPS file. If I pull apart the gmapsupp into the separate .img files and then re-make the gmapsupp I can reproduce the missing component. So I should be able to track down the cause.
Thanks ..Steve
-- View this message in context: http://gis.19327.n5.nabble.com/Occasional-header-corruption-in-gmapsupp-img-... Sent from the Mkgmap Development mailing list archive at Nabble.com.

Hi
once again I stumbled over a really weird problem:
I have a patch for this problem. A size calculation was wrong leading to the first file entry being overridden. Patch attached and pre-built jar file at: http://files.mkgmap.org.uk/download/234/mkgmap.jar Thanks, ..Steve

Hi Steve, good work :-) using your pre-built mkgmak.jar both my test-cases produce error-free gmapsupp.img files. seems fixed to me. Ciao, Franco Steve Ratcliffe wrote
Hi
once again I stumbled over a really weird problem:
I have a patch for this problem. A size calculation was wrong leading to the first file entry being overridden.
Patch attached and pre-built jar file at: http://files.mkgmap.org.uk/download/234/mkgmap.jar
Thanks, ..Steve
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Sometimes_mps_file_not_present_in_gmapsupp.patch (1K) <http://gis.19327.n5.nabble.com/attachment/5825897/0/Sometimes_mps_file_not_p...;
-- View this message in context: http://gis.19327.n5.nabble.com/Occasional-header-corruption-in-gmapsupp-img-... Sent from the Mkgmap Development mailing list archive at Nabble.com.

Hi Steve, Could you occasionally commit this fix to svn ? Ciao, Franco -- View this message in context: http://gis.19327.n5.nabble.com/Occasional-header-corruption-in-gmapsupp-img-... Sent from the Mkgmap Development mailing list archive at Nabble.com.
participants (2)
-
franco_bez
-
Steve Ratcliffe