Commit: r1101: Further work on loop splitting code.
Version 1101 was commited by markb on 2009-07-24 00:02:50 +0100 (Fri, 24 Jul 2009) Further work on loop splitting code. Two changes: 1 - the recent commit that changed the test to see whether splitting a way would introduce a short arc was too strict in that it checked to see if the candidate splitting point was too close to its nearest neighbour points but as they may not be nodes it doesn't matter how close it is to them, what matters is that it isn't too close to any nodes in the way so this commit now adds method safeToSplitWay() that decides whether adding a node at a given point in a way does not introduce any short arcs. 2 - In the situation where the looped way cannot be split without introducing a short arc, it now aggressively prunes the way to remove the loop without producing a short arc. It removes the point that completes the loop and then, if it was the last point in the way, keeps removing the new last point until either no short arc will be created or all the points back to the start of the loop have been removed.
Hi Mark, I just ran mkgmap without --route: mintest/mkgmap/dist/mkgmap.jar --country-name=Nederland --country-abbr=NL --latin1 --remove-short-arcs --lower-case --preserve-element-order --location-autofill-1 --gmapsupp --tdbfile -c template.args and it tells me: SEVERE (RoadNetwork): Road Diemerdreef (OSM id 24975519) contains zero length arc I don't know if I should be worried - as said, it's without routing code - but you might be interested. V. svn commit schreef:
Further work on loop splitting code. [...] -- Durgerdamstraat 29, 1507 JL Zaandam; telefoon 075-7074579
Hi Valentijn,
I just ran mkgmap without --route:
Thanks, that's another buglet squished. I've committed a fix. Incidentally, that way, Road Diemerdreef (OSM id 24975519), is a really dumb bit of OSM. It's a roundabout with about 20 points and has a diameter of about 1m! Why do people do that? http://www.openstreetmap.org/?lat=52.331227&lon=4.956253&zoom=20 Cheers, Mark
Mark Burton schreef:
Incidentally, that way, Road Diemerdreef (OSM id 24975519), is a really dumb bit of OSM. It's a roundabout with about 20 points and has a diameter of about 1m! Why do people do that?
I wouldn't know, I'm an IT person. My wife though is a psychologist. Do you want me to file a bug? ;)
http://www.openstreetmap.org/?lat=52.331227&lon=4.956253&zoom=20
All right, fixed it for you. V.
Hi,
Incidentally, that way, Road Diemerdreef (OSM id 24975519), is a really dumb bit of OSM. It's a roundabout with about 20 points and has a diameter of about 1m! Why do people do that?
I wouldn't know, I'm an IT person. My wife though is a psychologist. Do you want me to file a bug? ;)
Sure, start a bugzilla for the human race, there's a thought!
http://www.openstreetmap.org/?lat=52.331227&lon=4.956253&zoom=20
All right, fixed it for you.
That's kind. BTW, do you have mini roundabouts? If so, should it have been one of them? Cheers, Mark
Mark Burton escribió:
Hi Valentijn,
I just ran mkgmap without --route:
Thanks, that's another buglet squished. I've committed a fix.
Incidentally, that way, Road Diemerdreef (OSM id 24975519), is a really dumb bit of OSM. It's a roundabout with about 20 points and has a diameter of about 1m! Why do people do that?
I don't know why do they, but that's not the only one. Since the "zero lenght arc" warning is turned on I've had to fix 4-5 of such mini mini miniroundabouts in Spain data. Cheers Carlos
Hi, I get a lot of the same errors with the latest r1102: For example: 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Willishausener Straße (OSM id 24346402) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road null (OSM id 32230489) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Schwabenstraße (OSM id 24896625) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Salomon-Idler-Straße (OSM id 4355666) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road null (OSM id 24874441) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Rathausplatz (OSM id 24598018) contains zero length arc ^C2009/07/25 09:07:50 SCHWERWIEGEND (RoadNetwork): Road null (OSM id 24886327) contains zero length arc My commandline is java -Xmx1200M -Dlog.config=log.config -ea uk.me.parabola.mkgmap.main.Main --route --latin1 --gmapsupp --country-name=DEUTSCHLAND --country-abbr=D --family-id=42 --no-sorted-roads 6324000*.osm.gz and I'm trying the latest osm data from bavaria, taken from geofabrik. Is this another bug or wrong data? (At the moment I've not have a detailed look at the places, where this errors occur) Regards, Johann Valentijn Sessink schrieb:
Hi Mark,
I just ran mkgmap without --route: mintest/mkgmap/dist/mkgmap.jar --country-name=Nederland --country-abbr=NL --latin1 --remove-short-arcs --lower-case --preserve-element-order --location-autofill-1 --gmapsupp --tdbfile -c template.args
and it tells me:
SEVERE (RoadNetwork): Road Diemerdreef (OSM id 24975519) contains zero length arc
I don't know if I should be worried - as said, it's without routing code - but you might be interested.
V.
svn commit schreef:
Further work on loop splitting code.
[...]
Hi Johann,
I get a lot of the same errors with the latest r1102: For example:
2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Willishausener Straße (OSM id 24346402) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road null (OSM id 32230489) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Schwabenstraße (OSM id 24896625) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Salomon-Idler-Straße (OSM id 4355666) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road null (OSM id 24874441) contains zero length arc 2009/07/25 09:07:47 SCHWERWIEGEND (RoadNetwork): Road Rathausplatz (OSM id 24598018) contains zero length arc ^C2009/07/25 09:07:50 SCHWERWIEGEND (RoadNetwork): Road null (OSM id 24886327) contains zero length arc
My commandline is java -Xmx1200M -Dlog.config=log.config -ea uk.me.parabola.mkgmap.main.Main --route --latin1 --gmapsupp --country-name=DEUTSCHLAND --country-abbr=D --family-id=42 --no-sorted-roads 6324000*.osm.gz
and I'm trying the latest osm data from bavaria, taken from geofabrik.
Is this another bug or wrong data? (At the moment I've not have a detailed look at the places, where this errors occur)
Use --remove-short-arcs and these should go away. Please say if any remain. Cheers, Mark
participants (5)
-
Carlos Dávila -
Johann Gail -
Mark Burton -
svn commit -
Valentijn Sessink